UploadFileStorageProvider::select() - Code Metrics - Inspection of "change signature or DoctrineQueryStorageProvider" - mathielen/import-engine - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 252438...82275d )

by Markus

created 2016-02-06 09:29 UTC

UploadFileStorageProvider::select() A

↳ Parent: UploadFileStorageProvider

Complexity

Conditions	3
Paths	3

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3.0067

Importance

Changes	4
Bugs	1	Features	0

Metric	Value
c	4
b	1
f	0
dl	0
loc	19
ccs	10
cts	11
cp	0.9091
rs	9.4285
cc	3
eloc	11
nc	3
nop	1
crap	3.0067

<?php
namespace Mathielen\ImportEngine\Storage\Provider;

use Mathielen\ImportEngine\Storage\Factory\StorageFactoryInterface;
use Symfony\Component\HttpFoundation\File\UploadedFile;
use Mathielen\ImportEngine\ValueObject\StorageSelection;

class UploadFileStorageProvider extends FileStorageProvider
{

    private $targetDirectory;

    public function __construct($targetDirectory, StorageFactoryInterface $storageFactory=null)
    {
        parent::__construct($storageFactory);

        if (!is_dir($targetDirectory) || !is_writeable($targetDirectory)) {
            throw new \InvalidArgumentException("Targetdirectory $targetDirectory is not writable!");
        }

        $this->targetDirectory = realpath($targetDirectory);
    }

    /**
     * (non-PHPdoc)
     * @see \Mathielen\ImportEngine\Storage\Provider\StorageProviderInterface::select()
     */
    public function select($id = null)
    {
        if ($id instanceof UploadedFile) {
            if (!$id->isValid()) {
                throw new \InvalidArgumentException("Upload was not successful");
            }

            $newFile = $id->move($this->targetDirectory, $this->generateTargetFilename($id));

            $selection = new StorageSelection(
                new \SplFileInfo($newFile),
                $this->targetDirectory.  '/' . $newFile->getFilename(),
                $id->getClientOriginalName());

            return $selection;
        }

        return parent::select($id);
    }

    private function generateTargetFilename(UploadedFile $file)
    {
        return uniqid() . '_' . $file->getClientOriginalName();
    }

}


1		<?php
2		namespace Mathielen\ImportEngine\Storage\Provider;
3
4		use Mathielen\ImportEngine\Storage\Factory\StorageFactoryInterface;
5		use Symfony\Component\HttpFoundation\File\UploadedFile;
6		use Mathielen\ImportEngine\ValueObject\StorageSelection;
7
8		class UploadFileStorageProvider extends FileStorageProvider
9		{
10
11		private $targetDirectory;
12
13	4	public function __construct($targetDirectory, StorageFactoryInterface $storageFactory=null)
14		{
15	4	parent::__construct($storageFactory);
16
17	4	if (!is_dir($targetDirectory) \|\| !is_writeable($targetDirectory)) {
18	1	throw new \InvalidArgumentException("Targetdirectory $targetDirectory is not writable!");
19		}
20
21	3	$this->targetDirectory = realpath($targetDirectory);
22	3	}
23
24		/**
25		* (non-PHPdoc)
26		* @see \Mathielen\ImportEngine\Storage\Provider\StorageProviderInterface::select()
27		*/
28	2	public function select($id = null)
29		{
30	2	if ($id instanceof UploadedFile) {
31	2	if (!$id->isValid()) {
32	1	throw new \InvalidArgumentException("Upload was not successful");
33		}
34
35	1	$newFile = $id->move($this->targetDirectory, $this->generateTargetFilename($id));
36
37	1	$selection = new StorageSelection(
38	1	new \SplFileInfo($newFile),
39	1	$this->targetDirectory. '/' . $newFile->getFilename(),
40	1	$id->getClientOriginalName());
41
42	1	return $selection;
43		}
44
45		return parent::select($id);
46		}
47
48	1	private function generateTargetFilename(UploadedFile $file)
49		{
50	1	return uniqid() . '_' . $file->getClientOriginalName();
51		}
52
53		}
54

mathielen / import-engine

Push — master ( 252438...82275d )

UploadFileStorageProvider::select() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like