Mathielen\ImportEngine\Storage\ServiceStorage

Complexity

Total Complexity

9

Size/Duplication

Total Lines	94
Duplicated Lines	9.57 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

68.42%

Importance

Changes	7
Bugs	0	Features	1

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
A	getCallable()	0	4	1
A	setObjectFactory()	0	4	1
A	setObjectTransformer()	0	4	1
A	reader()	0	10	1
A	writer()	0	9	1
A	info()	9	9	1
A	getFields()	0	4	1

<?php
namespace Mathielen\ImportEngine\Storage;

use Mathielen\DataImport\Reader\ServiceReader;
use Mathielen\DataImport\Writer\ServiceWriter;

class ServiceStorage implements StorageInterface
{

    /**
     * @var callable
     */
    private $callable;

    /**
     * @var array
     */
    private $arguments;

    private $objectTransformer;
    private $objectFactory;

    public function __construct(callable $callable, $arguments=array(), $objectMapper=null)
    {
        $this->callable = $callable;
        $this->arguments = $arguments;
        $this->setObjectFactory($objectMapper);
        $this->setObjectTransformer($objectMapper);

        if (!is_callable($callable)) {
            throw new \InvalidArgumentException("Given callable is not a callable");
        }
    }

    /**
     * @return callable
     */
    public function getCallable()
    {
        return $this->callable;
    }

    public function setObjectFactory($objectFactory)
    {
        $this->objectFactory = $objectFactory;
    }

    public function setObjectTransformer($objectTransformer)
    {
        $this->objectTransformer = $objectTransformer;
    }

    /*
     * (non-PHPdoc) @see \Mathielen\ImportEngine\Storage\StorageInterface::reader()
     */
    public function reader()
    {
        $reader = new ServiceReader(
            $this->callable,
            $this->arguments,
            $this->objectTransformer

The call to ServiceReader::__construct() has too many arguments starting with $this->objectTransformer.

        );

        return $reader;
    }

    /*
     * (non-PHPdoc) @see \Mathielen\ImportEngine\Storage\StorageInterface::writer()
     */
    public function writer()
    {
        $writer = new ServiceWriter(
            $this->callable,
            $this->objectFactory
        );

        return $writer;
    }

    /*
     * (non-PHPdoc) @see \Mathielen\ImportEngine\Storage\StorageInterface::info()
     */
    public function info()

This method seems to be duplicated in your project.

    {
        return new StorageInfo(array(
            'name' => $this->callable.'',
            'format' => 'Service method',
            'size' => 0,
            'count' => count($this->reader())
        ));
    }

    /*
     * (non-PHPdoc) @see \Mathielen\ImportEngine\Storage\StorageInterface::getFields()
     */
    public function getFields()
    {
        return $this->reader()->getFields();
    }
}