Mathielen\ImportEngine\Storage\ObjectStorage

Complexity

Total Complexity

8

Size/Duplication

Total Lines	71
Duplicated Lines	18.31 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	13	13	4
A	getFields()	0	6	1
A	reader()	0	4	1
A	writer()	0	11	1
A	info()	0	5	1

<?php

namespace Mathielen\ImportEngine\Storage;

use Mathielen\DataImport\Writer\ObjectWriter;
use Mathielen\ImportEngine\Storage\Parser\JmsMetadataParser;
use Mathielen\DataImport\Writer\ObjectWriter\ObjectFactoryInterface;
use Mathielen\DataImport\Writer\ObjectWriter\DefaultObjectFactory;

class ObjectStorage extends \SplObjectStorage implements StorageInterface
{
    /**
     * @var ObjectFactoryInterface
     */
    private $objectFactory;

    /**
     * @var JmsMetadataParser
     */
    private $metadataParser;

    public function __construct($classOrObjectFactory, JmsMetadataParser $metadataParser)

This method seems to be duplicated in your project.

    {
        if (is_object($classOrObjectFactory) && $classOrObjectFactory instanceof ObjectFactoryInterface) {
            $objectFactory = $classOrObjectFactory;
        } elseif (is_string($classOrObjectFactory)) {
            $objectFactory = new DefaultObjectFactory($classOrObjectFactory);
        } else {
            throw new \InvalidArgumentException('classOrObjectFactory must be of type string or ObjectFactoryInterface');
        }

        $this->objectFactory = $objectFactory;
        $this->metadataParser = $metadataParser;
    }

    public function getFields()
    {
        $fields = $this->metadataParser->parse(array('class' => $this->objectFactory->getClassname(), 'groups' => array()));

The method getClassname() does not seem to exist on object<Mathielen\DataImport\Writer\ObjectWriter\ObjectFactoryInterface>.

        return $fields;
    }

    /**
     * (non-PHPdoc).
     *
     * @see \Mathielen\ImportEngine\Source\SourceInterface::reader()
     */
    public function reader()
    {
        //@TODO implement me
    }

    /**
     * (non-PHPdoc).
     *
     * @see \Mathielen\ImportEngine\Source\StorageInterface::writer()
     */
    public function writer()
    {
        $writer = new ObjectWriter($this->objectFactory);

$this->objectFactory is of type object<Mathielen\DataImport\Writer\ObjectWriter\ObjectFactoryInterface>, but the function expects a object<SplObjectStorage>.

        $storage = $this;
        $writer->setObjectHandler(function ($object) use ($storage) {

The method setObjectHandler() does not seem to exist on object<Mathielen\DataImport\Writer\ObjectWriter>.

            $storage->attach($object);
        });

        return $writer;
    }

    /**
     * (non-PHPdoc).
     *
     * @see \Mathielen\ImportEngine\Source\SourceInterface::info()
     */
    public function info()
    {
        return new StorageInfo(array(
        ));
    }
}