Mathielen\ImportEngine\LocalFileTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	10

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testImport()	0	38	4
A	getStorages()	0	10	1

<?php
namespace Mathielen\ImportEngine;

use Mathielen\ImportEngine\Import\Import;
use Mathielen\ImportEngine\Import\Run\ImportRunner;
use Mathielen\ImportEngine\Importer\Importer;
use Mathielen\ImportEngine\Storage\Format\CompressedFormat;
use Mathielen\ImportEngine\Storage\Format\CsvFormat;
use Mathielen\ImportEngine\Storage\Format\ExcelFormat;
use Mathielen\ImportEngine\Storage\Format\Format;
use Mathielen\ImportEngine\Storage\Format\XmlFormat;
use Mathielen\ImportEngine\Storage\LocalFileStorage;
use Mathielen\ImportEngine\Storage\StorageInfo;
use Mathielen\ImportEngine\ValueObject\ImportConfiguration;
use Mathielen\ImportEngine\ValueObject\ImportRun;

class LocalFileTest extends \PHPUnit_Framework_TestCase
{

    /**
     * @dataProvider getStorages
     * @medium
     */
    public function testImport($sourceFile, Format $format, Format $targetFormat=null)
    {
        if (!$targetFormat) {
            $targetFormat = $format;
        }

        $targetFile = tempnam('/tmp', 'test');
        @unlink($targetFile);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        $sourceStorage = new LocalFileStorage(new \SplFileInfo($sourceFile), $format);
        $targetStorage = new LocalFileStorage(new \SplFileInfo($targetFile), $targetFormat);

        $this->assertEquals(new StorageInfo(array(
            'name' => basename($targetFile),
            'hash' => null,
            'format' => $targetFormat,
            'size' => 0,
            'count' => 0
        )), $targetStorage->info());

        $importer = Importer::build($targetStorage);

        $importConfiguration = new ImportConfiguration();
        $importRun = $importConfiguration->toRun();

        $import = Import::build($importer, $sourceStorage, $importRun);

        $importRunner = new ImportRunner();
        $importRunner->run($import);

        $this->assertFileExists($targetFile);

        if ($format instanceof XmlFormat) {
            $this->assertXmlFileEqualsXmlFile($sourceFile, $targetFile);
        } elseif ($format instanceof CsvFormat) {
            $this->assertFileEquals($sourceFile, $targetFile);
        }
    }

    public function getStorages()
    {
        return array(
            array(__DIR__ . '/../../../metadata/testfiles/flatdata.csv', new CsvFormat()),
            array(__DIR__ . '/../../../metadata/testfiles/flatdata-excel.xls', new ExcelFormat(false)),
            array(__DIR__ . '/../../../metadata/testfiles/flatdata-excel-xml.xlsx', new ExcelFormat(false)),
            array(__DIR__ . '/../../../metadata/testfiles/flatdata-csv-zip.zip', new CompressedFormat('testmapping.csv', 'zip', new CsvFormat()), new CsvFormat()),
            array(__DIR__ . '/../../../metadata/testfiles/hierarchicaldata-xml.xml', new XmlFormat()),
        );
    }

}