matecat / xliff-parser

src/XliffReplacer/Xliff20.php

Spacing +68 added lines, -68 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * @var bool
      */
-    protected bool $unitContainsMda = false;   // check if <unit> already contains a <mda:metadata> (forXliff v 2.*)
+    protected bool $unitContainsMda = false; // check if <unit> already contains a <mda:metadata> (forXliff v 2.*)
 
     /**
      * @var string
@@ -35,7 +35,7 @@ 
     /**
      * @var string
      */
-    protected string $namespace = "matecat";       // Custom namespace
+    protected string $namespace = "matecat"; // Custom namespace
 
     /**
      * @var array
@@ -51,23 +51,23 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagOpen( $parser, string $name, array $attr ) {
+    protected function tagOpen($parser, string $name, array $attr) {
 
-        $this->handleOpenUnit( $name, $attr );
+        $this->handleOpenUnit($name, $attr);
 
-        if ( 'mda:metadata' === $name ) {
+        if ('mda:metadata' === $name) {
             $this->unitContainsMda = true;
         }
 
-        $this->trySetAltTrans( $name );;
-        $this->checkSetInTarget( $name );
+        $this->trySetAltTrans($name); ;
+        $this->checkSetInTarget($name);
 
         // open buffer
-        $this->setInBuffer( $name );
+        $this->setInBuffer($name);
 
         // check if we are inside a <target>, obviously this happen only if there are targets inside the trans-unit
         // <target> must be stripped to be replaced, so this check avoids <target> reconstruction
-        if ( !$this->inTarget ) {
+        if (!$this->inTarget) {
 
             $tag = '';
 
@@ -89,48 +89,48 @@ 
             //
             // http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#unit
             //
-            if ( in_array( $name, [ 'notes', 'originalData', 'segment', 'ignorable' ] ) &&
+            if (in_array($name, ['notes', 'originalData', 'segment', 'ignorable']) &&
                     $this->unitContainsMda === false &&
-                    !empty( $this->transUnits[ $this->currentTransUnitId ] ) &&
+                    !empty($this->transUnits[$this->currentTransUnitId]) &&
                     !$this->hasWrittenCounts
             ) {
                 // we need to update counts here
                 $this->updateCounts();
                 $this->hasWrittenCounts = true;
-                $tag                    .= $this->getWordCountGroupForXliffV2();
+                $tag .= $this->getWordCountGroupForXliffV2();
                 $this->unitContainsMda  = true;
             }
 
             // construct tag
             $tag .= "<$name ";
 
-            foreach ( $attr as $k => $v ) {
+            foreach ($attr as $k => $v) {
                 //normal tag flux, put attributes in it but skip for translation state and set the right value for the attribute
-                if ( $k != 'state' ) {
+                if ($k != 'state') {
                     $tag .= "$k=\"$v\" ";
                 }
             }
 
             $seg = $this->getCurrentSegment();
 
-            if ( $name === $this->tuTagName && !empty( $seg ) && isset( $seg[ 'sid' ] ) ) {
+            if ($name === $this->tuTagName && !empty($seg) && isset($seg['sid'])) {
 
                 // add `matecat:segment-id` to xliff v.2*
-                if ( strpos( $tag, 'matecat:segment-id' ) === false ) {
-                    $tag .= "matecat:segment-id=\"{$seg[ 'sid' ]}\" ";
+                if (strpos($tag, 'matecat:segment-id') === false) {
+                    $tag .= "matecat:segment-id=\"{$seg['sid']}\" ";
                 }
 
             }
 
             // replace state for xliff v2
-            if ( 'segment' === $name ) { // add state to segment in Xliff v2
-                [ $stateProp, ] = StatusToStateAttribute::getState( $this->xliffVersion, $seg[ 'status' ] );
+            if ('segment' === $name) { // add state to segment in Xliff v2
+                [$stateProp, ] = StatusToStateAttribute::getState($this->xliffVersion, $seg['status']);
                 $tag .= $stateProp;
             }
 
-            $tag = $this->handleOpenXliffTag( $name, $attr, $tag );
+            $tag = $this->handleOpenXliffTag($name, $attr, $tag);
 
-            $this->checkForSelfClosedTagAndFlush( $parser, $tag );
+            $this->checkForSelfClosedTagAndFlush($parser, $tag);
 
         }
 
@@ -143,10 +143,10 @@ 
      *
      * @return string
      */
-    protected function handleOpenXliffTag( string $name, array $attr, string $tag ): string {
-        $tag = parent::handleOpenXliffTag( $name, $attr, $tag );
+    protected function handleOpenXliffTag(string $name, array $attr, string $tag): string {
+        $tag = parent::handleOpenXliffTag($name, $attr, $tag);
         // add oasis xliff 20 namespace
-        if ( $name === 'xliff' && !array_key_exists( 'xmlns:mda', $attr ) ) {
+        if ($name === 'xliff' && !array_key_exists('xmlns:mda', $attr)) {
             $tag .= 'xmlns:mda="urn:oasis:names:tc:xliff:metadata:2.0"';
         }
 
@@ -156,7 +156,7 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagClose( $parser, string $name ) {
+    protected function tagClose($parser, string $name) {
         $tag = '';
 
         /**
@@ -165,39 +165,39 @@ 
          *
          * self::tagOpen method
          */
-        if ( !$this->isEmpty ) {
+        if (!$this->isEmpty) {
 
             // write closing tag if is not a target
             // EXCLUDE the target nodes with currentTransUnitIsTranslatable = 'NO'
-            if ( !$this->inTarget and $this->currentTransUnitIsTranslatable !== 'no' ) {
+            if (!$this->inTarget and $this->currentTransUnitIsTranslatable !== 'no') {
                 $tag = "</$name>";
             }
 
-            if ( 'target' == $name && !$this->inAltTrans ) {
+            if ('target' == $name && !$this->inAltTrans) {
 
-                if ( isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
+                if (isset($this->transUnits[$this->currentTransUnitId])) {
 
                     $seg = $this->getCurrentSegment();
 
                     // update counts
-                    if ( !$this->hasWrittenCounts && !empty( $seg ) ) {
-                        $this->updateSegmentCounts( $seg );
+                    if (!$this->hasWrittenCounts && !empty($seg)) {
+                        $this->updateSegmentCounts($seg);
                     }
 
                     // delete translations so the prepareSegment
                     // will put source content in target tag
-                    if ( $this->sourceInTarget ) {
-                        $seg[ 'translation' ] = '';
+                    if ($this->sourceInTarget) {
+                        $seg['translation'] = '';
                         $this->resetCounts();
                     }
 
                     // append $translation
-                    $translation = $this->prepareTranslation( $seg );
+                    $translation = $this->prepareTranslation($seg);
 
                     //append translation
                     $tag = "<target>$translation</target>";
 
-                } elseif( !empty($this->CDATABuffer) and $this->currentTransUnitIsTranslatable === 'no' ) {
+                } elseif (!empty($this->CDATABuffer) and $this->currentTransUnitIsTranslatable === 'no') {
 
                     // These are target nodes with currentTransUnitIsTranslatable = 'NO'
                     $this->bufferIsActive = false;
@@ -208,22 +208,22 @@ 
                 // signal we are leaving a target
                 $this->targetWasWritten = true;
                 $this->inTarget         = false;
-                $this->postProcAndFlush( $this->outputFP, $tag, true );
+                $this->postProcAndFlush($this->outputFP, $tag, true);
 
-            } elseif ( in_array( $name, $this->nodesToBuffer ) ) { // we are closing a critical CDATA section
+            } elseif (in_array($name, $this->nodesToBuffer)) { // we are closing a critical CDATA section
 
                 $this->bufferIsActive = false;
 
                 // only for Xliff 2.*
                 // write here <mda:metaGroup> and <mda:meta> if already present in the <unit>
-                if ( 'mda:metadata' === $name && $this->unitContainsMda && !$this->hasWrittenCounts ) {
+                if ('mda:metadata' === $name && $this->unitContainsMda && !$this->hasWrittenCounts) {
 
                     // we need to update counts here
                     $this->updateCounts();
                     $this->hasWrittenCounts = true;
 
                     $tag = $this->CDATABuffer;
-                    $tag .= $this->getWordCountGroupForXliffV2( false );
+                    $tag .= $this->getWordCountGroupForXliffV2(false);
                     $tag .= "    </mda:metadata>";
 
                 } else {
@@ -233,19 +233,19 @@ 
                 $this->CDATABuffer = "";
 
                 //flush to the pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
-            } elseif ( 'segment' === $name ) {
+            } elseif ('segment' === $name) {
 
                 // only for Xliff 2.*
                 // if segment has no <target> add it BEFORE </segment>
-                if ( !$this->targetWasWritten ) {
+                if (!$this->targetWasWritten) {
 
                     $seg = $this->getCurrentSegment();
 
-                    if ( isset( $seg[ 'translation' ] ) ) {
+                    if (isset($seg['translation'])) {
 
-                        $translation = $this->prepareTranslation( $seg );
+                        $translation = $this->prepareTranslation($seg);
                         // replace the tag
                         $tag = "<target>$translation</target>";
 
@@ -258,19 +258,19 @@ 
                 // update segmentPositionInTu
                 $this->segmentInUnitPosition++;
 
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
                 // we are leaving <segment>, reset $segmentHasTarget
                 $this->targetWasWritten = false;
 
-            } elseif ( $this->bufferIsActive ) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
+            } elseif ($this->bufferIsActive) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
                 $this->CDATABuffer .= "</$name>";
                 // Do NOT Flush
             } else { //generic tag closure do Nothing
                 // flush to pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
             }
-        } elseif ( in_array( $name, $this->nodesToBuffer ) ) {
+        } elseif (in_array($name, $this->nodesToBuffer)) {
 
             $this->isEmpty        = false;
             $this->bufferIsActive = false;
@@ -278,7 +278,7 @@ 
             $this->CDATABuffer    = "";
 
             //flush to the pointer
-            $this->postProcAndFlush( $this->outputFP, $tag );
+            $this->postProcAndFlush($this->outputFP, $tag);
 
         } else {
             //ok, nothing to be done; reset flag for next coming tag
@@ -286,10 +286,10 @@ 
         }
 
         // try to signal that we are leaving a target
-        $this->tryUnsetAltTrans( $name );
+        $this->tryUnsetAltTrans($name);
 
         // check if we are leaving a <trans-unit> (xliff v1.*) or <unit> (xliff v2.*)
-        if ( $this->tuTagName === $name ) {
+        if ($this->tuTagName === $name) {
             $this->currentTransUnitIsTranslatable = null;
             $this->inTU                           = false;
             $this->unitContainsMda                = false;
@@ -305,8 +305,8 @@ 
     private function updateCounts() {
 
         $seg = $this->getCurrentSegment();
-        if ( !empty( $seg ) ) {
-            $this->updateSegmentCounts( $seg );
+        if (!empty($seg)) {
+            $this->updateSegmentCounts($seg);
         }
 
     }
@@ -316,30 +316,30 @@ 
      *
      * @return string
      */
-    private function getWordCountGroupForXliffV2( bool $withMetadataTag = true ): string {
+    private function getWordCountGroupForXliffV2(bool $withMetadataTag = true): string {
 
         $this->mdaGroupCounter++;
-        $segments_count_array = $this->counts[ 'segments_count_array' ];
+        $segments_count_array = $this->counts['segments_count_array'];
 
         $tag = '';
 
-        if ( $withMetadataTag === true ) {
+        if ($withMetadataTag === true) {
             $tag .= '<mda:metadata>';
         }
 
         $index = 0;
-        foreach ( $segments_count_array as $segments_count_item ) {
+        foreach ($segments_count_array as $segments_count_item) {
 
             $id = 'word_count_tu.' . $this->currentTransUnitId . '.' . $index;
             $index++;
 
             $tag .= "    <mda:metaGroup id=\"" . $id . "\" category=\"row_xml_attribute\">
-                                <mda:meta type=\"x-matecat-raw\">" . $segments_count_item[ 'raw_word_count' ] . "</mda:meta>
-                                <mda:meta type=\"x-matecat-weighted\">" . $segments_count_item[ 'eq_word_count' ] . "</mda:meta>
+                                <mda:meta type=\"x-matecat-raw\">" . $segments_count_item['raw_word_count'] . "</mda:meta>
+                                <mda:meta type=\"x-matecat-weighted\">" . $segments_count_item['eq_word_count'] . "</mda:meta>
                             </mda:metaGroup>";
         }
 
-        if ( $withMetadataTag === true ) {
+        if ($withMetadataTag === true) {
             $tag .= '</mda:metadata>';
         }
 
@@ -354,18 +354,18 @@ 
      *
      * @return string
      */
-    protected function prepareTranslation( array $seg ): string {
+    protected function prepareTranslation(array $seg): string {
 
-        $segment     = Strings::removeDangerousChars( $seg [ 'segment' ] );
-        $translation = Strings::removeDangerousChars( $seg [ 'translation' ] );
-        $dataRefMap  = ( isset( $seg[ 'data_ref_map' ] ) ) ? Strings::jsonToArray( $seg[ 'data_ref_map' ] ) : [];
+        $segment     = Strings::removeDangerousChars($seg ['segment']);
+        $translation = Strings::removeDangerousChars($seg ['translation']);
+        $dataRefMap  = (isset($seg['data_ref_map'])) ? Strings::jsonToArray($seg['data_ref_map']) : [];
 
-        if ( $seg [ 'translation' ] == '' ) {
+        if ($seg ['translation'] == '') {
             $translation = $segment;
         } else {
-            if ( $this->callback instanceof XliffReplacerCallbackInterface ) {
-                $error = ( !empty( $seg[ 'error' ] ) ) ? $seg[ 'error' ] : null;
-                if ( $this->callback->thereAreErrors( $seg[ 'sid' ], $segment, $translation, $dataRefMap, $error ) ) {
+            if ($this->callback instanceof XliffReplacerCallbackInterface) {
+                $error = (!empty($seg['error'])) ? $seg['error'] : null;
+                if ($this->callback->thereAreErrors($seg['sid'], $segment, $translation, $dataRefMap, $error)) {
                     $translation = '|||UNTRANSLATED_CONTENT_START|||' . $segment . '|||UNTRANSLATED_CONTENT_END|||';
                 }
             }

src/XliffReplacer/Xliff12.php

Spacing +63 added lines, -63 removed lines

@@ -36,34 +36,34 @@ 
     /**
      * @var string
      */
-    protected string $namespace = "mtc";       // Custom namespace
+    protected string $namespace = "mtc"; // Custom namespace
 
     /**
      * @inheritDoc
      */
-    protected function tagOpen( $parser, string $name, array $attr ) {
+    protected function tagOpen($parser, string $name, array $attr) {
 
-        $this->handleOpenUnit( $name, $attr );
+        $this->handleOpenUnit($name, $attr);
 
-        $this->trySetAltTrans( $name );;
-        $this->checkSetInTarget( $name );
+        $this->trySetAltTrans($name); ;
+        $this->checkSetInTarget($name);
 
         // open buffer
-        $this->setInBuffer( $name );
+        $this->setInBuffer($name);
 
         // check if we are inside a <target>, obviously this happen only if there are targets inside the trans-unit
         // <target> must be stripped to be replaced, so this check avoids <target> reconstruction
-        if ( !$this->inTarget ) {
+        if (!$this->inTarget) {
 
             $tag = '';
 
             // construct tag
             $tag .= "<$name ";
 
-            foreach ( $attr as $k => $v ) {
+            foreach ($attr as $k => $v) {
 
                 //if tag name is file, we must replace the target-language attribute
-                if ( $name === 'file' && $k === 'target-language' && !empty( $this->targetLang ) ) {
+                if ($name === 'file' && $k === 'target-language' && !empty($this->targetLang)) {
                     //replace Target language with job language provided from constructor
                     $tag .= "$k=\"$this->targetLang\" ";
                 } else {
@@ -74,20 +74,20 @@ 
 
             $seg = $this->getCurrentSegment();
 
-            if ( $name === $this->tuTagName && !empty( $seg ) && isset( $seg[ 'sid' ] ) ) {
+            if ($name === $this->tuTagName && !empty($seg) && isset($seg['sid'])) {
 
                 // add `help-id` to xliff v.1*
-                if ( strpos( $tag, 'help-id' ) === false ) {
-                    if ( !empty( $seg[ 'sid' ] ) ) {
-                        $tag .= "help-id=\"{$seg[ 'sid' ]}\" ";
+                if (strpos($tag, 'help-id') === false) {
+                    if (!empty($seg['sid'])) {
+                        $tag .= "help-id=\"{$seg['sid']}\" ";
                     }
                 }
 
             }
 
-            $tag = $this->handleOpenXliffTag( $name, $attr, $tag );
+            $tag = $this->handleOpenXliffTag($name, $attr, $tag);
 
-            $this->checkForSelfClosedTagAndFlush( $parser, $tag );
+            $this->checkForSelfClosedTagAndFlush($parser, $tag);
 
         }
 
@@ -97,7 +97,7 @@ 
     /**
      * @inheritDoc
      */
-    protected function tagClose( $parser, string $name ) {
+    protected function tagClose($parser, string $name) {
         $tag = '';
 
         /**
@@ -106,23 +106,23 @@ 
          *
          * self::tagOpen method
          */
-        if ( !$this->isEmpty ) {
+        if (!$this->isEmpty) {
 
             // write closing tag if is not a target
             // EXCLUDE the target nodes with currentTransUnitIsTranslatable = 'NO'
-            if ( !$this->inTarget and $this->currentTransUnitIsTranslatable !== 'no' ) {
+            if (!$this->inTarget and $this->currentTransUnitIsTranslatable !== 'no') {
                 $tag = "</$name>";
             }
 
-            if ( 'target' == $name && !$this->inAltTrans ) {
+            if ('target' == $name && !$this->inAltTrans) {
 
-                if ( isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
+                if (isset($this->transUnits[$this->currentTransUnitId])) {
 
                     // get translation of current segment, by indirect indexing: id -> positional index -> segment
                     // actually there may be more than one segment to that ID if there are two mrk of the same source segment
                     $tag = $this->rebuildTarget();
 
-                } elseif( !empty($this->CDATABuffer) and $this->currentTransUnitIsTranslatable === 'no' ) {
+                } elseif (!empty($this->CDATABuffer) and $this->currentTransUnitIsTranslatable === 'no') {
 
                     // These are target nodes with currentTransUnitIsTranslatable = 'NO'
                     $this->bufferIsActive = false;
@@ -133,45 +133,45 @@ 
                 $this->targetWasWritten = true;
                 // signal we are leaving a target
                 $this->inTarget = false;
-                $this->postProcAndFlush( $this->outputFP, $tag, true );
+                $this->postProcAndFlush($this->outputFP, $tag, true);
 
-            } elseif ( in_array( $name, $this->nodesToBuffer ) ) { // we are closing a critical CDATA section
+            } elseif (in_array($name, $this->nodesToBuffer)) { // we are closing a critical CDATA section
 
                 $this->bufferIsActive = false;
                 $tag                  = $this->CDATABuffer . "</$name>";
                 $this->CDATABuffer    = "";
 
                 //flush to the pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
-            } elseif ( $name === $this->tuTagName ) {
+            } elseif ($name === $this->tuTagName) {
 
                 $tag = "";
 
                 // handling </trans-unit> closure
-                if ( !$this->targetWasWritten ) {
+                if (!$this->targetWasWritten) {
 
-                    if ( isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
+                    if (isset($this->transUnits[$this->currentTransUnitId])) {
                         $tag = $this->rebuildTarget();
                     } else {
-                        $tag = $this->createTargetTag( "", "" );
+                        $tag = $this->createTargetTag("", "");
                     }
 
                 }
 
-                $tag                    .= "</$this->tuTagName>";
+                $tag .= "</$this->tuTagName>";
                 $this->targetWasWritten = false;
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
 
-            } elseif ( $this->bufferIsActive ) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
+            } elseif ($this->bufferIsActive) { // this is a tag ( <g | <mrk ) inside a seg or seg-source tag
                 $this->CDATABuffer .= "</$name>";
                 // Do NOT Flush
             } else { //generic tag closure do Nothing
                 // flush to pointer
-                $this->postProcAndFlush( $this->outputFP, $tag );
+                $this->postProcAndFlush($this->outputFP, $tag);
             }
 
-        } elseif ( in_array( $name, $this->nodesToBuffer ) ) {
+        } elseif (in_array($name, $this->nodesToBuffer)) {
 
             $this->isEmpty        = false;
             $this->bufferIsActive = false;
@@ -179,7 +179,7 @@ 
             $this->CDATABuffer    = "";
 
             //flush to the pointer
-            $this->postProcAndFlush( $this->outputFP, $tag );
+            $this->postProcAndFlush($this->outputFP, $tag);
 
         } else {
             //ok, nothing to be done; reset flag for next coming tag
@@ -187,10 +187,10 @@ 
         }
 
         // try to signal that we are leaving a target
-        $this->tryUnsetAltTrans( $name );
+        $this->tryUnsetAltTrans($name);
 
         // check if we are leaving a <trans-unit> (xliff v1.*) or <unit> (xliff v2.*)
-        if ( $this->tuTagName === $name ) {
+        if ($this->tuTagName === $name) {
             $this->currentTransUnitIsTranslatable = null;
             $this->inTU                           = false;
             $this->hasWrittenCounts               = false;
@@ -207,31 +207,31 @@ 
      *
      * @return string
      */
-    protected function prepareTranslation( array $seg, string $transUnitTranslation = "" ): string {
+    protected function prepareTranslation(array $seg, string $transUnitTranslation = ""): string {
 
-        $segment     = Strings::removeDangerousChars( $seg [ 'segment' ] );
-        $translation = Strings::removeDangerousChars( $seg [ 'translation' ] );
+        $segment     = Strings::removeDangerousChars($seg ['segment']);
+        $translation = Strings::removeDangerousChars($seg ['translation']);
 
-        if ( $seg [ 'translation' ] == '' ) {
+        if ($seg ['translation'] == '') {
             $translation = $segment;
         } else {
-            if ( $this->callback instanceof XliffReplacerCallbackInterface ) {
-                $error = ( !empty( $seg[ 'error' ] ) ) ? $seg[ 'error' ] : null;
-                if ( $this->callback->thereAreErrors( $seg[ 'sid' ], $segment, $translation, [], $error ) ) {
+            if ($this->callback instanceof XliffReplacerCallbackInterface) {
+                $error = (!empty($seg['error'])) ? $seg['error'] : null;
+                if ($this->callback->thereAreErrors($seg['sid'], $segment, $translation, [], $error)) {
                     $translation = '|||UNTRANSLATED_CONTENT_START|||' . $segment . '|||UNTRANSLATED_CONTENT_END|||';
                 }
             }
         }
 
-        $transUnitTranslation .= $seg[ 'prev_tags' ] . $this->rebuildMarks( $seg, $translation ) . ltrim( $seg[ 'succ_tags' ] );
+        $transUnitTranslation .= $seg['prev_tags'] . $this->rebuildMarks($seg, $translation) . ltrim($seg['succ_tags']);
 
         return $transUnitTranslation;
     }
 
-    protected function rebuildMarks( array $seg, string $translation ): string {
+    protected function rebuildMarks(array $seg, string $translation): string {
 
-        if ( $seg[ 'mrk_id' ] !== null && $seg[ 'mrk_id' ] != '' ) {
-            $translation = "<mrk mid=\"" . $seg[ 'mrk_id' ] . "\" mtype=\"seg\">" . $seg[ 'mrk_prev_tags' ] . $translation . $seg[ 'mrk_succ_tags' ] . "</mrk>";
+        if ($seg['mrk_id'] !== null && $seg['mrk_id'] != '') {
+            $translation = "<mrk mid=\"" . $seg['mrk_id'] . "\" mtype=\"seg\">" . $seg['mrk_prev_tags'] . $translation . $seg['mrk_succ_tags'] . "</mrk>";
         }
 
         return $translation;
@@ -246,10 +246,10 @@ 
      *
      * @return string
      */
-    protected function createTargetTag( string $translation, string $stateProp ): string {
+    protected function createTargetTag(string $translation, string $stateProp): string {
         $targetLang = ' xml:lang="' . $this->targetLang . '"';
         $tag        = "<target $targetLang $stateProp>$translation</target>";
-        $tag        .= "\n<count-group name=\"$this->currentTransUnitId\"><count count-type=\"x-matecat-raw\">" . $this->counts[ 'raw_word_count' ] . "</count><count count-type=\"x-matecat-weighted\">" . $this->counts[ 'eq_word_count' ] . '</count></count-group>';
+        $tag .= "\n<count-group name=\"$this->currentTransUnitId\"><count count-type=\"x-matecat-raw\">" . $this->counts['raw_word_count'] . "</count><count count-type=\"x-matecat-weighted\">" . $this->counts['eq_word_count'] . '</count></count-group>';
 
         return $tag;
 
@@ -265,7 +265,7 @@ 
         // we must reset the lastMrkId found because this is a new segment.
         $lastMrkId = -1;
 
-        foreach ( $this->lastTransUnit as $pos => $seg ) {
+        foreach ($this->lastTransUnit as $pos => $seg) {
 
             /*
              * This routine works to respect the positional orders of markers.
@@ -278,8 +278,8 @@ 
              * pre-assign zero to the new mrk if this is the first one ( in this segment )
              * If it is null leave it NULL
              */
-            if ( (int)$seg[ "mrk_id" ] < 0 && $seg[ "mrk_id" ] !== null ) {
-                $seg[ "mrk_id" ] = 0;
+            if ((int)$seg["mrk_id"] < 0 && $seg["mrk_id"] !== null) {
+                $seg["mrk_id"] = 0;
             }
 
             /*
@@ -288,39 +288,39 @@ 
              * ( null <= -1 ) === true
              * so, cast to int
              */
-            if ( (int)$seg[ "mrk_id" ] <= $lastMrkId ) {
+            if ((int)$seg["mrk_id"] <= $lastMrkId) {
                 break;
             }
 
             // update counts
-            if ( !empty( $seg ) ) {
-                $this->updateSegmentCounts( $seg );
+            if (!empty($seg)) {
+                $this->updateSegmentCounts($seg);
             }
 
             // delete translations so the prepareSegment
             // will put source content in target tag
-            if ( $this->sourceInTarget ) {
-                $seg[ 'translation' ] = '';
+            if ($this->sourceInTarget) {
+                $seg['translation'] = '';
                 $this->resetCounts();
             }
 
             // append $translation
-            $translation = $this->prepareTranslation( $seg, $translation );
+            $translation = $this->prepareTranslation($seg, $translation);
 
-            $lastMrkId = $seg[ "mrk_id" ];
+            $lastMrkId = $seg["mrk_id"];
 
-            [ $stateProp, $lastMrkState ] = StatusToStateAttribute::getState( $this->xliffVersion, $seg[ 'status' ], $lastMrkState );
+            [$stateProp, $lastMrkState] = StatusToStateAttribute::getState($this->xliffVersion, $seg['status'], $lastMrkState);
 
         }
 
         //append translation
-        return $this->createTargetTag( $translation, $stateProp );
+        return $this->createTargetTag($translation, $stateProp);
 
     }
 
     protected function getCurrentSegment(): array {
-        if ( $this->currentTransUnitIsTranslatable !== 'no' && isset( $this->transUnits[ $this->currentTransUnitId ] ) ) {
-            return $this->segments[ $this->transUnits[ $this->currentTransUnitId ][ 0 ] ]; // TODO try to understand why here is needed to override the method and set 0 index hardcoded
+        if ($this->currentTransUnitIsTranslatable !== 'no' && isset($this->transUnits[$this->currentTransUnitId])) {
+            return $this->segments[$this->transUnits[$this->currentTransUnitId][0]]; // TODO try to understand why here is needed to override the method and set 0 index hardcoded
         }
 
         return [];

src/XliffParser/XliffParserV1.php

Spacing +95 added lines, -95 removed lines

@@ -16,33 +16,33 @@ 
      * @inheritDoc
      * @throws Exception
      */
-    public function parse( DOMDocument $dom, ?array $output = [] ): array {
+    public function parse(DOMDocument $dom, ?array $output = []): array {
         $i = 1;
         /** @var DOMElement $file */
-        foreach ( $dom->getElementsByTagName( 'file' ) as $file ) {
+        foreach ($dom->getElementsByTagName('file') as $file) {
 
             // metadata
-            $output[ 'files' ][ $i ][ 'attr' ] = $this->extractMetadata( $file );
+            $output['files'][$i]['attr'] = $this->extractMetadata($file);
 
             // reference
-            if ( !empty( $this->extractReference( $file ) ) ) {
-                $output[ 'files' ][ $i ][ 'reference' ] = $this->extractReference( $file );
+            if (!empty($this->extractReference($file))) {
+                $output['files'][$i]['reference'] = $this->extractReference($file);
             }
 
             // trans-units
             $transUnitIdArrayForUniquenessCheck = [];
             $j                                  = 1;
-            foreach ( $file->childNodes as $body ) {
-                if ( $body->nodeName === 'body' ) {
-                    foreach ( $body->childNodes as $childNode ) {
-                        $this->extractTuFromNode( $childNode, $transUnitIdArrayForUniquenessCheck, $dom, $output, $i, $j );
+            foreach ($file->childNodes as $body) {
+                if ($body->nodeName === 'body') {
+                    foreach ($body->childNodes as $childNode) {
+                        $this->extractTuFromNode($childNode, $transUnitIdArrayForUniquenessCheck, $dom, $output, $i, $j);
                     }
 
                     // trans-unit re-count check
-                    $totalTransUnitsId  = count( $transUnitIdArrayForUniquenessCheck );
-                    $transUnitsUniqueId = count( array_unique( $transUnitIdArrayForUniquenessCheck ) );
-                    if ( $totalTransUnitsId != $transUnitsUniqueId ) {
-                        throw new DuplicateTransUnitIdInXliff( "Invalid trans-unit id, duplicate found.", 400 );
+                    $totalTransUnitsId  = count($transUnitIdArrayForUniquenessCheck);
+                    $transUnitsUniqueId = count(array_unique($transUnitIdArrayForUniquenessCheck));
+                    if ($totalTransUnitsId != $transUnitsUniqueId) {
+                        throw new DuplicateTransUnitIdInXliff("Invalid trans-unit id, duplicate found.", 400);
                     }
 
                     $i++;
@@ -58,50 +58,50 @@ 
      *
      * @return array
      */
-    private function extractMetadata( DOMElement $file ): array {
+    private function extractMetadata(DOMElement $file): array {
         $metadata   = [];
         $customAttr = [];
 
         /** @var DOMAttr $attribute */
-        foreach ( $file->attributes as $attribute ) {
-            switch ( $attribute->localName ) {
+        foreach ($file->attributes as $attribute) {
+            switch ($attribute->localName) {
                 // original
                 case 'original':
-                    $metadata[ 'original' ] = $attribute->value;
+                    $metadata['original'] = $attribute->value;
                     break;
 
                 // source-language
                 case 'source-language':
-                    $metadata[ 'source-language' ] = $attribute->value;
+                    $metadata['source-language'] = $attribute->value;
                     break;
 
                 // data-type
                 case 'datatype':
-                    $metadata[ 'data-type' ] = $attribute->value;
+                    $metadata['data-type'] = $attribute->value;
                     break;
 
                 // target-language
                 case 'target-language':
-                    $metadata[ 'target-language' ] = $attribute->value;
+                    $metadata['target-language'] = $attribute->value;
                     break;
             }
 
             // Custom MateCat x-Attribute
-            preg_match( '|x-(.*?)|si', $attribute->localName, $temp );
-            if ( isset( $temp[ 1 ] ) ) {
-                $customAttr[ $attribute->localName ] = $attribute->value;
+            preg_match('|x-(.*?)|si', $attribute->localName, $temp);
+            if (isset($temp[1])) {
+                $customAttr[$attribute->localName] = $attribute->value;
             }
-            unset( $temp );
+            unset($temp);
 
             // Custom MateCat namespace Attribute mtc:
-            preg_match( '|mtc:(.*?)|si', $attribute->nodeName, $temp );
-            if ( isset( $temp[ 1 ] ) ) {
-                $customAttr[ $attribute->nodeName ] = $attribute->value;
+            preg_match('|mtc:(.*?)|si', $attribute->nodeName, $temp);
+            if (isset($temp[1])) {
+                $customAttr[$attribute->nodeName] = $attribute->value;
             }
-            unset( $temp );
+            unset($temp);
 
-            if ( !empty( $customAttr ) ) {
-                $metadata[ 'custom' ] = $customAttr;
+            if (!empty($customAttr)) {
+                $metadata['custom'] = $customAttr;
             }
         }
 
@@ -113,16 +113,16 @@ 
      *
      * @return array
      */
-    private function extractReference( DOMElement $file ): array {
+    private function extractReference(DOMElement $file): array {
         $reference = [];
 
         $order = 0;
-        foreach ( $file->getElementsByTagName( 'reference' ) as $ref ) {
+        foreach ($file->getElementsByTagName('reference') as $ref) {
             /** @var DOMNode $childNode */
-            foreach ( $ref->childNodes as $childNode ) {
-                if ( $childNode->nodeName === 'internal-file' ) {
-                    $reference[ $order ][ 'form-type' ] = $childNode->attributes->getNamedItem( 'form' )->nodeValue;
-                    $reference[ $order ][ 'base64' ]    = trim( $childNode->nodeValue );
+            foreach ($ref->childNodes as $childNode) {
+                if ($childNode->nodeName === 'internal-file') {
+                    $reference[$order]['form-type'] = $childNode->attributes->getNamedItem('form')->nodeValue;
+                    $reference[$order]['base64']    = trim($childNode->nodeValue);
                     $order++;
                 }
             }
@@ -144,61 +144,61 @@ 
      *
      * @throws Exception
      */
-    protected function extractTransUnit( DOMElement $transUnit, array &$transUnitIdArrayForUniquenessCheck, DomDocument $dom, array &$output, int &$i, int &$j, ?array $contextGroups = [] ) {
+    protected function extractTransUnit(DOMElement $transUnit, array &$transUnitIdArrayForUniquenessCheck, DomDocument $dom, array &$output, int &$i, int &$j, ?array $contextGroups = []) {
         // metadata
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'attr' ] = $this->extractTransUnitMetadata( $transUnit, $transUnitIdArrayForUniquenessCheck );
+        $output['files'][$i]['trans-units'][$j]['attr'] = $this->extractTransUnitMetadata($transUnit, $transUnitIdArrayForUniquenessCheck);
 
         // notes
-        $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'notes' ] = $this->extractTransUnitNotes( $dom, $transUnit );
+        $output['files'][$i]['trans-units'][$j]['notes'] = $this->extractTransUnitNotes($dom, $transUnit);
 
         // content
         /** @var DOMElement $childNode */
-        foreach ( $transUnit->childNodes as $childNode ) {
+        foreach ($transUnit->childNodes as $childNode) {
             // source
-            if ( $childNode->nodeName === 'source' ) {
-                $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'source' ] = $this->extractContent( $dom, $childNode );
+            if ($childNode->nodeName === 'source') {
+                $output['files'][$i]['trans-units'][$j]['source'] = $this->extractContent($dom, $childNode);
             }
 
             // seg-source
-            if ( $childNode->nodeName === 'seg-source' ) {
-                $rawSegment                                                     = $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'source' ][ 'raw-content' ];
-                $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'seg-source' ] = $this->extractContentWithMarksAndExtTags( $dom, $childNode, $rawSegment );
+            if ($childNode->nodeName === 'seg-source') {
+                $rawSegment                                                     = $output['files'][$i]['trans-units'][$j]['source']['raw-content'];
+                $output['files'][$i]['trans-units'][$j]['seg-source'] = $this->extractContentWithMarksAndExtTags($dom, $childNode, $rawSegment);
             }
 
             // target
-            if ( $childNode->nodeName === 'target' ) {
-                $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'target' ] = $this->extractContent( $dom, $childNode );
+            if ($childNode->nodeName === 'target') {
+                $output['files'][$i]['trans-units'][$j]['target'] = $this->extractContent($dom, $childNode);
 
                 // seg-target
-                $targetRawContent = $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'target' ][ 'raw-content' ] ?? null;
-                $segSource        = $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'seg-source' ] ?? null;
+                $targetRawContent = $output['files'][$i]['trans-units'][$j]['target']['raw-content'] ?? null;
+                $segSource        = $output['files'][$i]['trans-units'][$j]['seg-source'] ?? null;
 
-                if ( !empty( $targetRawContent ) and isset( $segSource ) and count( $segSource ) > 0 ) {
-                    $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'seg-target' ]                = $this->extractContentWithMarksAndExtTags( $dom, $childNode );
-                    $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'seg-target' ][ 0 ][ 'attr' ] = $this->extractTagAttributes( $childNode );
+                if (!empty($targetRawContent) and isset($segSource) and count($segSource) > 0) {
+                    $output['files'][$i]['trans-units'][$j]['seg-target']                = $this->extractContentWithMarksAndExtTags($dom, $childNode);
+                    $output['files'][$i]['trans-units'][$j]['seg-target'][0]['attr'] = $this->extractTagAttributes($childNode);
                 }
             }
 
             // locked
-            if ( $childNode->nodeName === 'sdl:seg' ) {
-                $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'locked' ] = $this->extractLocked( $childNode );
+            if ($childNode->nodeName === 'sdl:seg') {
+                $output['files'][$i]['trans-units'][$j]['locked'] = $this->extractLocked($childNode);
             }
         }
 
         // context-group
-        if ( !empty( $contextGroups ) ) {
-            foreach ( $contextGroups as $contextGroup ) {
-                $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'context-group' ][] = $this->extractTransUnitContextGroup( $dom, $contextGroup );
+        if (!empty($contextGroups)) {
+            foreach ($contextGroups as $contextGroup) {
+                $output['files'][$i]['trans-units'][$j]['context-group'][] = $this->extractTransUnitContextGroup($dom, $contextGroup);
             }
         }
 
-        foreach ( $transUnit->getElementsByTagName( 'context-group' ) as $contextGroup ) {
-            $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'context-group' ][] = $this->extractTransUnitContextGroup( $dom, $contextGroup );
+        foreach ($transUnit->getElementsByTagName('context-group') as $contextGroup) {
+            $output['files'][$i]['trans-units'][$j]['context-group'][] = $this->extractTransUnitContextGroup($dom, $contextGroup);
         }
 
         // alt-trans
-        foreach ( $transUnit->getElementsByTagName( 'alt-trans' ) as $altTrans ) {
-            $output[ 'files' ][ $i ][ 'trans-units' ][ $j ][ 'alt-trans' ][] = $this->extractTransUnitAltTrans( $altTrans );
+        foreach ($transUnit->getElementsByTagName('alt-trans') as $altTrans) {
+            $output['files'][$i]['trans-units'][$j]['alt-trans'][] = $this->extractTransUnitAltTrans($altTrans);
         }
 
         $j++;
@@ -211,41 +211,41 @@ 
      * @return array
      * @throws Exception
      */
-    private function extractTransUnitMetadata( DOMElement $transUnit, array &$transUnitIdArrayForUniquenessCheck ): array {
+    private function extractTransUnitMetadata(DOMElement $transUnit, array &$transUnitIdArrayForUniquenessCheck): array {
         $metadata = [];
 
         // id MUST NOT be null
-        if ( null === $transUnit->attributes->getNamedItem( 'id' ) ) {
-            throw new NotFoundIdInTransUnit( 'Invalid trans-unit id found. EMPTY value', 400 );
+        if (null === $transUnit->attributes->getNamedItem('id')) {
+            throw new NotFoundIdInTransUnit('Invalid trans-unit id found. EMPTY value', 400);
         }
 
         /**
          * @var DOMAttr $element
          */
-        foreach ( $transUnit->attributes as $element ) {
+        foreach ($transUnit->attributes as $element) {
 
-            if ( $element->nodeName === "id" ) {
+            if ($element->nodeName === "id") {
 
                 $id = $element->nodeValue;
 
-                if ( strlen( $id ) > 100 ) {
-                    throw new SegmentIdTooLongException( 'Segment-id too long. Max 100 characters allowed', 400 );
+                if (strlen($id) > 100) {
+                    throw new SegmentIdTooLongException('Segment-id too long. Max 100 characters allowed', 400);
                 }
 
                 $transUnitIdArrayForUniquenessCheck[] = $id;
-                $metadata[ 'id' ]                     = $id;
+                $metadata['id']                     = $id;
 
-            } elseif ( $element->nodeName === "approved" ) {
+            } elseif ($element->nodeName === "approved") {
                 // approved as BOOLEAN
                 // http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#approved
-                $metadata[ $element->nodeName ] = filter_var( $element->nodeValue, FILTER_VALIDATE_BOOLEAN );
-            } elseif ( $element->nodeName === "maxwidth" ) {
+                $metadata[$element->nodeName] = filter_var($element->nodeValue, FILTER_VALIDATE_BOOLEAN);
+            } elseif ($element->nodeName === "maxwidth") {
                 // we ignore ( but we get ) the attribute size-unit="char" assuming that a restriction is everytime done by character
                 // we duplicate the info to allow Xliff V1 and V2 to work the same
-                $metadata[ 'sizeRestriction' ]  = filter_var( $element->nodeValue, FILTER_SANITIZE_NUMBER_INT );
-                $metadata[ $element->nodeName ] = filter_var( $element->nodeValue, FILTER_SANITIZE_NUMBER_INT );
+                $metadata['sizeRestriction']  = filter_var($element->nodeValue, FILTER_SANITIZE_NUMBER_INT);
+                $metadata[$element->nodeName] = filter_var($element->nodeValue, FILTER_SANITIZE_NUMBER_INT);
             } else {
-                $metadata[ $element->nodeName ] = $element->nodeValue;
+                $metadata[$element->nodeName] = $element->nodeValue;
             }
 
         }
@@ -260,19 +260,19 @@ 
      * @return array
      * @throws Exception
      */
-    private function extractTransUnitNotes( DOMDocument $dom, DOMElement $transUnit ): array {
+    private function extractTransUnitNotes(DOMDocument $dom, DOMElement $transUnit): array {
         $notes = [];
-        foreach ( $transUnit->getElementsByTagName( 'note' ) as $note ) {
+        foreach ($transUnit->getElementsByTagName('note') as $note) {
 
-            $noteValue = $this->extractTagContent( $dom, $note );
+            $noteValue = $this->extractTagContent($dom, $note);
 
-            if ( '' !== $noteValue ) {
+            if ('' !== $noteValue) {
 
-                $extractedNote = $this->JSONOrRawContentArray( $noteValue );
+                $extractedNote = $this->JSONOrRawContentArray($noteValue);
 
                 // extract all the attributes
-                foreach ( $note->attributes as $attribute ) {
-                    $extractedNote[ $attribute->name ] = $attribute->value;
+                foreach ($note->attributes as $attribute) {
+                    $extractedNote[$attribute->name] = $attribute->value;
                 }
 
                 $notes[] = $extractedNote;
@@ -288,14 +288,14 @@ 
      *
      * @return array
      */
-    private function extractTransUnitContextGroup( DOMDocument $dom, DOMElement $contextGroup ): array {
+    private function extractTransUnitContextGroup(DOMDocument $dom, DOMElement $contextGroup): array {
         $cg           = [];
-        $cg[ 'attr' ] = $this->extractTagAttributes( $contextGroup );
+        $cg['attr'] = $this->extractTagAttributes($contextGroup);
 
         /** @var DOMNode $context */
-        foreach ( $contextGroup->childNodes as $context ) {
-            if ( $context->nodeName === 'context' ) {
-                $cg[ 'contexts' ][] = $this->extractContent( $dom, $context );
+        foreach ($contextGroup->childNodes as $context) {
+            if ($context->nodeName === 'context') {
+                $cg['contexts'][] = $this->extractContent($dom, $context);
             }
         }
 
@@ -307,16 +307,16 @@ 
      *
      * @return array
      */
-    private function extractTransUnitAltTrans( DOMElement $altTrans ) {
+    private function extractTransUnitAltTrans(DOMElement $altTrans) {
         $at           = [];
-        $at[ 'attr' ] = $this->extractTagAttributes( $altTrans );
+        $at['attr'] = $this->extractTagAttributes($altTrans);
 
-        if ( $altTrans->getElementsByTagName( 'source' )->length > 0 ) {
-            $at[ 'source' ] = $altTrans->getElementsByTagName( 'source' )->item( 0 )->nodeValue;
+        if ($altTrans->getElementsByTagName('source')->length > 0) {
+            $at['source'] = $altTrans->getElementsByTagName('source')->item(0)->nodeValue;
         }
 
-        if ( $altTrans->getElementsByTagName( 'target' ) ) {
-            $at[ 'target' ] = $altTrans->getElementsByTagName( 'target' )->item( 0 )->nodeValue;
+        if ($altTrans->getElementsByTagName('target')) {
+            $at['target'] = $altTrans->getElementsByTagName('target')->item(0)->nodeValue;
         }
 
         return $at;
@@ -327,7 +327,7 @@ 
      *
      * @return bool
      */
-    private function extractLocked( DOMElement $locked ) {
-        return null !== $locked->getAttribute( 'locked' );
+    private function extractLocked(DOMElement $locked) {
+        return null !== $locked->getAttribute('locked');
     }
 }