Passed
Pull Request — master (#90)
by Domenico
03:23
created
src/XliffUtils/CheckPipeline/CheckGlobalSight.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -8,15 +8,15 @@
 block discarded – undo
8 8
      *
9 9
      * @return array|null
10 10
      */
11
-    public function check( ?array $tmp = [] ): ?array {
11
+    public function check(?array $tmp = []): ?array {
12 12
         $fileType = [];
13 13
 
14
-        if ( isset( $tmp[ 0 ] ) ) {
15
-            if ( stripos( $tmp[ 0 ], 'globalsight' ) !== false ) {
16
-                $fileType[ 'proprietary' ]            = true;
17
-                $fileType[ 'proprietary_name' ]       = 'GlobalSight Download File';
18
-                $fileType[ 'proprietary_short_name' ] = 'globalsight';
19
-                $fileType[ 'converter_version' ]      = 'legacy';
14
+        if (isset($tmp[0])) {
15
+            if (stripos($tmp[0], 'globalsight') !== false) {
16
+                $fileType['proprietary']            = true;
17
+                $fileType['proprietary_name']       = 'GlobalSight Download File';
18
+                $fileType['proprietary_short_name'] = 'globalsight';
19
+                $fileType['converter_version']      = 'legacy';
20 20
 
21 21
                 return $fileType;
22 22
             }
Please login to merge, or discard this patch.
src/XliffUtils/CheckPipeline/CheckMateCATConverter.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -8,20 +8,20 @@
 block discarded – undo
8 8
      *
9 9
      * @return array|null
10 10
      */
11
-    public function check( ?array $tmp = [] ): ?array {
11
+    public function check(?array $tmp = []): ?array {
12 12
         $fileType = [];
13 13
 
14
-        if ( isset( $tmp[ 0 ] ) ) {
15
-            preg_match( '#tool-id\s*=\s*"matecat-converter(\s+([^"]+))?"#i', $tmp[ 0 ], $matches );
16
-            if ( !empty( $matches ) ) {
17
-                $fileType[ 'proprietary' ]            = false;
18
-                $fileType[ 'proprietary_name' ]       = 'MateCAT Converter';
19
-                $fileType[ 'proprietary_short_name' ] = 'matecat_converter';
20
-                if ( isset( $matches[ 2 ] ) ) {
21
-                    $fileType[ 'converter_version' ] = $matches[ 2 ];
14
+        if (isset($tmp[0])) {
15
+            preg_match('#tool-id\s*=\s*"matecat-converter(\s+([^"]+))?"#i', $tmp[0], $matches);
16
+            if (!empty($matches)) {
17
+                $fileType['proprietary']            = false;
18
+                $fileType['proprietary_name']       = 'MateCAT Converter';
19
+                $fileType['proprietary_short_name'] = 'matecat_converter';
20
+                if (isset($matches[2])) {
21
+                    $fileType['converter_version'] = $matches[2];
22 22
                 } else {
23 23
                     // First converter release didn't specify version
24
-                    $fileType[ 'converter_version' ] = '1.0';
24
+                    $fileType['converter_version'] = '1.0';
25 25
                 }
26 26
 
27 27
                 return $fileType;
Please login to merge, or discard this patch.
src/XliffUtils/CheckPipeline/CheckXliffVersion2.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -8,22 +8,22 @@
 block discarded – undo
8 8
      *
9 9
      * @return array|null
10 10
      */
11
-    public function check( ?array $tmp = [] ): ?array {
11
+    public function check(?array $tmp = []): ?array {
12 12
         $fileType = [];
13 13
 
14
-        if ( isset( $tmp[ 0 ] ) ) {
15
-            preg_match( '|<xliff.*?\sversion\s?=\s?["\'](.*?)["\']|si', substr( $tmp[ 0 ], 0, 1000 ), $versionMatches );
16
-            preg_match( '|<xliff.*?\sxmlns\s?=\s?["\']urn:oasis:names:tc:xliff:document:(.*?)["\']|si', substr( $tmp[ 0 ], 0, 1000 ), $xmlnsMatches );
14
+        if (isset($tmp[0])) {
15
+            preg_match('|<xliff.*?\sversion\s?=\s?["\'](.*?)["\']|si', substr($tmp[0], 0, 1000), $versionMatches);
16
+            preg_match('|<xliff.*?\sxmlns\s?=\s?["\']urn:oasis:names:tc:xliff:document:(.*?)["\']|si', substr($tmp[0], 0, 1000), $xmlnsMatches);
17 17
 
18
-            if ( !empty( $versionMatches ) && !empty( $xmlnsMatches ) ) {
19
-                $version = $versionMatches[ 1 ];
20
-                $xmlns   = $xmlnsMatches[ 1 ];
18
+            if (!empty($versionMatches) && !empty($xmlnsMatches)) {
19
+                $version = $versionMatches[1];
20
+                $xmlns   = $xmlnsMatches[1];
21 21
 
22
-                if ( $version === $xmlns && $version >= 2 ) {
23
-                    $fileType[ 'proprietary' ]            = false;
24
-                    $fileType[ 'proprietary_name' ]       = 'Xliff v' . $version . ' File';
25
-                    $fileType[ 'proprietary_short_name' ] = 'xliff_v2';
26
-                    $fileType[ 'converter_version' ]      = '2.0';
22
+                if ($version === $xmlns && $version >= 2) {
23
+                    $fileType['proprietary']            = false;
24
+                    $fileType['proprietary_name']       = 'Xliff v' . $version . ' File';
25
+                    $fileType['proprietary_short_name'] = 'xliff_v2';
26
+                    $fileType['converter_version']      = '2.0';
27 27
 
28 28
                     return $fileType;
29 29
                 }
Please login to merge, or discard this patch.
src/XliffUtils/CheckPipeline/CheckInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,5 +8,5 @@
 block discarded – undo
8 8
      *
9 9
      * @return array|null
10 10
      */
11
-    public function check( ?array $tmp = [] ): ?array;
11
+    public function check(?array $tmp = []): ?array;
12 12
 }
Please login to merge, or discard this patch.
src/XliffUtils/XliffVersionDetector.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -9,12 +9,12 @@  discard block
 block discarded – undo
9 9
     /**
10 10
      * @var array
11 11
      */
12
-    private static array $versions_1 = [ '1.0', '1.1', '1.2' ];
12
+    private static array $versions_1 = ['1.0', '1.1', '1.2'];
13 13
 
14 14
     /**
15 15
      * @var array
16 16
      */
17
-    private static array $versions_2 = [ '2.0', '2.1' ];
17
+    private static array $versions_2 = ['2.0', '2.1'];
18 18
 
19 19
     /**
20 20
      * @param string $xliffContent
@@ -23,16 +23,16 @@  discard block
 block discarded – undo
23 23
      * @throws NotSupportedVersionException
24 24
      * @throws NotValidFileException
25 25
      */
26
-    public static function detect( string $xliffContent ): int {
27
-        preg_match( '|<xliff.*?\sversion\s?=\s?["\'](.*?)["\']|si', substr( $xliffContent, 0, 1000 ), $versionMatches );
26
+    public static function detect(string $xliffContent): int {
27
+        preg_match('|<xliff.*?\sversion\s?=\s?["\'](.*?)["\']|si', substr($xliffContent, 0, 1000), $versionMatches);
28 28
 
29
-        if ( empty( $versionMatches ) ) {
30
-            throw new NotValidFileException( 'This is not a valid xliff file' );
29
+        if (empty($versionMatches)) {
30
+            throw new NotValidFileException('This is not a valid xliff file');
31 31
         }
32 32
 
33
-        $version = $versionMatches[ 1 ];
33
+        $version = $versionMatches[1];
34 34
 
35
-        return self::resolveVersion( $version );
35
+        return self::resolveVersion($version);
36 36
     }
37 37
 
38 38
     /**
@@ -41,15 +41,15 @@  discard block
 block discarded – undo
41 41
      * @return int
42 42
      * @throws NotSupportedVersionException
43 43
      */
44
-    private static function resolveVersion( string $version ): int {
45
-        if ( in_array( $version, self::$versions_1 ) ) {
44
+    private static function resolveVersion(string $version): int {
45
+        if (in_array($version, self::$versions_1)) {
46 46
             return 1;
47 47
         }
48 48
 
49
-        if ( in_array( $version, self::$versions_2 ) ) {
49
+        if (in_array($version, self::$versions_2)) {
50 50
             return 2;
51 51
         }
52 52
 
53
-        throw new NotSupportedVersionException( 'Not supported version' );
53
+        throw new NotSupportedVersionException('Not supported version');
54 54
     }
55 55
 }
Please login to merge, or discard this patch.
src/XliffUtils/XliffProprietaryDetect.php 1 patch
Spacing   +58 added lines, -58 removed lines patch added patch discarded remove patch
@@ -22,11 +22,11 @@  discard block
 block discarded – undo
22 22
      *
23 23
      * @return array
24 24
      */
25
-    public static function getInfoFromXliffContent( string $xliffContent ): array {
25
+    public static function getInfoFromXliffContent(string $xliffContent): array {
26 26
         self::reset();
27
-        $tmp = self::getFirst1024CharsFromXliff( $xliffContent, null );
27
+        $tmp = self::getFirst1024CharsFromXliff($xliffContent, null);
28 28
 
29
-        return self::getInfoFromTmp( $tmp );
29
+        return self::getInfoFromTmp($tmp);
30 30
     }
31 31
 
32 32
     /**
@@ -34,12 +34,12 @@  discard block
 block discarded – undo
34 34
      *
35 35
      * @return array
36 36
      */
37
-    public static function getInfo( string $fullPathToFile ): array {
37
+    public static function getInfo(string $fullPathToFile): array {
38 38
         self::reset();
39
-        $tmp                      = self::getFirst1024CharsFromXliff( null, $fullPathToFile );
40
-        self::$fileType[ 'info' ] = Files::pathInfo( $fullPathToFile );
39
+        $tmp                      = self::getFirst1024CharsFromXliff(null, $fullPathToFile);
40
+        self::$fileType['info'] = Files::pathInfo($fullPathToFile);
41 41
 
42
-        return self::getInfoFromTmp( $tmp );
42
+        return self::getInfoFromTmp($tmp);
43 43
     }
44 44
 
45 45
     /**
@@ -47,21 +47,21 @@  discard block
 block discarded – undo
47 47
      *
48 48
      * @return array
49 49
      */
50
-    private static function getInfoFromTmp( ?array $tmp = [] ): array {
50
+    private static function getInfoFromTmp(?array $tmp = []): array {
51 51
         try {
52
-            self::checkVersion( $tmp );
53
-        } catch ( Exception $ignore ) {
52
+            self::checkVersion($tmp);
53
+        } catch (Exception $ignore) {
54 54
             // do nothing
55 55
             // self::$fileType[ 'version' ] is left empty
56 56
         }
57 57
 
58 58
         // run CheckXliffProprietaryPipeline
59
-        $pipeline = self::runPipeline( $tmp );
59
+        $pipeline = self::runPipeline($tmp);
60 60
 
61
-        self::$fileType[ 'proprietary' ]            = $pipeline[ 'proprietary' ];
62
-        self::$fileType[ 'proprietary_name' ]       = $pipeline[ 'proprietary_name' ];
63
-        self::$fileType[ 'proprietary_short_name' ] = $pipeline[ 'proprietary_short_name' ];
64
-        self::$fileType[ 'converter_version' ]      = $pipeline[ 'converter_version' ];
61
+        self::$fileType['proprietary']            = $pipeline['proprietary'];
62
+        self::$fileType['proprietary_name']       = $pipeline['proprietary_name'];
63
+        self::$fileType['proprietary_short_name'] = $pipeline['proprietary_short_name'];
64
+        self::$fileType['converter_version']      = $pipeline['converter_version'];
65 65
 
66 66
         return self::$fileType;
67 67
     }
@@ -71,12 +71,12 @@  discard block
 block discarded – undo
71 71
      *
72 72
      * @return array
73 73
      */
74
-    private static function runPipeline( ?array $tmp = [] ): array {
75
-        $pipeline = new CheckXliffProprietaryPipeline( $tmp );
76
-        $pipeline->addCheck( new CheckSDL() );
77
-        $pipeline->addCheck( new CheckGlobalSight() );
78
-        $pipeline->addCheck( new CheckMateCATConverter() );
79
-        $pipeline->addCheck( new CheckXliffVersion2() );
74
+    private static function runPipeline(?array $tmp = []): array {
75
+        $pipeline = new CheckXliffProprietaryPipeline($tmp);
76
+        $pipeline->addCheck(new CheckSDL());
77
+        $pipeline->addCheck(new CheckGlobalSight());
78
+        $pipeline->addCheck(new CheckMateCATConverter());
79
+        $pipeline->addCheck(new CheckXliffVersion2());
80 80
 
81 81
         return $pipeline->run();
82 82
     }
@@ -99,29 +99,29 @@  discard block
 block discarded – undo
99 99
      *
100 100
      * @return ?array
101 101
      */
102
-    private static function getFirst1024CharsFromXliff( ?string $stringData = null, string $fullPathToFile = null ): ?array {
103
-        if ( !empty( $stringData ) && empty( $fullPathToFile ) ) {
102
+    private static function getFirst1024CharsFromXliff(?string $stringData = null, string $fullPathToFile = null): ?array {
103
+        if (!empty($stringData) && empty($fullPathToFile)) {
104 104
             $pathInfo   = [];
105
-            $stringData = substr( $stringData, 0, 1024 );
106
-        } elseif ( empty( $stringData ) && !empty( $fullPathToFile ) ) {
107
-            $pathInfo = Files::pathInfo( $fullPathToFile );
105
+            $stringData = substr($stringData, 0, 1024);
106
+        } elseif (empty($stringData) && !empty($fullPathToFile)) {
107
+            $pathInfo = Files::pathInfo($fullPathToFile);
108 108
 
109
-            if ( is_file( $fullPathToFile ) ) {
110
-                $file_pointer = fopen( "$fullPathToFile", 'r' );
109
+            if (is_file($fullPathToFile)) {
110
+                $file_pointer = fopen("$fullPathToFile", 'r');
111 111
                 // Checking Requirements (By specs, I know that xliff version is in the first 1KB)
112
-                $stringData = fread( $file_pointer, 1024 );
113
-                fclose( $file_pointer );
112
+                $stringData = fread($file_pointer, 1024);
113
+                fclose($file_pointer);
114 114
             }
115
-        } elseif ( !empty( $stringData ) && !empty( $fullPathToFile ) ) {
116
-            $pathInfo = Files::pathInfo( $fullPathToFile );
115
+        } elseif (!empty($stringData) && !empty($fullPathToFile)) {
116
+            $pathInfo = Files::pathInfo($fullPathToFile);
117 117
         }
118 118
 
119
-        if ( !empty( $pathInfo ) && !Files::isXliff( $fullPathToFile ) ) {
119
+        if (!empty($pathInfo) && !Files::isXliff($fullPathToFile)) {
120 120
             return null;
121 121
         }
122 122
 
123
-        if ( !empty( $stringData ) ) {
124
-            return [ $stringData ];
123
+        if (!empty($stringData)) {
124
+            return [$stringData];
125 125
         }
126 126
 
127 127
         return null;
@@ -133,9 +133,9 @@  discard block
 block discarded – undo
133 133
      * @throws NotSupportedVersionException
134 134
      * @throws NotValidFileException
135 135
      */
136
-    protected static function checkVersion( $tmp ) {
137
-        if ( isset( $tmp[ 0 ] ) ) {
138
-            self::$fileType[ 'version' ] = XliffVersionDetector::detect( $tmp[ 0 ] );
136
+    protected static function checkVersion($tmp) {
137
+        if (isset($tmp[0])) {
138
+            self::$fileType['version'] = XliffVersionDetector::detect($tmp[0]);
139 139
         }
140 140
     }
141 141
 
@@ -146,20 +146,20 @@  discard block
 block discarded – undo
146 146
      * @throws NotSupportedVersionException
147 147
      * @throws NotValidFileException
148 148
      */
149
-    public static function getInfoByStringData( string $stringData ): array {
149
+    public static function getInfoByStringData(string $stringData): array {
150 150
         self::reset();
151 151
 
152
-        $tmp                      = self::getFirst1024CharsFromXliff( $stringData );
153
-        self::$fileType[ 'info' ] = [];
154
-        self::checkVersion( $tmp );
152
+        $tmp                      = self::getFirst1024CharsFromXliff($stringData);
153
+        self::$fileType['info'] = [];
154
+        self::checkVersion($tmp);
155 155
 
156 156
         // run CheckXliffProprietaryPipeline
157
-        $pipeline = self::runPipeline( $tmp );
157
+        $pipeline = self::runPipeline($tmp);
158 158
 
159
-        self::$fileType[ 'proprietary' ]            = $pipeline[ 'proprietary' ];
160
-        self::$fileType[ 'proprietary_name' ]       = $pipeline[ 'proprietary_name' ];
161
-        self::$fileType[ 'proprietary_short_name' ] = $pipeline[ 'proprietary_short_name' ];
162
-        self::$fileType[ 'converter_version' ]      = $pipeline[ 'converter_version' ];
159
+        self::$fileType['proprietary']            = $pipeline['proprietary'];
160
+        self::$fileType['proprietary_name']       = $pipeline['proprietary_name'];
161
+        self::$fileType['proprietary_short_name'] = $pipeline['proprietary_short_name'];
162
+        self::$fileType['converter_version']      = $pipeline['converter_version'];
163 163
 
164 164
         return self::$fileType;
165 165
     }
@@ -171,21 +171,21 @@  discard block
 block discarded – undo
171 171
      *
172 172
      * @return bool|int
173 173
      */
174
-    public static function fileMustBeConverted( string $fullPath, ?bool $enforceOnXliff = false, ?string $filterAddress = null ) {
174
+    public static function fileMustBeConverted(string $fullPath, ?bool $enforceOnXliff = false, ?string $filterAddress = null) {
175 175
         $convert = true;
176 176
 
177
-        $fileType       = self::getInfo( $fullPath );
178
-        $memoryFileType = Files::getMemoryFileType( $fullPath );
177
+        $fileType       = self::getInfo($fullPath);
178
+        $memoryFileType = Files::getMemoryFileType($fullPath);
179 179
 
180
-        if ( Files::isXliff( $fullPath ) || $memoryFileType ) {
181
-            if ( !empty( $filterAddress ) ) {
180
+        if (Files::isXliff($fullPath) || $memoryFileType) {
181
+            if (!empty($filterAddress)) {
182 182
 
183 183
                 //conversion enforce
184
-                if ( !$enforceOnXliff ) {
184
+                if (!$enforceOnXliff) {
185 185
 
186 186
                     //if file is not proprietary AND Enforce is disabled
187 187
                     //we take it as is
188
-                    if ( !$fileType[ 'proprietary' ] || $memoryFileType ) {
188
+                    if (!$fileType['proprietary'] || $memoryFileType) {
189 189
                         $convert = false;
190 190
                         //ok don't convert a standard sdlxliff
191 191
                     }
@@ -193,16 +193,16 @@  discard block
 block discarded – undo
193 193
                     //if conversion enforce is active
194 194
                     //we force all xliff files but not files produced by SDL Studio because we can handle them
195 195
                     if (
196
-                            $fileType[ 'proprietary_short_name' ] == 'matecat_converter'
197
-                            || $fileType[ 'proprietary_short_name' ] == 'trados'
198
-                            || $fileType[ 'proprietary_short_name' ] == 'xliff_v2'
196
+                            $fileType['proprietary_short_name'] == 'matecat_converter'
197
+                            || $fileType['proprietary_short_name'] == 'trados'
198
+                            || $fileType['proprietary_short_name'] == 'xliff_v2'
199 199
                             || $memoryFileType
200 200
                     ) {
201 201
                         $convert = false;
202 202
                         //ok don't convert a standard sdlxliff
203 203
                     }
204 204
                 }
205
-            } elseif ( $fileType[ 'proprietary' ] ) {
205
+            } elseif ($fileType['proprietary']) {
206 206
 
207 207
                 /**
208 208
                  * Application misconfiguration.
Please login to merge, or discard this patch.
src/XliffReplacer/XliffReplacerFactory.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -28,14 +28,14 @@
 block discarded – undo
28 28
             ?LoggerInterface                $logger = null,
29 29
             ?XliffReplacerCallbackInterface $callback = null
30 30
     ): AbstractXliffReplacer {
31
-        $info = XliffProprietaryDetect::getInfo( $originalXliffPath );
31
+        $info = XliffProprietaryDetect::getInfo($originalXliffPath);
32 32
 
33
-        if ( $info[ 'version' ] == 1 && $info[ 'proprietary_short_name' ] !== 'trados' ) {
34
-            return new Xliff12( $originalXliffPath, $info[ 'version' ], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback );
35
-        } elseif ( $info[ 'version' ] == 2 ) {
36
-            return new Xliff20( $originalXliffPath, $info[ 'version' ], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback );
33
+        if ($info['version'] == 1 && $info['proprietary_short_name'] !== 'trados') {
34
+            return new Xliff12($originalXliffPath, $info['version'], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback);
35
+        } elseif ($info['version'] == 2) {
36
+            return new Xliff20($originalXliffPath, $info['version'], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback);
37 37
         }
38 38
 
39
-        return new XliffSdl( $originalXliffPath, $info[ 'version' ], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback );
39
+        return new XliffSdl($originalXliffPath, $info['version'], $data, $transUnits, $targetLang, $outputFilePath, $setSourceInTarget, $logger, $callback);
40 40
     }
41 41
 }
Please login to merge, or discard this patch.
src/XliffReplacer/XliffSdl.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -16,24 +16,24 @@  discard block
 block discarded – undo
16 16
     /**
17 17
      * @inheritDoc
18 18
      */
19
-    protected function tagOpen( $parser, string $name, array $attr ) {
19
+    protected function tagOpen($parser, string $name, array $attr) {
20 20
 
21
-        $this->handleOpenUnit( $name, $attr );
21
+        $this->handleOpenUnit($name, $attr);
22 22
 
23 23
         // check if we are entering into a <target>
24
-        $this->checkSetInTarget( $name );
24
+        $this->checkSetInTarget($name);
25 25
 
26 26
         // reset Marker positions
27
-        if ( 'sdl:seg-defs' == $name ) {
27
+        if ('sdl:seg-defs' == $name) {
28 28
             $this->segmentInUnitPosition = 0;
29 29
         }
30 30
 
31 31
         // open buffer
32
-        $this->setInBuffer( $name );
32
+        $this->setInBuffer($name);
33 33
 
34 34
         // check if we are inside a <target>, obviously this happen only if there are targets inside the trans-unit
35 35
         // <target> must be stripped to be replaced, so this check avoids <target> reconstruction
36
-        if ( !$this->inTarget ) {
36
+        if (!$this->inTarget) {
37 37
 
38 38
             // costruct tag
39 39
             $tag = "<$name ";
@@ -43,16 +43,16 @@  discard block
 block discarded – undo
43 43
             // so the check on it's name is not enough
44 44
             $_sdlStatus_confWritten = false;
45 45
 
46
-            foreach ( $attr as $k => $v ) {
46
+            foreach ($attr as $k => $v) {
47 47
 
48 48
                 // if tag name is file, we must replace the target-language attribute
49
-                if ( $name == 'file' && $k == 'target-language' && !empty( $this->targetLang ) ) {
49
+                if ($name == 'file' && $k == 'target-language' && !empty($this->targetLang)) {
50 50
                     //replace Target language with job language provided from constructor
51 51
                     $tag .= "$k=\"$this->targetLang\" ";
52 52
                 } else {
53 53
                     //normal tag flux, put attributes in it
54 54
                     // Warning, this is NOT an elseif
55
-                    if ( $k != 'conf' ) {
55
+                    if ($k != 'conf') {
56 56
                         //put also the current attribute in it if it is not a "conf" attribute
57 57
                         $tag .= "$k=\"$v\" ";
58 58
                     }
@@ -61,11 +61,11 @@  discard block
 block discarded – undo
61 61
 
62 62
             $seg = $this->getCurrentSegment();
63 63
 
64
-            if ( 'sdl:seg' == $name && !empty( $seg ) and isset( $seg[ 'sid' ] ) ) {
65
-                $tag .= $this->prepareTargetStatuses( $seg );
64
+            if ('sdl:seg' == $name && !empty($seg) and isset($seg['sid'])) {
65
+                $tag .= $this->prepareTargetStatuses($seg);
66 66
             }
67 67
 
68
-            $this->checkForSelfClosedTagAndFlush( $parser, $tag );
68
+            $this->checkForSelfClosedTagAndFlush($parser, $tag);
69 69
 
70 70
         }
71 71
 
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
      *
77 77
      * @return string
78 78
      */
79
-    protected function prepareTargetStatuses( $segment ): string {
79
+    protected function prepareTargetStatuses($segment): string {
80 80
         $statusMap = [
81 81
                 'NEW'        => '',
82 82
                 'DRAFT'      => 'Draft',
@@ -86,19 +86,19 @@  discard block
 block discarded – undo
86 86
                 'REJECTED'   => 'RejectedTranslation',
87 87
         ];
88 88
 
89
-        return "conf=\"{$statusMap[ $segment[ 'status' ] ]}\" ";
89
+        return "conf=\"{$statusMap[$segment['status']]}\" ";
90 90
     }
91 91
 
92
-    protected function rebuildMarks( array $seg, string $translation ): string {
92
+    protected function rebuildMarks(array $seg, string $translation): string {
93 93
 
94
-        $trailingSpaces = str_repeat( ' ', Strings::getTheNumberOfTrailingSpaces( $translation ) );
94
+        $trailingSpaces = str_repeat(' ', Strings::getTheNumberOfTrailingSpaces($translation));
95 95
 
96
-        if ( $seg[ 'mrk_id' ] !== null && $seg[ 'mrk_id' ] != '' ) {
97
-            if ( $this->targetLang === 'ja-JP' ) {
98
-                $seg[ 'mrk_succ_tags' ] = ltrim( $seg[ 'mrk_succ_tags' ] );
96
+        if ($seg['mrk_id'] !== null && $seg['mrk_id'] != '') {
97
+            if ($this->targetLang === 'ja-JP') {
98
+                $seg['mrk_succ_tags'] = ltrim($seg['mrk_succ_tags']);
99 99
             }
100 100
 
101
-            $translation = "<mrk mid=\"" . $seg[ 'mrk_id' ] . "\" mtype=\"seg\">" . $seg[ 'mrk_prev_tags' ] . rtrim( $translation ) . $seg[ 'mrk_succ_tags' ] . "</mrk>" . $trailingSpaces;
101
+            $translation = "<mrk mid=\"" . $seg['mrk_id'] . "\" mtype=\"seg\">" . $seg['mrk_prev_tags'] . rtrim($translation) . $seg['mrk_succ_tags'] . "</mrk>" . $trailingSpaces;
102 102
         }
103 103
 
104 104
         return $translation;
Please login to merge, or discard this patch.
src/XliffReplacer/XliffReplacerCallbackInterface.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,5 +12,5 @@
 block discarded – undo
12 12
      *
13 13
      * @return bool
14 14
      */
15
-    public function thereAreErrors( int $segmentId, string $segment, string $translation, ?array $dataRefMap = [], ?string $error = null ): bool;
15
+    public function thereAreErrors(int $segmentId, string $segment, string $translation, ?array $dataRefMap = [], ?string $error = null): bool;
16 16
 }
Please login to merge, or discard this patch.