Matecat\SimpleS3\Commands\Handlers\OpenItem::handle()

Complexity

Conditions	3
Paths	6

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.512

Importance

Changes

0

<?php
    public function handle(array $params = []): ?string
    {
        $bucketName = $params[ 'bucket' ];
        $keyName    = $params[ 'key' ];

        try {
            $url     = $this->client->getPublicItemLink(['bucket' => $bucketName, 'key' => $keyName]);
            $content = File::loadFile($url, $this->client->hasSslVerify());

            if (false === $content) {
                $this->commandHandlerLogger?->log($this, sprintf('Something went wrong during getting content of \'%s\' item from \'%s\' bucket', $keyName, $bucketName), 'warning');

                return null;
            }

            $this->commandHandlerLogger?->log($this, sprintf('Content from \'%s\' item was successfully obtained from \'%s\' bucket', $keyName, $bucketName));

            return $content;

The expression return $content could return the type true which is incompatible with the type-hinted return null|string. Consider adding an additional type-check to rule them out.

        } catch (Exception $e) {
            $this->commandHandlerLogger?->logExceptionAndReturnFalse($e);

            throw $e;
        }