Issues (257)

src/AdsenseBuilder.php (60 issues)

1
<?php
0 ignored issues
show
Class found in ".php" file; use ".inc" extension instead
Loading history...
There must be no blank lines before the file comment
Loading history...
The PHP open tag does not have a corresponding PHP close tag
Loading history...
Filename "AdsenseBuilder.php" doesn't match the expected filename "adsensebuilder.php"
Loading history...
2
3
/**
0 ignored issues
show
Namespaced classes, interfaces and traits should not begin with a file doc comment
Loading history...
4
 * Google Adsense Ads for Laravel.
5
 *
6
 * Package for easily including Google Adsense Ad units
7
 * in Laravel and Lumen.
8
 *
9
 * @developer Martin Butt <https://www.martinbutt.com/>
0 ignored issues
show
The tag in position 1 should be the @package tag
Loading history...
10
 *
11
 * @copyright Copyright (c) 2021 Martin Butt
0 ignored issues
show
Coding Style Documentation introduced by
Expected "xxxx-xxxx Squiz Pty Ltd (ABN 77 084 670 600)" for copyright declaration
Loading history...
The tag in position 2 should be the @subpackage tag
Loading history...
@copyright tag must contain a year and the name of the copyright holder
Loading history...
12
 * @license   MIT
0 ignored issues
show
The tag in position 3 should be the @author tag
Loading history...
@license tag must contain a URL and a license name
Loading history...
Tag value indented incorrectly; expected 1 space but found 3
Loading history...
13
 *
14
 * Copyright (c) 2016 Galen Han
15
 * Copyright (c) 2019 Crypto Technology srl
16
 * Copyright (c) 2021 Martin Butt
17
 *
18
 *
19
 * Permission is hereby granted, free of charge, to any person obtaining a copy of
0 ignored issues
show
Line exceeds 80 characters; contains 82 characters
Loading history...
20
 * this software and associated documentation files (the "Software"), to deal in
21
 * the Software without restriction, including without limitation the rights to
22
 * use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
0 ignored issues
show
Line exceeds 80 characters; contains 83 characters
Loading history...
23
 * the Software, and to permit persons to whom the Software is furnished to do so,
0 ignored issues
show
Line exceeds 80 characters; contains 82 characters
Loading history...
24
 * subject to the following conditions:
25
 *
26
 * The above copyright notice and this permission notice shall be included in all
0 ignored issues
show
Line exceeds 80 characters; contains 81 characters
Loading history...
27
 * copies or substantial portions of the Software.
28
 *
29
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
0 ignored issues
show
Line exceeds 80 characters; contains 83 characters
Loading history...
31
 * FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
0 ignored issues
show
Line exceeds 80 characters; contains 81 characters
Loading history...
32
 * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
0 ignored issues
show
Line exceeds 80 characters; contains 81 characters
Loading history...
33
 * IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34
 * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35
 */
0 ignored issues
show
PHP version not specified
Loading history...
Coding Style Documentation introduced by
Missing @package tag in file comment
Loading history...
Coding Style Documentation introduced by
Missing @subpackage tag in file comment
Loading history...
Coding Style Documentation introduced by
Missing @author tag in file comment
Loading history...
Missing @category tag in file comment
Loading history...
Missing @link tag in file comment
Loading history...
36
37
declare(strict_types=1);
38
39
namespace MartinButt\Laravel\Adsense;
40
41
class AdsenseBuilder
0 ignored issues
show
Coding Style Documentation introduced by
Missing doc comment for class AdsenseBuilder
Loading history...
Missing class doc comment
Loading history...
42
{
0 ignored issues
show
Opening brace should be on the same line as the declaration for class AdsenseBuilder
Loading history...
Opening brace should be on the same line as the declaration
Loading history...
43
    public function ads($unit)
0 ignored issues
show
Line indented incorrectly; expected 2 spaces, found 4
Loading history...
Expected 1 blank line before function; 0 found
Loading history...
Missing doc comment for function ads()
Loading history...
Missing function doc comment
Loading history...
44
    {
0 ignored issues
show
Opening brace should be on the same line as the declaration
Loading history...
45
        return view('adsense::ads')->with([
0 ignored issues
show
Line indented incorrectly; expected 4 spaces, found 8
Loading history...
Short array syntax is not allowed
Loading history...
46
            'ad_client' => config('adsense.client_id'),
0 ignored issues
show
Array indentation error, expected 10 spaces but found 12
Loading history...
47
            'ad_style' => config("adsense.ads.$unit.ad_style", 'display:block;'),
0 ignored issues
show
Array indentation error, expected 10 spaces but found 12
Loading history...
Coding Style Best Practice introduced by
As per coding-style, please use concatenation or sprintf for the variable $unit instead of interpolation.

It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings.

// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
Loading history...
48
            'ad_slot' => config("adsense.ads.$unit.ad_slot"),
0 ignored issues
show
Array indentation error, expected 10 spaces but found 12
Loading history...
Coding Style Best Practice introduced by
As per coding-style, please use concatenation or sprintf for the variable $unit instead of interpolation.

It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings.

// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
Loading history...
49
            'ad_format' => config("adsense.ads.$unit.ad_format"),
0 ignored issues
show
Array indentation error, expected 10 spaces but found 12
Loading history...
Coding Style Best Practice introduced by
As per coding-style, please use concatenation or sprintf for the variable $unit instead of interpolation.

It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings.

// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
Loading history...
50
            'ad_full_width_responsive' => config("adsense.ads.$unit.ad_full_width_responsive"),
0 ignored issues
show
Array indentation error, expected 10 spaces but found 12
Loading history...
Coding Style Best Practice introduced by
As per coding-style, please use concatenation or sprintf for the variable $unit instead of interpolation.

It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings.

// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
Loading history...
51
        ]);
52
    }
0 ignored issues
show
Expected 1 blank line before closing function brace; 0 found
Loading history...
Line indented incorrectly; expected 2 spaces, found 4
Loading history...
Expected //end ads()
Loading history...
53 2
54
    public function javascript()
0 ignored issues
show
Line indented incorrectly; expected 2 spaces, found 4
Loading history...
Missing function doc comment
Loading history...
Missing doc comment for function javascript()
Loading history...
55 2
    {
0 ignored issues
show
Opening brace should be on the same line as the declaration
Loading history...
56
        return view('adsense::javascript', ['client_id' => config('adsense.client_id')]);
0 ignored issues
show
Line indented incorrectly; expected 4 spaces, found 8
Loading history...
Short array syntax is not allowed
Loading history...
57
    }
0 ignored issues
show
Expected //end javascript()
Loading history...
Expected 1 blank line before closing function brace; 0 found
Loading history...
Expected 1 blank line after function; 0 found
Loading history...
Line indented incorrectly; expected 2 spaces, found 4
Loading history...
58
}
0 ignored issues
show
As per coding style, files should not end with a newline character.

This check marks files that end in a newline character, i.e. an empy line.

Loading history...
Expected //end class
Loading history...
59