Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
19 | class SocialPostExtension extends Extension |
||
20 | { |
||
21 | /** |
||
22 | * {@inheritdoc} |
||
23 | */ |
||
24 | public function load(array $configs, ContainerBuilder $container) |
||
25 | { |
||
26 | $configuration = $this->processConfiguration(new Configuration(), $configs); |
||
27 | $loader = new YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config')); |
||
28 | $loader->load('services.yml'); |
||
29 | |||
30 | $container->setParameter('social_post.configuration.publish_on', $configuration['publish_on']); |
||
31 | |||
32 | $this->setFacebookParameters($configuration, $container); |
||
33 | $this->setLinkedInParameters($configuration, $container); |
||
34 | $this->setTwitterParameters($configuration, $container); |
||
35 | } |
||
36 | |||
37 | /** |
||
38 | * @param array $configuration |
||
39 | * @param ContainerBuilder $container |
||
40 | * @throws InvalidConfigurationException |
||
41 | */ |
||
42 | private function setFacebookParameters(array $configuration, ContainerBuilder $container) |
||
56 | |||
57 | /** |
||
58 | * @param array $configuration |
||
59 | * @param ContainerBuilder $container |
||
60 | * @throws InvalidConfigurationException |
||
61 | */ |
||
62 | View Code Duplication | private function setLinkedInParameters(array $configuration, ContainerBuilder $container) |
|
78 | |||
79 | /** |
||
80 | * @param array $configuration |
||
81 | * @param ContainerBuilder $container |
||
82 | * @throws InvalidConfigurationException |
||
83 | */ |
||
84 | View Code Duplication | private function setTwitterParameters(array $configuration, ContainerBuilder $container) |
|
100 | } |
||
101 |