MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\Traits\DistinctableTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	18
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getOptionalDistinctClause()	0	3	2
A	parseDistinctClause()	0	8	4

<?php

declare(strict_types=1);

namespace MartinGeorgiev\Doctrine\ORM\Query\AST\Functions\Traits;

use Doctrine\ORM\Query\Lexer;
use Doctrine\ORM\Query\Parser;
use Doctrine\ORM\Query\TokenType;
use MartinGeorgiev\Utils\DoctrineOrm;

trait DistinctableTrait
{
    protected bool $isDistinct = false;

    protected function parseDistinctClause(Parser $parser): void
    {
        $shouldUseLexer = DoctrineOrm::isPre219();
        $lexer = $parser->getLexer();

        if ($lexer->isNextToken($shouldUseLexer ? Lexer::T_DISTINCT : TokenType::T_DISTINCT)) {

The constant Doctrine\ORM\Query\Lexer::T_DISTINCT was not found. Maybe you did not declare it correctly or list all dependencies?

It seems like $shouldUseLexer ? Doctrine\ORM\Query\Lexer::T_DISTINCT : Doctrine\ORM\Query\TokenType::T_DISTINCT can also be of type Doctrine\ORM\Query\TokenType; however, parameter $type of Doctrine\Common\Lexer\AbstractLexer::isNextToken() does only seem to accept UnitEnum|integer|string, maybe add an additional type check?

            $parser->match($shouldUseLexer ? Lexer::T_DISTINCT : TokenType::T_DISTINCT);
            $this->isDistinct = true;
        }
    }

    protected function getOptionalDistinctClause(): string
    {
        return $this->isDistinct ? 'DISTINCT ' : '';
    }
}