BaseOrderableFunction::getOptionalOrderByClause() - Code Metrics - Inspection of "feat: add support for `ORDER BY` clause for `array..." - martin-georgiev/postgresql-for-doctrine - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — array_agg-and-order_by ( 4a69e9 )

by Martin

created 2025-03-11 18:10 UTC

BaseOrderableFunction::getOptionalOrderByClause() A

↳ Parent: BaseOrderableFunction

Complexity

Conditions	2
Paths	2

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	1
c	1
b	0
f	1
dl	0
loc	3
rs	10
cc	2
nc	2
nop	1

<?php

declare(strict_types=1);

namespace MartinGeorgiev\Doctrine\ORM\Query\AST\Functions;

use Doctrine\ORM\Query\AST\Node;
use Doctrine\ORM\Query\AST\OrderByClause;
use Doctrine\ORM\Query\Lexer;
use Doctrine\ORM\Query\Parser;
use Doctrine\ORM\Query\SqlWalker;
use Doctrine\ORM\Query\TokenType;
use MartinGeorgiev\Utils\DoctrineOrm;

abstract class BaseOrderableFunction extends BaseFunction
{
    protected Node $expression;
    protected ?OrderByClause $orderByClause = null;

    public function parse(Parser $parser): void
    {
        $shouldUseLexer = DoctrineOrm::isPre219();

        $this->customiseFunction();

        $parser->match($shouldUseLexer ? Lexer::T_IDENTIFIER : TokenType::T_IDENTIFIER);

        $parser->match($shouldUseLexer ? Lexer::T_OPEN_PARENTHESIS : TokenType::T_OPEN_PARENTHESIS);


        $this->parseFunction($parser);

        $lexer = $parser->getLexer();
        if ($lexer->isNextToken($shouldUseLexer ? Lexer::T_ORDER : TokenType::T_ORDER)) {
        if ($lexer->isNextToken(/** @scrutinizer ignore-type */ $shouldUseLexer ? Lexer::T_ORDER : TokenType::T_ORDER)) {
            $this->orderByClause = $parser->OrderByClause();
        }

        $parser->match($shouldUseLexer ? Lexer::T_CLOSE_PARENTHESIS : TokenType::T_CLOSE_PARENTHESIS);

    }

    abstract protected function parseFunction(Parser $parser): void;

    protected function getOptionalOrderByClause(SqlWalker $sqlWalker): string
    {
        return isset($this->orderByClause) ? $this->orderByClause->dispatch($sqlWalker) : '';
        return isset($this->orderByClause) ? $this->orderByClause->/** @scrutinizer ignore-call */ dispatch($sqlWalker) : '';
    }
}


martin-georgiev / postgresql-for-doctrine

Push — array_agg-and-order_by ( 4a69e9 )

BaseOrderableFunction::getOptionalOrderByClause() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like