Issues in SubscriptionPeriod.php (master) - Issues in master - marlon-be/marlon-ogone - Measure and Improve Code Quality continuously with Scrutinizer

Issues (77)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Ogone/Subscription/SubscriptionPeriod.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Ogone\Subscription;

use InvalidArgumentException;

class SubscriptionPeriod
{

    /** @var string */
    const UNIT_DAILY = 'd';

    /** @var string */
    const UNIT_WEEKLY = 'ww';

    /** @var string */
    const UNIT_MONTHLY = 'm';

    /**
     * @var string
     * ‘d’ = daily, ‘ww’ = weekly, ‘m’ = monthly
     */
    protected $unit;

    /**
     * @var int
     * Interval between each occurrence of the subscription payments
     */
    protected $interval;

    /**
     * @var int
     * Depending on sub_period_unit
     * Daily (d):
     *      interval in days
     * Weekly (ww):
     *      1=Sunday, … 7=Saturday
     * Monthly (m):
     *      day of the month
     */
    protected $moment;

    /**
     * @param string $unit
     * @param int $interval
     * @param int $moment
     * @throws InvalidArgumentException
     */
    public function __construct($unit, $interval, $moment)
    {
        $this->setUnit($unit);
        $this->setInterval($interval);
        $this->setMoment($moment);
    }

    /**
     * @return string
     */
    public function getUnit()
    {
        return $this->unit;
    }

    /**
     * @param string $unit
     * @throws InvalidArgumentException
     */
    public function setUnit($unit)
    {
        if (!in_array($unit, array(self::UNIT_DAILY, self::UNIT_WEEKLY, self::UNIT_MONTHLY))) {
            throw new InvalidArgumentException("Subscription period unit should be '".self::UNIT_DAILY."' (daily), '".self::UNIT_WEEKLY."' (weekly) or '".self::UNIT_MONTHLY."' (monthly)");
        }

        if (self::UNIT_WEEKLY === $unit) {

            if ($this->moment > 7) {
                throw new InvalidArgumentException('The unit cannot be set to weekly while the moment > 7');
            }
        } elseif (self::UNIT_MONTHLY === $unit && $this->moment > 28) {
            throw new InvalidArgumentException('The unit cannot be set to monthly while the moment > 28');
        }
        $this->unit = $unit;
    }

    /**
     * @return int
     */
    public function getInterval()
    {
        return $this->interval;
    }

    /**
     * @param int $interval
     * @throws InvalidArgumentException
     */
    public function setInterval($interval)
    {
        if (!is_int($interval)) {
            throw new InvalidArgumentException("Integer expected for interval");
        }
        if ($interval < 0) {
            throw new InvalidArgumentException("Interval must be a positive number > 0");
        }
        if ($interval >= 1.0E+15) {
            throw new InvalidArgumentException("Interval is too high");
        }
        $this->interval = $interval;
    }

    /**
     * @return int
     */
    public function getMoment()
    {
        return $this->moment;
    }

    /**
     * @param int $moment
     * @throws InvalidArgumentException
     */
    public function setMoment($moment)
    {
        if (!is_int($moment)) {
            throw new InvalidArgumentException("Integer expected for moment");
        }
        if ($moment <= 0) {
            throw new InvalidArgumentException("Moment must be a positive number");
        }
        if ($moment >= 1.0E+15) {
            throw new InvalidArgumentException("Interval is too high");
        }

        if (self::UNIT_WEEKLY == $this->unit) {

            // Valid values are 1 to 7
            if ($moment > 7) {
                throw new InvalidArgumentException("Moment should be 1 (Sunday), 2, 3 .. 7 (Saturday)");
            }
        } elseif (self::UNIT_MONTHLY == $this->unit && $moment > 28) {
            // We will not allow a day of month > 28
            throw new InvalidArgumentException("Moment can't be larger than 29. Last day for month allowed is 28.");
        }

        $this->moment = $moment;
    }
}


1			<?php
2
3			namespace Ogone\Subscription;
4
5			use InvalidArgumentException;
6
7			class SubscriptionPeriod
8			{
9
10			/** @var string */
11			const UNIT_DAILY = 'd';
12
13			/** @var string */
14			const UNIT_WEEKLY = 'ww';
15
16			/** @var string */
17			const UNIT_MONTHLY = 'm';
18
19			/**
20			* @var string
21			* ‘d’ = daily, ‘ww’ = weekly, ‘m’ = monthly
22			*/
23			protected $unit;
24
25			/**
26			* @var int
27			* Interval between each occurrence of the subscription payments
28			*/
29			protected $interval;
30
31			/**
32			* @var int
33			* Depending on sub_period_unit
34			* Daily (d):
35			* interval in days
36			* Weekly (ww):
37			* 1=Sunday, … 7=Saturday
38			* Monthly (m):
39			* day of the month
40			*/
41			protected $moment;
42
43			/**
44			* @param string $unit
45			* @param int $interval
46			* @param int $moment
47			* @throws InvalidArgumentException
48			*/
49	23		public function __construct($unit, $interval, $moment)
50			{
51	23		$this->setUnit($unit);
52	22		$this->setInterval($interval);
53	19		$this->setMoment($moment);
54	14		}
55
56			/**
57			* @return string
58			*/
59	4		public function getUnit()
60			{
61	4		return $this->unit;
62			}
63
64			/**
65			* @param string $unit
66			* @throws InvalidArgumentException
67			*/
68	23		public function setUnit($unit)
69			{
70	23		if (!in_array($unit, array(self::UNIT_DAILY, self::UNIT_WEEKLY, self::UNIT_MONTHLY))) {
71	1		throw new InvalidArgumentException("Subscription period unit should be '".self::UNIT_DAILY."' (daily), '".self::UNIT_WEEKLY."' (weekly) or '".self::UNIT_MONTHLY."' (monthly)");
72			}
73
74	22	View Code Duplication	if (self::UNIT_WEEKLY === $unit) {
			0 ignored issues – show Duplication introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75	3		if ($this->moment > 7) {
76	1		throw new InvalidArgumentException('The unit cannot be set to weekly while the moment > 7');
77			}
78	20		} elseif (self::UNIT_MONTHLY === $unit && $this->moment > 28) {
79	1		throw new InvalidArgumentException('The unit cannot be set to monthly while the moment > 28');
80			}
81	22		$this->unit = $unit;
82	22		}
83
84			/**
85			* @return int
86			*/
87	5		public function getInterval()
88			{
89	5		return $this->interval;
90			}
91
92			/**
93			* @param int $interval
94			* @throws InvalidArgumentException
95			*/
96	22		public function setInterval($interval)
97			{
98	22		if (!is_int($interval)) {
99	1		throw new InvalidArgumentException("Integer expected for interval");
100			}
101	21		if ($interval < 0) {
102	1		throw new InvalidArgumentException("Interval must be a positive number > 0");
103			}
104	20		if ($interval >= 1.0E+15) {
105	1		throw new InvalidArgumentException("Interval is too high");
106			}
107	19		$this->interval = $interval;
108	19		}
109
110			/**
111			* @return int
112			*/
113	5		public function getMoment()
114			{
115	5		return $this->moment;
116			}
117
118			/**
119			* @param int $moment
120			* @throws InvalidArgumentException
121			*/
122	19		public function setMoment($moment)
123			{
124	19		if (!is_int($moment)) {
125	1		throw new InvalidArgumentException("Integer expected for moment");
126			}
127	18		if ($moment <= 0) {
128	1		throw new InvalidArgumentException("Moment must be a positive number");
129			}
130	17		if ($moment >= 1.0E+15) {
131	1		throw new InvalidArgumentException("Interval is too high");
132			}
133
134	16	View Code Duplication	if (self::UNIT_WEEKLY == $this->unit) {
			0 ignored issues – show Duplication introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
135			// Valid values are 1 to 7
136	2		if ($moment > 7) {
137	1		throw new InvalidArgumentException("Moment should be 1 (Sunday), 2, 3 .. 7 (Saturday)");
138			}
139	14		} elseif (self::UNIT_MONTHLY == $this->unit && $moment > 28) {
140			// We will not allow a day of month > 28
141	1		throw new InvalidArgumentException("Moment can't be larger than 29. Last day for month allowed is 28.");
142			}
143
144	14		$this->moment = $moment;
145	14		}
146			}
147

GitHub Access Token became invalid

Issues (77)

Security Analysis no request data

lib/Ogone/Subscription/SubscriptionPeriod.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

marlon-be / marlon-ogone

GitHub Access Token became invalid

Issues (77)

Security Analysis no request data

lib/Ogone/Subscription/SubscriptionPeriod.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like