OgoneTest::AliasIsCreatedByOgone() - Code Metrics - Inspection of "Clean up code base" - marlon-be/marlon-ogone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#62)

by Jelte

created 2016-05-07 10:26 UTC

OgoneTest::AliasIsCreatedByOgone() A

↳ Parent: OgoneTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	11
Ratio	100 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	11
loc	11
rs	9.4285
cc	1
eloc	7
nc	1
nop	0

<?php
/*
 * This file is part of the Marlon Ogone package.
 *
 * (c) Marlon BVBA <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Ogone\Tests;

use Guzzle\Http\Client;
use Ogone\DirectLink\Eci;
use Ogone\Passphrase;
use Ogone\DirectLink\Alias;
use Ogone\DirectLink\CreateAliasRequest;
use Ogone\DirectLink\CreateAliasResponse;
use Ogone\ShaComposer\AllParametersShaComposer;
use Ogone\ParameterFilter\ShaOutParameterFilter;
use Ogone\DirectLink\DirectLinkPaymentRequest;
use Ogone\DirectLink\DirectLinkPaymentResponse;

/**
 * @group integration
 */
class OgoneTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @test
     */
    public function AliasCreationIsSuccessful()
    {
        $passphraseOut = new Passphrase(PASSPHRASE_SHA_OUT);
        $shaOutComposer = new AllParametersShaComposer($passphraseOut);
        $shaOutComposer->addParameterFilter(new ShaOutParameterFilter());

        $createAliasResponse = $this->provideAliasResponse();

        $this->assertTrue($createAliasResponse->isValid($shaOutComposer));
        $this->assertTrue($createAliasResponse->isSuccessful());

        return (string) $createAliasResponse->getAlias();
    }

    /**
     * @test
     * @depends AliasCreationIsSuccessful
     */
    public function DirectLinkPaymentIsSuccessful($alias)
    {
        $passphrase = new Passphrase(PASSPHRASE_SHA_IN);
        $shaComposer = new AllParametersShaComposer($passphrase);
        $directLinkRequest = new DirectLinkPaymentRequest($shaComposer);

        $orderId = uniqid('order_'); // create a unique order id
        $directLinkRequest->setOrderid($orderId);

        $alias = new Alias($alias);
        $directLinkRequest->setPspid(PSPID);
        $directLinkRequest->setUserId(USERID);
        $directLinkRequest->setPassword(PASSWORD);
        $directLinkRequest->setAlias($alias);
        $directLinkRequest->setAmount(100);
        $directLinkRequest->setCurrency('EUR');
        $directLinkRequest->setEci(new Eci(Eci::ECOMMERCE_RECURRING));
        $directLinkRequest->validate();

        $body = array();
        foreach ($directLinkRequest->toArray() as $key => $value) {
            $body[strtoupper($key)] = $value;
        }

        $body['SHASIGN'] = $directLinkRequest->getShaSign();

        $client = new Client($directLinkRequest->getOgoneUri());
        $request = $client->post(null, null, $body);
        $response = $request->send();

        $directLinkResponse = new DirectLinkPaymentResponse($response->getBody(true));

        $this->assertTrue($directLinkResponse->isSuccessful());

        return $alias;
    }

    /**
     * @test
     */
    public function AliasIsCreatedByOgone()

    {
        $passphraseOut = new Passphrase(PASSPHRASE_SHA_OUT);
        $shaOutComposer = new AllParametersShaComposer($passphraseOut);
        $shaOutComposer->addParameterFilter(new ShaOutParameterFilter());

        $createAliasResponse = $this->provideAliasResponse(false);

        $this->assertTrue($createAliasResponse->isValid($shaOutComposer));
        $this->assertTrue($createAliasResponse->isSuccessful());
    }

    /**
     * @test
     */
    public function CreateAliasInvalid()

    {
        $passphraseOut = new Passphrase(PASSPHRASE_SHA_OUT);
        $shaOutComposer = new AllParametersShaComposer($passphraseOut);
        $shaOutComposer->addParameterFilter(new ShaOutParameterFilter());

        $createAliasResponse = $this->provideAliasResponse(true, true);

        $this->assertTrue($createAliasResponse->isValid($shaOutComposer));
        $this->assertFalse($createAliasResponse->isSuccessful());
    }


    public function provideAliasResponse($createAlias = true, $noValidCardnumber = false)
    {
        /*
         *  Create an alias request to Ogone
         */
        $passphrase = new Passphrase(PASSPHRASE_SHA_IN);
        $shaComposer = new AllParametersShaComposer($passphrase);

        $createAliasRequest = new CreateAliasRequest($shaComposer);
        $createAliasRequest->setPspid(PSPID);
        $createAliasRequest->setAccepturl('http://www.example.com');
        $createAliasRequest->setExceptionurl('http://www.example.com');

        if ($createAlias == true) {

            $unique_alias = uniqid('customer_'); // create a unique alias
            $alias = new Alias($unique_alias);
            $createAliasRequest->setAlias($alias);
        }

        $createAliasRequest->validate();

        $body = array();
        foreach ($createAliasRequest->toArray() as $key => $value) {
            $body[strtoupper($key)] = $value;
        }

        $body['SHASIGN'] = $createAliasRequest->getShaSign();
        $body['CN'] = 'Don Corleone';
        $body['CARDNO'] = ($noValidCardnumber) ? '' : '4111111111111111'; // Ogone Visa test cardnumber
        $body['CVC'] = '777';
        $body['ED'] = date('my', strtotime('+1 year')); // test-date should be in the future

        $client = new Client($createAliasRequest->getOgoneUri());
        $request = $client->post(null, null, $body);
        $response = $request->send();

        $url = parse_url($response->getInfo('url'));
        $params = array();
        parse_str($url['query'], $params);

        /*
         * Validate alias response from Ogone
         */

        $createAliasResponse = new CreateAliasResponse($params);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        return $createAliasResponse;
    }
}


1		<?php
2		/*
3		* This file is part of the Marlon Ogone package.
4		*
5		* (c) Marlon BVBA <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Ogone\Tests;
12
13		use Guzzle\Http\Client;
14		use Ogone\DirectLink\Eci;
15		use Ogone\Passphrase;
16		use Ogone\DirectLink\Alias;
17		use Ogone\DirectLink\CreateAliasRequest;
18		use Ogone\DirectLink\CreateAliasResponse;
19		use Ogone\ShaComposer\AllParametersShaComposer;
20		use Ogone\ParameterFilter\ShaOutParameterFilter;
21		use Ogone\DirectLink\DirectLinkPaymentRequest;
22		use Ogone\DirectLink\DirectLinkPaymentResponse;
23
24		/**
25		* @group integration
26		*/
27		class OgoneTest extends \PHPUnit_Framework_TestCase
28		{
29		/**
30		* @test
31		*/
32		public function AliasCreationIsSuccessful()
33		{
34		$passphraseOut = new Passphrase(PASSPHRASE_SHA_OUT);
35		$shaOutComposer = new AllParametersShaComposer($passphraseOut);
36		$shaOutComposer->addParameterFilter(new ShaOutParameterFilter());
37
38		$createAliasResponse = $this->provideAliasResponse();
39
40		$this->assertTrue($createAliasResponse->isValid($shaOutComposer));
41		$this->assertTrue($createAliasResponse->isSuccessful());
42
43		return (string) $createAliasResponse->getAlias();
44		}
45
46		/**
47		* @test
48		* @depends AliasCreationIsSuccessful
49		*/
50		public function DirectLinkPaymentIsSuccessful($alias)
51		{
52		$passphrase = new Passphrase(PASSPHRASE_SHA_IN);
53		$shaComposer = new AllParametersShaComposer($passphrase);
54		$directLinkRequest = new DirectLinkPaymentRequest($shaComposer);
55
56		$orderId = uniqid('order_'); // create a unique order id
57		$directLinkRequest->setOrderid($orderId);
58
59		$alias = new Alias($alias);
60		$directLinkRequest->setPspid(PSPID);
61		$directLinkRequest->setUserId(USERID);
62		$directLinkRequest->setPassword(PASSWORD);
63		$directLinkRequest->setAlias($alias);
64		$directLinkRequest->setAmount(100);
65		$directLinkRequest->setCurrency('EUR');
66		$directLinkRequest->setEci(new Eci(Eci::ECOMMERCE_RECURRING));
67		$directLinkRequest->validate();
68
69		$body = array();
70		foreach ($directLinkRequest->toArray() as $key => $value) {
71		$body[strtoupper($key)] = $value;
72		}
73
74		$body['SHASIGN'] = $directLinkRequest->getShaSign();
75
76		$client = new Client($directLinkRequest->getOgoneUri());
77		$request = $client->post(null, null, $body);
78		$response = $request->send();
79
80		$directLinkResponse = new DirectLinkPaymentResponse($response->getBody(true));
81
82		$this->assertTrue($directLinkResponse->isSuccessful());
83
84		return $alias;
85		}
86
87		/**
88		* @test
89		*/
90	View Code Duplication	public function AliasIsCreatedByOgone()
		0 ignored issues – show Duplication introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		{
92		$passphraseOut = new Passphrase(PASSPHRASE_SHA_OUT);
93		$shaOutComposer = new AllParametersShaComposer($passphraseOut);
94		$shaOutComposer->addParameterFilter(new ShaOutParameterFilter());
95
96		$createAliasResponse = $this->provideAliasResponse(false);
97
98		$this->assertTrue($createAliasResponse->isValid($shaOutComposer));
99		$this->assertTrue($createAliasResponse->isSuccessful());
100		}
101
102		/**
103		* @test
104		*/
105	View Code Duplication	public function CreateAliasInvalid()
		0 ignored issues – show Duplication introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		{
107		$passphraseOut = new Passphrase(PASSPHRASE_SHA_OUT);
108		$shaOutComposer = new AllParametersShaComposer($passphraseOut);
109		$shaOutComposer->addParameterFilter(new ShaOutParameterFilter());
110
111		$createAliasResponse = $this->provideAliasResponse(true, true);
112
113		$this->assertTrue($createAliasResponse->isValid($shaOutComposer));
114		$this->assertFalse($createAliasResponse->isSuccessful());
115		}
116
117
118		public function provideAliasResponse($createAlias = true, $noValidCardnumber = false)
119		{
120		/*
121		* Create an alias request to Ogone
122		*/
123		$passphrase = new Passphrase(PASSPHRASE_SHA_IN);
124		$shaComposer = new AllParametersShaComposer($passphrase);
125
126		$createAliasRequest = new CreateAliasRequest($shaComposer);
127		$createAliasRequest->setPspid(PSPID);
128		$createAliasRequest->setAccepturl('http://www.example.com');
129		$createAliasRequest->setExceptionurl('http://www.example.com');
130
131		if ($createAlias == true) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
132		$unique_alias = uniqid('customer_'); // create a unique alias
133		$alias = new Alias($unique_alias);
134		$createAliasRequest->setAlias($alias);
135		}
136
137		$createAliasRequest->validate();
138
139		$body = array();
140		foreach ($createAliasRequest->toArray() as $key => $value) {
141		$body[strtoupper($key)] = $value;
142		}
143
144		$body['SHASIGN'] = $createAliasRequest->getShaSign();
145		$body['CN'] = 'Don Corleone';
146		$body['CARDNO'] = ($noValidCardnumber) ? '' : '4111111111111111'; // Ogone Visa test cardnumber
147		$body['CVC'] = '777';
148		$body['ED'] = date('my', strtotime('+1 year')); // test-date should be in the future
149
150		$client = new Client($createAliasRequest->getOgoneUri());
151		$request = $client->post(null, null, $body);
152		$response = $request->send();
153
154		$url = parse_url($response->getInfo('url'));
155		$params = array();
156		parse_str($url['query'], $params);
157
158		/*
159		* Validate alias response from Ogone
160		*/
161
162		$createAliasResponse = new CreateAliasResponse($params);
		0 ignored issues – show Bug introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report It seems like `$params` can also be of type `null`; however, `Ogone\AbstractResponse::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
163
164		return $createAliasResponse;
165		}
166		}
167

marlon-be / marlon-ogone

GitHub Access Token became invalid

Pull Request — master (#62)

OgoneTest::AliasIsCreatedByOgone() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like