SimpleFormGenerator - Code Metrics - Inspection of "Clean up code base" - marlon-be/marlon-ogone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#62)

by Jelte

created 2016-05-07 10:26 UTC

SimpleFormGenerator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	6
Bugs	1	Features	1

Metric	Value
wmc	5
c	6
b	1
f	1
lcom	1
cbo	0
dl	0
loc	48
ccs	6
cts	6
cp	1
rs	10

3 Methods

Rating	Name	Size	Complexity
A	render()	9	3
A	showSubmitButton()	4	1
A	setFormName()	4	1

<?php

/*
 * This file is part of the Marlon Ogone package.
 *
 * (c) Marlon BVBA <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Ogone\FormGenerator;

use Ogone\Ecommerce\EcommercePaymentRequest;

class SimpleFormGenerator implements FormGenerator
{
    /**
     * @deprecated
     * @var null
     */
    private $formName = null;

    /**
     * @deprecated
     * @var null
     */
    private $showSubmitButton = null;

    /**
     * @param EcommercePaymentRequest $ecommercePaymentRequest
     * @param string $formName
     * @param bool $showSubmitButton
     * @return string HTML
     */
    public function render(EcommercePaymentRequest $ecommercePaymentRequest, $formName = 'ogone', $showSubmitButton = true)
    {
        $formName = null !== $this->formName?$this->formName:$formName;

        $showSubmitButton = null !== $this->showSubmitButton?$this->showSubmitButton:$showSubmitButton;


        ob_start();
        include __DIR__.'/template/simpleForm.php';
        return ob_get_clean();
    }

    /**
     * @deprecated Will be removed in next major released, directly integrated in render method.
     * @param bool $bool
     */
    public function showSubmitButton($bool = true)
    {
        $this->showSubmitButton = $bool;

    }

    /**
     * @deprecated Will be removed in next major released, directly integrated in render method.
     * @param $formName
     */
    public function setFormName($formName)
    {
        $this->formName = $formName;

    }
}


1		<?php
2
3		/*
4		* This file is part of the Marlon Ogone package.
5		*
6		* (c) Marlon BVBA <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Ogone\FormGenerator;
13
14		use Ogone\Ecommerce\EcommercePaymentRequest;
15
16		class SimpleFormGenerator implements FormGenerator
17		{
18		/**
19		* @deprecated
20		* @var null
21		*/
22		private $formName = null;
23
24		/**
25		* @deprecated
26		* @var null
27		*/
28		private $showSubmitButton = null;
29
30		/**
31		* @param EcommercePaymentRequest $ecommercePaymentRequest
32		* @param string $formName
33		* @param bool $showSubmitButton
34		* @return string HTML
35		*/
36	3	public function render(EcommercePaymentRequest $ecommercePaymentRequest, $formName = 'ogone', $showSubmitButton = true)
37		{
38	3	$formName = null !== $this->formName?$this->formName:$formName;
		0 ignored issues – show Deprecated Code introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report The property `Ogone\FormGenerator\SimpleFormGenerator::$formName` has been deprecated. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
39	3	$showSubmitButton = null !== $this->showSubmitButton?$this->showSubmitButton:$showSubmitButton;
		0 ignored issues – show Deprecated Code introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report The property `Ogone\FormGenerator\Simp...ator::$showSubmitButton` has been deprecated. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
40
41	3	ob_start();
42	3	include __DIR__.'/template/simpleForm.php';
43	3	return ob_get_clean();
44		}
45
46		/**
47		* @deprecated Will be removed in next major released, directly integrated in render method.
48		* @param bool $bool
49		*/
50		public function showSubmitButton($bool = true)
51		{
52		$this->showSubmitButton = $bool;
		0 ignored issues – show Documentation Bug introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report It seems like `$bool` of type `boolean` is incompatible with the declared type `null` of property `$showSubmitButton`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history... Deprecated Code introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report The property `Ogone\FormGenerator\Simp...ator::$showSubmitButton` has been deprecated. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
53		}
54
55		/**
56		* @deprecated Will be removed in next major released, directly integrated in render method.
57		* @param $formName
58		*/
59		public function setFormName($formName)
60		{
61		$this->formName = $formName;
		0 ignored issues – show Deprecated Code introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report The property `Ogone\FormGenerator\SimpleFormGenerator::$formName` has been deprecated. This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
62		}
63		}
64

marlon-be / marlon-ogone

GitHub Access Token became invalid

Pull Request — master (#62)

SimpleFormGenerator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like