CreateAliasResponseTest - Code Metrics - Inspection of "Clean up code base" - marlon-be/marlon-ogone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#62)

by Jelte

created 2016-05-07 10:00 UTC

CreateAliasResponseTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	68
Duplicated Lines	10.29 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
wmc	6
c	3
b	1
f	1
lcom	1
cbo	4
dl	7
loc	68
rs	10

6 Methods

Rating	Name	Duplication	Size	Complexity
A	CanBeVerified()	0	7	1
A	CannotExistWithoutShaSign()	0	4	1
A	ParametersCanBeRetrieved()	7	7	1
A	ChecksStatus()	0	7	1
A	AliasIsEqual()	0	10	1
A	provideRequest()	0	13	1

How to fix Duplicated Code

<?php
/*
 * This file is part of the Marlon Ogone package.
 *
 * (c) Marlon BVBA <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Ogone\Tests\DirectLink;

use Ogone\DirectLink\CreateAliasResponse;
use Ogone\Tests\ShaComposer\FakeShaComposer;

class CreateAliasResponseTest extends \PHPUnit_Framework_TestCase
{

    /** @test */
    public function CanBeVerified()
    {
        $aRequest = $this->provideRequest();

        $createAliasResponse = new CreateAliasResponse($aRequest);
        $this->assertTrue($createAliasResponse->isValid(new FakeShaComposer));
    }

    /**
     * @test
     * @expectedException InvalidArgumentException
     */
    public function CannotExistWithoutShaSign()
    {
        $createAliasResponse = new CreateAliasResponse(array());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    /** @test */
    public function ParametersCanBeRetrieved()

    {
        $aRequest = $this->provideRequest();

        $createAliasResponse = new CreateAliasResponse($aRequest);
        $this->assertEquals($aRequest['orderID'], $createAliasResponse->getParam('orderid'));
    }

    /** @test */
    public function ChecksStatus()
    {
        $aRequest = $this->provideRequest();

        $createAliasResponse = new CreateAliasResponse($aRequest);
        $this->assertTrue($createAliasResponse->isSuccessful());
    }

    /** @test */
    public function AliasIsEqual()
    {
        $aRequest = $this->provideRequest();
        $createAliasResponse = new CreateAliasResponse($aRequest);
        $alias = $createAliasResponse->getAlias();
        $this->assertEquals('customer_123', $alias->__toString());
        $this->assertEquals($aRequest['CN'], $alias->getCardName());
        $this->assertEquals($aRequest['CARDNO'], $alias->getCardNumber());
        $this->assertEquals($aRequest['ED'], $alias->getExpiryDate());
    }

    /**
     * Helper method to setup a request array
     */
    private function provideRequest()
    {
        return array(
            'SHASIGN' => FakeShaComposer::FAKESHASTRING,
            'UNKNOWN_PARAM' => false, /* unkown parameter, should be filtered out */
            'status' => 0,
            'orderID' => '48495482424',
            'alias' => 'customer_123',
            'CN' => 'John Doe',
            'CARDNO' => 'xxxxxxxxxxx4848',
            'ED' => '1220'
        );
    }
}


1		<?php
2		/*
3		* This file is part of the Marlon Ogone package.
4		*
5		* (c) Marlon BVBA <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace Ogone\Tests\DirectLink;
12
13		use Ogone\DirectLink\CreateAliasResponse;
14		use Ogone\Tests\ShaComposer\FakeShaComposer;
15
16		class CreateAliasResponseTest extends \PHPUnit_Framework_TestCase
17		{
18
19		/** @test */
20		public function CanBeVerified()
21		{
22		$aRequest = $this->provideRequest();
23
24		$createAliasResponse = new CreateAliasResponse($aRequest);
25		$this->assertTrue($createAliasResponse->isValid(new FakeShaComposer));
26		}
27
28		/**
29		* @test
30		* @expectedException InvalidArgumentException
31		*/
32		public function CannotExistWithoutShaSign()
33		{
34		$createAliasResponse = new CreateAliasResponse(array());
		0 ignored issues – show Unused Code introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report `$createAliasResponse` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
35		}
36
37		/** @test */
38	View Code Duplication	public function ParametersCanBeRetrieved()
		0 ignored issues – show Duplication introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		$aRequest = $this->provideRequest();
41
42		$createAliasResponse = new CreateAliasResponse($aRequest);
43		$this->assertEquals($aRequest['orderID'], $createAliasResponse->getParam('orderid'));
44		}
45
46		/** @test */
47		public function ChecksStatus()
48		{
49		$aRequest = $this->provideRequest();
50
51		$createAliasResponse = new CreateAliasResponse($aRequest);
52		$this->assertTrue($createAliasResponse->isSuccessful());
53		}
54
55		/** @test */
56		public function AliasIsEqual()
57		{
58		$aRequest = $this->provideRequest();
59		$createAliasResponse = new CreateAliasResponse($aRequest);
60		$alias = $createAliasResponse->getAlias();
61		$this->assertEquals('customer_123', $alias->__toString());
62		$this->assertEquals($aRequest['CN'], $alias->getCardName());
63		$this->assertEquals($aRequest['CARDNO'], $alias->getCardNumber());
64		$this->assertEquals($aRequest['ED'], $alias->getExpiryDate());
65		}
66
67		/**
68		* Helper method to setup a request array
69		*/
70		private function provideRequest()
71		{
72		return array(
73		'SHASIGN' => FakeShaComposer::FAKESHASTRING,
74		'UNKNOWN_PARAM' => false, /* unkown parameter, should be filtered out */
75		'status' => 0,
76		'orderID' => '48495482424',
77		'alias' => 'customer_123',
78		'CN' => 'John Doe',
79		'CARDNO' => 'xxxxxxxxxxx4848',
80		'ED' => '1220'
81		);
82		}
83		}
84

marlon-be / marlon-ogone

GitHub Access Token became invalid

Pull Request — master (#62)

CreateAliasResponseTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like