GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — master (#62)
by Jelte
04:52
created

SubscriptionPeriod   A

Complexity

Total Complexity 22

Size/Duplication

Total Lines 140
Duplicated Lines 11.43 %

Coupling/Cohesion

Components 1
Dependencies 0

Importance

Changes 2
Bugs 1 Features 1
Metric Value
wmc 22
c 2
b 1
f 1
lcom 1
cbo 0
dl 16
loc 140
rs 10

7 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 6 1
A getUnit() 0 4 1
B setUnit() 7 15 6
A getInterval() 0 4 1
A setInterval() 0 13 4
A getMoment() 0 4 1
C setMoment() 9 24 8

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Ogone\Subscription;
4
5
use InvalidArgumentException;
6
7
class SubscriptionPeriod
8
{
9
10
    /** @var string */
11
    const UNIT_DAILY = 'd';
12
13
    /** @var string */
14
    const UNIT_WEEKLY = 'ww';
15
16
    /** @var string */
17
    const UNIT_MONTHLY = 'm';
18
19
    /**
20
     * @var string
21
     * ‘d’ = daily, ‘ww’ = weekly, ‘m’ = monthly
22
     */
23
    protected $unit;
24
25
    /**
26
     * @var int
27
     * Interval between each occurrence of the subscription payments
28
     */
29
    protected $interval;
30
31
    /**
32
     * @var int
33
     * Depending on sub_period_unit
34
     * Daily (d):
35
     *      interval in days
36
     * Weekly (ww):
37
     *      1=Sunday, … 7=Saturday
38
     * Monthly (m):
39
     *      day of the month
40
     */
41
    protected $moment;
42
43
    /**
44
     * @param string $unit
45
     * @param int $interval
46
     * @param int $moment
47
     * @throws InvalidArgumentException
48
     */
49
    public function __construct($unit, $interval, $moment)
50
    {
51
        $this->setUnit($unit);
52
        $this->setInterval($interval);
53
        $this->setMoment($moment);
54
    }
55
56
    /**
57
     * @return string
58
     */
59
    public function getUnit()
60
    {
61
        return $this->unit;
62
    }
63
64
    /**
65
     * @param string $unit
66
     * @throws InvalidArgumentException
67
     */
68
    public function setUnit($unit)
69
    {
70
        if (!in_array($unit, array(self::UNIT_DAILY, self::UNIT_WEEKLY, self::UNIT_MONTHLY))) {
71
            throw new InvalidArgumentException("Subscription period unit should be '".self::UNIT_DAILY."' (daily), '".self::UNIT_WEEKLY."' (weekly) or '".self::UNIT_MONTHLY."' (monthly)");
72
        }
73
74 View Code Duplication
        if (self::UNIT_WEEKLY === $unit) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
75
            if ($this->moment > 7) {
76
                throw new InvalidArgumentException('The unit cannot be set to weekly while the moment > 7');
77
            }
78
        } elseif (self::UNIT_MONTHLY === $unit && $this->moment > 28) {
79
            throw new InvalidArgumentException('The unit cannot be set to monthly while the moment > 28');
80
        }
81
        $this->unit = $unit;
82
    }
83
84
    /**
85
     * @return int
86
     */
87
    public function getInterval()
88
    {
89
        return $this->interval;
90
    }
91
92
    /**
93
     * @param int $interval
94
     * @throws InvalidArgumentException
95
     */
96
    public function setInterval($interval)
97
    {
98
        if (!is_int($interval)) {
99
            throw new InvalidArgumentException("Integer expected for interval");
100
        }
101
        if ($interval < 0) {
102
            throw new InvalidArgumentException("Interval must be a positive number > 0");
103
        }
104
        if ($interval >= 1.0E+15) {
105
            throw new InvalidArgumentException("Interval is too high");
106
        }
107
        $this->interval = $interval;
108
    }
109
110
    /**
111
     * @return int
112
     */
113
    public function getMoment()
114
    {
115
        return $this->moment;
116
    }
117
118
    /**
119
     * @param int $moment
120
     * @throws InvalidArgumentException
121
     */
122
    public function setMoment($moment)
123
    {
124
        if (!is_int($moment)) {
125
            throw new InvalidArgumentException("Integer expected for moment");
126
        }
127
        if ($moment <= 0) {
128
            throw new InvalidArgumentException("Moment must be a positive number");
129
        }
130
        if ($moment >= 1.0E+15) {
131
            throw new InvalidArgumentException("Interval is too high");
132
        }
133
134 View Code Duplication
        if (self::UNIT_WEEKLY == $this->unit) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
135
            // Valid values are 1 to 7
136
            if ($moment > 7) {
137
                throw new InvalidArgumentException("Moment should be 1 (Sunday), 2, 3 .. 7 (Saturday)");
138
            }
139
        } elseif (self::UNIT_MONTHLY == $this->unit && $moment > 28) {
140
            // We will not allow a day of month > 28
141
            throw new InvalidArgumentException("Moment can't be larger than 29. Last day for month allowed is 28.");
142
        }
143
144
        $this->moment = $moment;
145
    }
146
}
147