SubscriptionPaymentRequestTest::createSubscriptionRequest() - Code Metrics - Inspection of "Merge pull request #62 from marlon-be/refactor/cle..." - marlon-be/marlon-ogone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3bb2ca...deaed9 )

by Jelte

created 2016-05-07 10:31 UTC

createSubscriptionRequest() A

↳ Parent: SubscriptionPaymentRequestTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php

namespace Ogone\Tests\Subscription;

use Ogone\Subscription\SubscriptionPaymentRequest;
use Ogone\Subscription\SubscriptionPeriod;
use Ogone\Tests\ShaComposer\FakeShaComposer;

class SubscriptionPaymentRequestTest extends \PHPUnit_Framework_TestCase
{

    /** @test */
    public function AmountCanBeZero()
    {
        $paymentRequest = $this->createSubscriptionRequest();
        $paymentRequest->setAmount(0);
        $this->assertEquals(0, $paymentRequest->getAmount());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * @test
     * @dataProvider provideBadParameters
     * @expectedException \InvalidArgumentException
     */
    public function BadParametersCauseExceptions($method, $value)
    {
        $paymentRequest = $this->createSubscriptionRequest();
        $paymentRequest->$method($value);
    }

    /**
     * @test
     * @expectedException \RuntimeException
     */
    public function IsInvalidIfSubscriptionParametersAreMissing()
    {
        $paymentRequest = $this->createSubscriptionRequest();
        $paymentRequest->setPspid('12');
        $paymentRequest->setCurrency('EUR');
        $paymentRequest->setAmount(0);
        $paymentRequest->setOrderId('10');
        $paymentRequest->validate();
    }

    /** @test */
    public function RequestCanBeValid()
    {
        $paymentRequest = $this->createSubscriptionRequest();
        $paymentRequest->setPspid('12');
        $paymentRequest->setCurrency('EUR');
        $paymentRequest->setAmount(0);
        $paymentRequest->setOrderId('10');
        $paymentRequest->setSubscriptionId('12');
        $paymentRequest->setSubscriptionAmount(13);
        $paymentRequest->setSubscriptionComment('test');
        $paymentRequest->setSubscriptionDescription('description');
        $paymentRequest->setSubscriptionOrderId('13');
        $paymentRequest->setSubscriptionPeriod($this->createSubscriptionPeriod());
        $paymentRequest->setSubscriptionStartdate(new \DateTime());
        $paymentRequest->setSubscriptionEnddate(new \DateTime());
        $paymentRequest->setSubscriptionStatus(1);
        $paymentRequest->validate();
        $this->assertTrue(true);
    }

    public function provideBadParameters()
    {

        return array(
            array('setAmount', 10.50),
            array('setAmount', -1),
            array('setAmount', 150000000000000000),
            array('setSubscriptionId', 'this is a little more than 50 characters, which is truly the max amount'),
            array('setSubscriptionId', '$e©ial Ch@r@cters'),
            array('setSubscriptionAmount', 10.50),
            array('setSubscriptionAmount', 0),
            array('setSubscriptionAmount', -1),
            array('setSubscriptionAmount', 150000000000000000),
            array('setSubscriptionDescription', 'this is a little more than 100 characters- which is truly the maximum amount of characters one can pass as a parameter to this particular function'),
            array('setSubscriptionDescription', 'special, characters!'),
            array('setSubscriptionOrderId', 'this is a little more than 40 characters- which is truly the max amount'),
            array('setSubscriptionOrderId', 'special, characters!'),
            array('setSubscriptionStatus', 5),
            array('setSubscriptionComment', 'this particular string is supposed to be longer than 200 characters- which will require me to type for quite a while longer than the string that needed to exceed 50 chars- which is- in fact- significantly lower than 200'),
            array('setSubscriptionComment', 'special, characters!')
        );
    }

    protected function createSubscriptionRequest()
    {
        return new SubscriptionPaymentRequest(new FakeShaComposer());
    }

    protected function createSubscriptionPeriod()
    {
        return new SubscriptionPeriod(SubscriptionPeriod::UNIT_DAILY, 12, 7);
    }
}


1			<?php
2
3			namespace Ogone\Tests\Subscription;
4
5			use Ogone\Subscription\SubscriptionPaymentRequest;
6			use Ogone\Subscription\SubscriptionPeriod;
7			use Ogone\Tests\ShaComposer\FakeShaComposer;
8
9			class SubscriptionPaymentRequestTest extends \PHPUnit_Framework_TestCase
10			{
11
12			/** @test */
13			public function AmountCanBeZero()
14			{
15			$paymentRequest = $this->createSubscriptionRequest();
16			$paymentRequest->setAmount(0);
17			$this->assertEquals(0, $paymentRequest->getAmount());
			0 ignored issues – show Documentation Bug introduced 2016-05-07 10:05 UTC by Report Bug Copy Issue Report The method `getAmount` does not exist on `object<Ogone\Subscriptio...criptionPaymentRequest>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
18			}
19
20			/**
21			* @test
22			* @dataProvider provideBadParameters
23			* @expectedException \InvalidArgumentException
24			*/
25			public function BadParametersCauseExceptions($method, $value)
26			{
27			$paymentRequest = $this->createSubscriptionRequest();
28			$paymentRequest->$method($value);
29			}
30
31			/**
32			* @test
33			* @expectedException \RuntimeException
34			*/
35			public function IsInvalidIfSubscriptionParametersAreMissing()
36			{
37			$paymentRequest = $this->createSubscriptionRequest();
38			$paymentRequest->setPspid('12');
39			$paymentRequest->setCurrency('EUR');
40			$paymentRequest->setAmount(0);
41			$paymentRequest->setOrderId('10');
42			$paymentRequest->validate();
43			}
44
45			/** @test */
46			public function RequestCanBeValid()
47			{
48			$paymentRequest = $this->createSubscriptionRequest();
49			$paymentRequest->setPspid('12');
50			$paymentRequest->setCurrency('EUR');
51			$paymentRequest->setAmount(0);
52			$paymentRequest->setOrderId('10');
53			$paymentRequest->setSubscriptionId('12');
54			$paymentRequest->setSubscriptionAmount(13);
55			$paymentRequest->setSubscriptionComment('test');
56			$paymentRequest->setSubscriptionDescription('description');
57			$paymentRequest->setSubscriptionOrderId('13');
58			$paymentRequest->setSubscriptionPeriod($this->createSubscriptionPeriod());
59			$paymentRequest->setSubscriptionStartdate(new \DateTime());
60			$paymentRequest->setSubscriptionEnddate(new \DateTime());
61			$paymentRequest->setSubscriptionStatus(1);
62			$paymentRequest->validate();
63			$this->assertTrue(true);
64			}
65
66			public function provideBadParameters()
67			{
68
69			return array(
70			array('setAmount', 10.50),
71			array('setAmount', -1),
72			array('setAmount', 150000000000000000),
73			array('setSubscriptionId', 'this is a little more than 50 characters, which is truly the max amount'),
74			array('setSubscriptionId', '$e©ial Ch@r@cters'),
75			array('setSubscriptionAmount', 10.50),
76			array('setSubscriptionAmount', 0),
77			array('setSubscriptionAmount', -1),
78			array('setSubscriptionAmount', 150000000000000000),
79			array('setSubscriptionDescription', 'this is a little more than 100 characters- which is truly the maximum amount of characters one can pass as a parameter to this particular function'),
80			array('setSubscriptionDescription', 'special, characters!'),
81			array('setSubscriptionOrderId', 'this is a little more than 40 characters- which is truly the max amount'),
82			array('setSubscriptionOrderId', 'special, characters!'),
83			array('setSubscriptionStatus', 5),
84			array('setSubscriptionComment', 'this particular string is supposed to be longer than 200 characters- which will require me to type for quite a while longer than the string that needed to exceed 50 chars- which is- in fact- significantly lower than 200'),
85			array('setSubscriptionComment', 'special, characters!')
86			);
87			}
88
89			protected function createSubscriptionRequest()
90			{
91			return new SubscriptionPaymentRequest(new FakeShaComposer());
92			}
93
94			protected function createSubscriptionPeriod()
95			{
96			return new SubscriptionPeriod(SubscriptionPeriod::UNIT_DAILY, 12, 7);
97			}
98			}
99

marlon-be / marlon-ogone

GitHub Access Token became invalid

Push — master ( 3bb2ca...deaed9 )

createSubscriptionRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like