Ogone\Tests\Ecommerce\EcommercePaymentResponseTest

Complexity

Total Complexity

11

Size/Duplication

Total Lines	118
Duplicated Lines	5.93 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	CanBeVerified()	0	7	1
A	CanBeConvertedToArray()	0	12	1
A	CannotExistWithoutShaSign()	0	4	1
A	ParametersCanBeRetrieved()	7	7	1
A	RequestIsFilteredFromNonOgoneParameters()	0	7	1
A	ChecksStatus()	0	7	1
A	AmountIsConvertedToCent()	0	7	1
A	provideFloats()	0	9	1
A	InvalidForInvalidCurrency()	0	5	1
A	CorrectlyConvertsFloatAmountsToInteger()	0	5	1
A	provideRequest()	0	10	1

<?php

/*
 * This file is part of the Marlon Ogone package.
 *
 * (c) Marlon BVBA <info@marlon.be>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Ogone\Tests\Ecommerce;

use Ogone\PaymentResponse;
use Ogone\Tests\ShaComposer\FakeShaComposer;
use Ogone\Ecommerce\EcommercePaymentResponse;
use InvalidArgumentException;

class EcommercePaymentResponseTest extends \PHPUnit_Framework_TestCase
{
    /** @test */
    public function CanBeVerified()
    {
        $aRequest = $this->provideRequest();

        $paymentResponse = new EcommercePaymentResponse($aRequest);
        $this->assertTrue($paymentResponse->isValid(new FakeShaComposer));
    }

    /** @test */
    public function CanBeConvertedToArray()
    {
        $aRequest = $this->provideRequest();

        $paymentResponse = new EcommercePaymentResponse($aRequest);
        $paymentResponse->isValid(new FakeShaComposer);
        $array = $paymentResponse->toArray();
        $this->assertArrayHasKey('ORDERID', $array);
        $this->assertArrayHasKey('STATUS', $array);
        $this->assertArrayHasKey('AMOUNT', $array);
        $this->assertArrayHasKey('SHASIGN', $array);
    }


    /**
     * @test
     * @expectedException InvalidArgumentException
    */
    public function CannotExistWithoutShaSign()
    {
        $paymentResponse = new EcommercePaymentResponse(array());

$paymentResponse is not used, you could remove the assignment.

    }

    /** @test */
    public function ParametersCanBeRetrieved()

This method seems to be duplicated in your project.

    {
        $aRequest = $this->provideRequest();

        $paymentResponse = new EcommercePaymentResponse($aRequest);
        $this->assertEquals($aRequest['orderID'], $paymentResponse->getParam('orderid'));
    }

    /**
     * @test
     * @expectedException InvalidArgumentException
     */
    public function RequestIsFilteredFromNonOgoneParameters()
    {
        $aRequest = $this->provideRequest();

        $paymentResponse = new EcommercePaymentResponse($aRequest);
        $paymentResponse->getParam('unknown_param');
    }

    /** @test */
    public function ChecksStatus()
    {
        $aRequest = $this->provideRequest();

        $paymentResponse = new EcommercePaymentResponse($aRequest);
        $this->assertTrue($paymentResponse->isSuccessful());
    }

    /** @test */
    public function AmountIsConvertedToCent()
    {
        $aRequest = $this->provideRequest();

        $paymentResponse = new EcommercePaymentResponse($aRequest);
        $this->assertEquals(100, $paymentResponse->getParam('amount'));
    }

    public function provideFloats()
    {
        return array(
            array('17.89', 1789),
            array('65.35', 6535),
            array('12.99', 1299),
            array('1.0', 100)
        );
    }

    /**
     * @test
     * @expectedException InvalidArgumentException
     */
    public function InvalidForInvalidCurrency()
    {
        $paymentResponse = new EcommercePaymentResponse(array('amount' => 'NaN', 'shasign' => '123'));
        $paymentResponse->getParam('amount');
    }

    /**
     * @test
     * @dataProvider provideFloats
     */
    public function CorrectlyConvertsFloatAmountsToInteger($string, $integer)
    {
        $paymentResponse = new EcommercePaymentResponse(array('amount' => $string, 'shasign' => '123'));
        $this->assertEquals($integer, $paymentResponse->getParam('amount'));
    }

    /**
     * Helper method to setup a request array
     */
    private function provideRequest()
    {
        return array(
            'orderID' => '123',
            'SHASIGN' => FakeShaComposer::FAKESHASTRING,
            'UNKNOWN_PARAM' => false, /* unkown parameter, should be filtered out */
            'status' => PaymentResponse::STATUS_AUTHORISED,
            'amount' => 1,
        );
    }
}