Ogone\DirectLink\DirectLinkQueryResponse

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	81.03 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	19	19	2
A	isSuccessful()	0	4	1
A	filterRequestParameters()	16	16	1
A	xmlAttributesToArray()	12	12	3

<?php
/*
 * @author Nicolas Clavaud <nicolas@lrqdo.fr>
 */

namespace Ogone\DirectLink;

use Ogone\AbstractPaymentResponse;
use SimpleXMLElement;
use InvalidArgumentException;

class DirectLinkQueryResponse extends AbstractPaymentResponse
{

    public function __construct($xml_string)

This method seems to be duplicated in your project.

    {
        libxml_use_internal_errors(true);

        if (simplexml_load_string($xml_string)) {
            $xmlResponse = new SimpleXMLElement($xml_string);

            $attributesArray = $this->xmlAttributesToArray($xmlResponse->attributes());

            // use lowercase internally
            $attributesArray = array_change_key_case($attributesArray, CASE_UPPER);

            // filter request for Ogone parameters
            $this->parameters = $this->filterRequestParameters($attributesArray);

        } else {
            throw new InvalidArgumentException("No valid XML-string given");
        }
    }

    public function isSuccessful()
    {
        return (0 == $this->getParam('NCERROR'));
    }

    protected function filterRequestParameters(array $httpRequest)

This method seems to be duplicated in your project.

    {
        return array_intersect_key(
            $httpRequest,
            array_flip(
                array_merge(
                    $this->ogoneFields,
                    array(
                        'PAYIDSUB',
                        'NCSTATUS',
                        'NCERRORPLUS',
                    )
                )
            )
        );
    }

    private function xmlAttributesToArray($attributes)

This method seems to be duplicated in your project.

    {
        $attributesArray = array();

        if (count($attributes)) {
            foreach ($attributes as $key => $value) {
                $attributesArray[(string)$key] = (string)$value;
            }
        }

        return $attributesArray;
    }
}