Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | class DirectLinkPaymentRequest extends AbstractPaymentRequest |
||
18 | { |
||
19 | |||
20 | const TEST = "https://secure.ogone.com/ncol/test/orderdirect.asp"; |
||
21 | const PRODUCTION = "https://secure.ogone.com/ncol/prod/orderdirect.asp"; |
||
22 | |||
23 | 8 | public function __construct(ShaComposer $shaComposer) |
|
28 | |||
29 | 5 | public function getRequiredFields() |
|
35 | |||
36 | 2 | public function getValidOgoneUris() |
|
40 | |||
41 | 6 | View Code Duplication | public function setUserId($userid) |
48 | |||
49 | /** Alias for setPswd() */ |
||
50 | 5 | public function setPassword($password) |
|
54 | |||
55 | 6 | public function setPswd($password) |
|
62 | |||
63 | 1 | public function setAlias(Alias $alias) |
|
67 | |||
68 | public function setEci(Eci $eci) |
||
72 | |||
73 | public function setCvc($cvc) |
||
77 | |||
78 | protected function getValidOperations() |
||
87 | } |
||
88 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.