Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | abstract class AbstractDirectLinkRequest extends AbstractRequest |
||
11 | { |
||
12 | |||
13 | 9 | View Code Duplication | public function setUserId($userid) |
20 | |||
21 | 9 | public function setPassword($password) |
|
28 | |||
29 | 7 | public function setPayId($payid) |
|
33 | |||
34 | public function setOrderId($orderid) |
||
38 | |||
39 | 2 | protected function getRequiredFieldGroups() |
|
45 | } |
||
46 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.