DateUtil::getDateFormat() - Code Metrics - Inspection of "Fix code style." - markuspoerschke/iCal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7fad79...963e22 )

by Markus

created 2016-04-26 12:08 UTC

DateUtil::getDateFormat() B

↳ Parent: DateUtil

Complexity

Conditions	5
Paths	4

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	5.3906

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	9
ccs	3
cts	4
cp	0.75
rs	8.8571
cc	5
eloc	4
nc	4
nop	3
crap	5.3906

<?php

namespace Eluceo\iCal\Util;

class DateUtil
{
    public static function getDefaultParams(\DateTime $dateTime = null, $noTime = false, $useTimezone = false)
    {
        $params = array();

        if ($useTimezone) {
            $timeZone       = $dateTime->getTimezone()->getName();
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
            $params['TZID'] = $timeZone;
        }

        if ($noTime) {
            $params['VALUE'] = 'DATE';
        }

        return $params;
    }

    /**
     * Returns a formatted date string.
     *
     * @param \DateTime|null $dateTime    The DateTime object
     * @param bool           $noTime      Indicates if the time will be added
     * @param bool           $useTimezone
     * @param bool           $useUtc
     *
     * @return mixed
     */
    public static function getDateString(\DateTime $dateTime = null, $noTime = false, $useTimezone = false, $useUtc = false)
    {
        if (empty($dateTime)) {
            $dateTime = new \DateTime();
        }

        return $dateTime->format(self::getDateFormat($noTime, $useTimezone, $useUtc));
    }

    /**
     * Returns the date format that can be passed to DateTime::format().
     *
     * @param bool $noTime      Indicates if the time will be added
     * @param bool $useTimezone
     * @param bool $useUtc
     *
     * @return string
     */
    public static function getDateFormat($noTime = false, $useTimezone = false, $useUtc = false)
    {
        // Do not use UTC time (Z) if timezone support is enabled.
        if ($useTimezone || !$useUtc) {
            return $noTime ? 'Ymd' : 'Ymd\THis';
        }

        return $noTime ? 'Ymd' : 'Ymd\THis\Z';
    }
}


1		<?php
2
3		namespace Eluceo\iCal\Util;
4
5		class DateUtil
6		{
7	4	public static function getDefaultParams(\DateTime $dateTime = null, $noTime = false, $useTimezone = false)
8		{
9	4	$params = array();
10
11	4	if ($useTimezone) {
12		$timeZone = $dateTime->getTimezone()->getName();
		0 ignored issues – show Bug introduced 2015-12-04 09:21 UTC by Report Bug Copy Issue Report It seems like `$dateTime` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
13		$params['TZID'] = $timeZone;
14		}
15
16	4	if ($noTime) {
17		$params['VALUE'] = 'DATE';
18		}
19
20	4	return $params;
21		}
22
23		/**
24		* Returns a formatted date string.
25		*
26		* @param \DateTime\|null $dateTime The DateTime object
27		* @param bool $noTime Indicates if the time will be added
28		* @param bool $useTimezone
29		* @param bool $useUtc
30		*
31		* @return mixed
32		*/
33	4	public static function getDateString(\DateTime $dateTime = null, $noTime = false, $useTimezone = false, $useUtc = false)
34		{
35	4	if (empty($dateTime)) {
36	2	$dateTime = new \DateTime();
37		}
38
39	4	return $dateTime->format(self::getDateFormat($noTime, $useTimezone, $useUtc));
40		}
41
42		/**
43		* Returns the date format that can be passed to DateTime::format().
44		*
45		* @param bool $noTime Indicates if the time will be added
46		* @param bool $useTimezone
47		* @param bool $useUtc
48		*
49		* @return string
50		*/
51	4	public static function getDateFormat($noTime = false, $useTimezone = false, $useUtc = false)
52		{
53		// Do not use UTC time (Z) if timezone support is enabled.
54	4	if ($useTimezone \|\| !$useUtc) {
55		return $noTime ? 'Ymd' : 'Ymd\THis';
56		}
57
58	4	return $noTime ? 'Ymd' : 'Ymd\THis\Z';
59		}
60		}
61

markuspoerschke / iCal

Push — master ( 7fad79...963e22 )

DateUtil::getDateFormat() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like