PropertyBag::get() - Code Metrics - Inspection of "cleanup parameter bag" - markuspoerschke/iCal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( 8c7a9a...c7de71 )

by Markus

created 2016-04-26 17:09 UTC

PropertyBag::get() A

↳ Parent: PropertyBag

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
cc	3
eloc	4
nc	3
nop	1
crap	3

<?php

/*
 * This file is part of the eluceo/iCal package.
 *
 * (c) Markus Poerschke <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Eluceo\iCal;

class PropertyBag implements \IteratorAggregate
{
    /**
     * @var array
     */
    protected $elements = [];

    /**
     * Creates a new Property with $name, $value and $params.
     *
     * @deprecated The property bag should not be used as a property factory. Use `$this->add` instead.
     *
     * @param       $name
     * @param       $value
     * @param array $params
     *
     * @return $this
     */
    public function set($name, $value, $params = [])
    {
        $this->add(new Property($name, $value, $params));
    }

    /**
     * Adds a Property. If Property already exists an Exception will be thrown.
     *
     * @param Property $property
     *
     * @return $this
     *
     * @throws \Exception
     */
    public function add(Property $property)
    {
        $name = $property->getName();

        if (isset($this->elements[$name])) {
            throw new \Exception("Property with name '{$name}' already exists");
        }

        $this->elements[$name] = $property;
    }

    /**
     * @return \ArrayObject
     */
    public function getIterator()
    {
        return new \ArrayObject($this->elements);
    }
}


1		<?php
2
3		/*
4		* This file is part of the eluceo/iCal package.
5		*
6		* (c) Markus Poerschke <[email protected]>
7		*
8		* This source file is subject to the MIT license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Eluceo\iCal;
13
14		class PropertyBag implements \IteratorAggregate
15		{
16		/**
17		* @var array
18		*/
19		protected $elements = [];
20
21		/**
22		* Creates a new Property with $name, $value and $params.
23		*
24		* @deprecated The property bag should not be used as a property factory. Use `$this->add` instead.
25		*
26		* @param $name
27		* @param $value
28		* @param array $params
29		*
30		* @return $this
31		*/
32	4	public function set($name, $value, $params = [])
33		{
34	4	$this->add(new Property($name, $value, $params));
35	4	}
36
37		/**
38		* Adds a Property. If Property already exists an Exception will be thrown.
39		*
40		* @param Property $property
41		*
42		* @return $this
43		*
44		* @throws \Exception
45		*/
46	5	public function add(Property $property)
47		{
48	5	$name = $property->getName();
49
50	5	if (isset($this->elements[$name])) {
51	1	throw new \Exception("Property with name '{$name}' already exists");
52		}
53
54	5	$this->elements[$name] = $property;
55	5	}
56
57		/**
58		* @return \ArrayObject
59		*/
60	4	public function getIterator()
61		{
62	4	return new \ArrayObject($this->elements);
63		}
64		}
65

markuspoerschke / iCal

Push — 1.x ( 8c7a9a...c7de71 )

PropertyBag::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like