MarkSitko\LaravelUnsplash\Unsplash

Complexity

Total Complexity

14

Size/Duplication

Total Lines	169
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	__get()	0	6	2
A	get()	0	6	1
A	toJson()	0	6	1
A	toArray()	0	6	1
A	toCollection()	0	6	1
A	store()	0	31	5
A	buildResponse()	0	7	1
A	initalizeConfiguration()	0	7	1

<?php

namespace MarkSitko\LaravelUnsplash;

use Exception;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Str;
use MarkSitko\LaravelUnsplash\API\UnsplashAPI;
use MarkSitko\LaravelUnsplash\Http\HttpClient;
use MarkSitko\LaravelUnsplash\Models\UnsplashAsset;

class Unsplash extends HttpClient
{
    use UnsplashAPI;

    /**
     * Accepted url keys from response.
     */
    const PHOTO_KEYS = [
        'raw',
        'full',
        'regular',
        'small',
        'thumb',
    ];

    /**
     * Storage disk to store photos.
     */
    protected $storage;

    /**
     * Guzzle response.
     */
    protected $response;

    /**
     * Storage disk to store photos.
     */
    protected $storeInDatabase;

    /**
     * Creates a new instance of Unsplash.
     *
     * @return MarkSitko\LaravelUnsplash\Unsplash

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();

        $this->initalizeConfiguration();

        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    /**
     * Checks if the accessed property exists as a method
     * if exists, call the get() method and return the complete response.
     */
    public function __get($param)
    {
        if (method_exists($this, $param)) {
            return $this->$param()->get();
        }
    }

    /**
     * Returns the full http response.
     *
     * @return GuzzleHttp\Psr7\Response
     */
    public function get()
    {
        $this->buildResponse();

        return $this->response;
    }

    /**
     * Returns the http response body.
     *
     * @return object
     */
    public function toJson()
    {
        $this->buildResponse();

        return json_decode($this->response->getBody()->getContents());
    }

    /**
     * Returns the http response body.
     *
     * @return array
     */
    public function toArray()
    {
        $this->buildResponse();

        return json_decode($this->response->getBody()->getContents(), true);
    }

    /**
     * Returns the http response body as collection.
     *
     * @return \Illuminate\Support\Collection
     */
    public function toCollection()
    {
        $this->buildResponse();

        return collect(json_decode($this->response->getBody()->getContents(), true));
    }

    /**
     * Stores the retrieving photo in the storage.
     *
     * @param string $name If no name is provided, a random 24 Charachter name will be generated
     * @param string $key  Defines the size of the retrieving photo
     *
     * @return string The stored photo name
     */
    public function store($name = null, $key = 'small')
    {
        $response = $this->toArray();
        if (!array_key_exists('urls', $response)) {
            throw new Exception('Photo can not be stored. Certainly the "urls" key is missing or you try to store an photo while retrieving multiple photos.');
        }

        if (!in_array($key, self::PHOTO_KEYS)) {
            throw new Exception("Your provided key \"{$key}\" is an undefined accessor.");
        }

        $name = $name ?? Str::random(24);
        $image = file_get_contents($response['urls'][$key]);

        while ($this->storage->exists("{$name}.jpg")) {
            $name = Str::random(24);
        }

        $this->storage->put("{$name}.jpg", $image);

        if ($this->storeInDatabase) {
            return UnsplashAsset::create([
                'unsplash_id' => $response['id'],
                'name' => "{$name}.jpg",
                'author' => $response['user']['name'],
                'author_link' => $response['user']['links']['html'],
            ]);
        }

        return $name;
    }

    /**
     * Builds the http request.
     *
     * @return MarkSitko\LaravelUnsplash\Unsplash
     */
    protected function buildResponse()
    {
        $verb = $this->apiCall['verb'] ?? 'get';
        $this->response = $this->client->$verb("{$this->apiCall['endpoint']}?{$this->getQuery()}");

        return $this;
    }

    /**
     * Initalize storage.
     *
     * @return MarkSitko\LaravelUnsplash\Unsplash
     */
    private function initalizeConfiguration()

Consider using a different method name as you override a private method of the parent class.

    {
        $this->storage = Storage::disk(config('unsplash.disk', 'local'));
        $this->storeInDatabase = config('unsplash.store_in_database', false);

        return $this;
    }
}