MarkSitko\LaravelUnsplash\Http\HttpClient

Complexity

Total Complexity

4

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	initalizeConfiguration()	0	10	2
A	createClient()	0	12	1

<?php

namespace MarkSitko\LaravelUnsplash\Http;

use Exception;
use GuzzleHttp\Client;

class HttpClient
{
    const API_URL = 'https://api.unsplash.com/';

    protected $client;

    private $accessKey;

    /**
    * Creates a new instance of HttpClient
    * @return MarkSitko\LaravelUnsplash\Http\HttpClient

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

    */
    public function __construct()
    {
        $this->initalizeConfiguration()
            ->createClient();

        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    /**
     * Initalize and store configuration values in class properties
     * @return MarkSitko\LaravelUnsplash\Http\HttpClient
     */
    private function initalizeConfiguration()
    {
        $this->accessKey = config('unsplash.access_key');

        if ( !$this->accessKey ) {
            throw new Exception('A Unsplash-API access key must be provided');
        }

        return $this;
    }

    /**
     * Instantiate the GuzzleHttp Client
     * @return MarkSitko\LaravelUnsplash\Http\HttpClient
     */
    private function createClient()
    {
        $this->client = new Client([
            'base_uri' => self::API_URL,
            'headers' => [
                'Content-Type' => 'application/x-www-form-urlencoded',
                'Authorization' => "Client-ID {$this->accessKey}",
            ],
        ]);

        return $this;
    }
}