markoheijnen / tabify-edit-screen

inc/tabs.php

<?php

class Tabify_Edit_Screen_Tabs {
	private $base_url = '';
	private $get_arg = 'tab';

	private $active = '';

	private $items  = array();
	private $type;
	private $javascript_support;

	/**
	 * Construct method to set up all internal properties
	 *
	 * @param array $items List of all items
	 * @param string $type How to be displayed: vertical of horizontal
	 * @param string $get_arg Which get argument should be used
	 * @param boolean $javascript_support With page refresh or not
	 *
	 * @since 0.1.0
	 */
	public function __construct( $items, $type = 'horizontal', $get_arg = 'tab', $javascript_support = true ) {
		if ( is_array( $items ) ) {

The condition is_array($items) is always true.

			$this->items              = apply_filters( 'tabify_tabs', $items, $this, $type );
			$this->type               = $type;
			$this->get_arg            = $get_arg;
			$this->javascript_support = $javascript_support;

			if ( isset( $_REQUEST[ $this->get_arg ] ) ) {
				$this->active = sanitize_text_field( $_REQUEST[ $this->get_arg ] );
			}

			$this->base_url = remove_query_arg( $this->get_arg, $_SERVER["REQUEST_URI"] );

			if ( empty( $this->active ) || ! isset( $items[ $this->active ] ) ) {
				$this->active = key( $items );
			}
		}
	}

	/**
	 * Get the current tab
	 *
	 * @return string Current tab name
	 *
	 * @since 0.1.0
	 */
	public function get_current_tab() {
		return $this->active;

The expression return $this->active also could return the type mixed which is incompatible with the documented return type string.

	}

	/**
	 * Get the HTML code of the tabs container including the tabs
	 *
	 * @return string The HTML of the tabs
	 *
	 * @since 0.1.0
	 */
	public function get_tabs_with_container() {
		$class = 'tabify-tabs tab-' .  $this->type;

		if ( ! $this->javascript_support ) {
			$class .= ' js-disabled';
		}

		$return  = '<div class="' . $class . '">';


		if ( 'horizontal' == $this->type ) {
			$return .= '<h2 class="nav-tab-wrapper">';
		}
		else {
			$return .= '<h2>';
		}

		$return .= $this->get_tabs_current_tab_input();
		$return .= $this->get_tabs();

		$return .= '</h2>';

		$return .= apply_filters( 'tabify_tabs_under', '', $this->type );

		$return .= '</div>';

		//When tabs are requested also enqueue the javascript and css code
		$required = array( 'jquery' );

		if ( 'post' == get_current_screen()->base ) {

Are you sure the usage of get_current_screen() is correct as it seems to always return null.

			$required[] = 'postbox';
		}

		$suffix = SCRIPT_DEBUG ? '' : '.min';

		wp_register_script( 'tabify-edit-screen', plugins_url( '/js/tabs' . $suffix . '.js', dirname( __FILE__ ) ), $required, '1.0' );
		wp_register_style( 'tabify-edit-screen', plugins_url( '/css/tabs' . $suffix . '.css', dirname( __FILE__ ) ), array(), '1.0' );

		wp_enqueue_script( 'tabify-edit-screen' );
		wp_enqueue_style( 'tabify-edit-screen' );

		$this->add_active_state_style();

		return $return;
	}

	/**
	 * Update switch background color for active state
	 *
	 * @since 0.9.6
	 */
	private function add_active_state_style() {
		global $_wp_admin_css_colors;

		$color = get_user_option('admin_color');

		if ( empty( $color ) || ! isset($_wp_admin_css_colors[ $color ] ) ) {
			$color = 'fresh';
		}

		$background = $_wp_admin_css_colors[$color]->colors[3];

		wp_add_inline_style(
			'tabify-edit-screen',
			'.switch-checkbox:checked + .switch-label { background: ' . $background . '; }'
		);
	}

	/**
	 * Get the hidden input code for current tab
	 *
	 * @return string The HTML of the hidden input field
	 *
	 * @since 0.2.0
	 */
	public function get_tabs_current_tab_input() {
		return '<input type="hidden" class="current_tab" name="' . $this->get_arg . '" value="' . $this->active . '" />';
	}

	/**
	 * Get the HTML code of all the tabs
	 *
	 * @return string The HTML of the hidden input field
	 *
	 * @since 0.1.0
	 */
	private function get_tabs() {
		$return = '';

		foreach ( $this->items as $key => $args ) {
			if ( ! is_array( $args ) ) {
				$args = array(
					'title' => $args
				);
			}

			$title   = apply_filters( 'tabify_tabs_tab_title', $args['title'], $args, $this );
			$url     = esc_url( add_query_arg( $this->get_arg, $key, $this->base_url ) );
			$classes = 'tabify-tab nav-tab';

			if ( $this->active == $key ) {
				$classes .= ' nav-tab-active';
			}

			$return .= '<a id="tab-' . $key . '" href="' . $url . '" class="' . $classes . '">' . $title . '</a>';
		}

		return $return;
	}

}