markguinn / silverstripe-shop-search

code/adapters/ShopSearchMysql.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
      * @param string $sort [optional]
      * @return ArrayData
      */
-    public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='')
+    public function searchFromVars($keywords, array $filters = array(), array $facetSpec = array(), $start = -1, $limit = -1, $sort = '')
     {
         $searchable = ShopSearch::get_searchable_classes();
         $matches = new ArrayList;

Indentation +65 added lines, -65 removed lines

@@ -9,81 +9,81 @@
  */
 class ShopSearchMysql extends Object implements ShopSearchAdapter
 {
-    /**
-     * @param string $keywords
-     * @param array $filters [optional]
-     * @param array $facetSpec [optional]
-     * @param int $start [optional]
-     * @param int $limit [optional]
-     * @param string $sort [optional]
-     * @return ArrayData
-     */
-    public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='')
-    {
-        $searchable = ShopSearch::get_searchable_classes();
-        $matches = new ArrayList;
+	/**
+	 * @param string $keywords
+	 * @param array $filters [optional]
+	 * @param array $facetSpec [optional]
+	 * @param int $start [optional]
+	 * @param int $limit [optional]
+	 * @param string $sort [optional]
+	 * @return ArrayData
+	 */
+	public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='')
+	{
+		$searchable = ShopSearch::get_searchable_classes();
+		$matches = new ArrayList;
 
-        foreach ($searchable as $className) {
-            $list = DataObject::get($className);
+		foreach ($searchable as $className) {
+			$list = DataObject::get($className);
 
-            // get searchable fields
-            $keywordFields = $this->getSearchFields($className);
+			// get searchable fields
+			$keywordFields = $this->getSearchFields($className);
 
-            // build the filter
-            $filter = array();
+			// build the filter
+			$filter = array();
 
-            // Use parametrized query if SilverStripe >= 3.2
-            if (SHOP_SEARCH_IS_SS32) {
-                foreach ($keywordFields as $indexFields) {
-                    $filter[] = array("MATCH ($indexFields) AGAINST (?)" => $keywords);
-                }
-                $list = $list->whereAny($filter);
-            } else {
-                foreach ($keywordFields as $indexFields) {
-                    $filter[] = sprintf("MATCH ($indexFields) AGAINST ('%s')", Convert::raw2sql($keywords));
-                }
-                // join all the filters with an "OR" statement
-                $list = $list->where(implode(' OR ', $filter));
-            }
+			// Use parametrized query if SilverStripe >= 3.2
+			if (SHOP_SEARCH_IS_SS32) {
+				foreach ($keywordFields as $indexFields) {
+					$filter[] = array("MATCH ($indexFields) AGAINST (?)" => $keywords);
+				}
+				$list = $list->whereAny($filter);
+			} else {
+				foreach ($keywordFields as $indexFields) {
+					$filter[] = sprintf("MATCH ($indexFields) AGAINST ('%s')", Convert::raw2sql($keywords));
+				}
+				// join all the filters with an "OR" statement
+				$list = $list->where(implode(' OR ', $filter));
+			}
 
-            // add in any other filters
-            $list = FacetHelper::inst()->addFiltersToDataList($list, $filters);
+			// add in any other filters
+			$list = FacetHelper::inst()->addFiltersToDataList($list, $filters);
 
-            // add any matches to the big list
-            $matches->merge($list);
-        }
+			// add any matches to the big list
+			$matches->merge($list);
+		}
 
-        return new ArrayData(array(
-            'Matches'   => $matches,
-            'Facets'    => FacetHelper::inst()->buildFacets($matches, $facetSpec, (bool)Config::inst()->get('ShopSearch', 'auto_facet_attributes')),
-        ));
-    }
+		return new ArrayData(array(
+			'Matches'   => $matches,
+			'Facets'    => FacetHelper::inst()->buildFacets($matches, $facetSpec, (bool)Config::inst()->get('ShopSearch', 'auto_facet_attributes')),
+		));
+	}
 
 
-    /**
-     * @param $className
-     * @return array an array containing fields per index
-     * @throws Exception
-     */
-    protected function getSearchFields($className)
-    {
-        $indexes = Config::inst()->get($className, 'indexes');
+	/**
+	 * @param $className
+	 * @return array an array containing fields per index
+	 * @throws Exception
+	 */
+	protected function getSearchFields($className)
+	{
+		$indexes = Config::inst()->get($className, 'indexes');
 
-        $indexList = array();
-        foreach ($indexes as $name => $index) {
-            if (is_array($index)) {
-                if (!empty($index['type']) && $index['type'] == 'fulltext' && !empty($index['value'])) {
-                    $indexList[] = trim($index['value']);
-                }
-            } elseif (preg_match('/fulltext\((.+)\)/', $index, $m)) {
-                $indexList[] = trim($m[1]);
-            }
-        }
+		$indexList = array();
+		foreach ($indexes as $name => $index) {
+			if (is_array($index)) {
+				if (!empty($index['type']) && $index['type'] == 'fulltext' && !empty($index['value'])) {
+					$indexList[] = trim($index['value']);
+				}
+			} elseif (preg_match('/fulltext\((.+)\)/', $index, $m)) {
+				$indexList[] = trim($m[1]);
+			}
+		}
 
-        if (count($indexList) === 0) {
-            throw new Exception("Class $className does not appear to have any fulltext indexes");
-        }
+		if (count($indexList) === 0) {
+			throw new Exception("Class $className does not appear to have any fulltext indexes");
+		}
 
-        return $indexList;
-    }
+		return $indexList;
+	}
 }

code/ShopSearchAjax.php

Indentation +18 added lines, -18 removed lines

@@ -9,22 +9,22 @@
  */
 class ShopSearchAjax extends Extension
 {
-    /**
-     * @param SS_HTTPRequest $request
-     * @param SS_HTTPResponse $response
-     * @param ArrayData $results
-     * @param array $data
-     */
-    public function updateSearchResultsResponse(&$request, &$response, $results, $data)
-    {
-        if ($request->isAjax() && $this->owner->hasExtension('AjaxControllerExtension')) {
-            if (!$response) {
-                $response = $this->owner->getAjaxResponse();
-            }
-            $response->addRenderContext('RESULTS', $results);
-            $response->pushRegion('SearchResults', $results);
-            $response->pushRegion('SearchHeader', $results);
-            $response->triggerEvent('searchresults');
-        }
-    }
+	/**
+	 * @param SS_HTTPRequest $request
+	 * @param SS_HTTPResponse $response
+	 * @param ArrayData $results
+	 * @param array $data
+	 */
+	public function updateSearchResultsResponse(&$request, &$response, $results, $data)
+	{
+		if ($request->isAjax() && $this->owner->hasExtension('AjaxControllerExtension')) {
+			if (!$response) {
+				$response = $this->owner->getAjaxResponse();
+			}
+			$response->addRenderContext('RESULTS', $results);
+			$response->pushRegion('SearchResults', $results);
+			$response->pushRegion('SearchHeader', $results);
+			$response->triggerEvent('searchresults');
+		}
+	}
 }

code/reports/SearchTermsReport.php

Indentation +29 added lines, -29 removed lines

@@ -9,35 +9,35 @@
  */
 class SearchTermsReport extends ShopPeriodReport
 {
-    protected $title = "Search Terms";
-    protected $description = "Understand what users are searching for.";
-    protected $dataClass = "SearchLog";
-    protected $periodfield = "SearchLog.Created";
+	protected $title = "Search Terms";
+	protected $description = "Understand what users are searching for.";
+	protected $dataClass = "SearchLog";
+	protected $periodfield = "SearchLog.Created";
 
-    public function columns()
-    {
-        return array(
-            "Query" => array(
-                "title" => "Query",
-                "formatting" => '<a href=\"home/SearchForm?q=$ATT_val($Query)\" target=\"_new\">$Query</a>'
-            ),
-            'NumResults' => 'Results',
-            'Quantity' => 'Searches',
-            'MostRecent' => 'Most Recent',
-        );
-    }
+	public function columns()
+	{
+		return array(
+			"Query" => array(
+				"title" => "Query",
+				"formatting" => '<a href=\"home/SearchForm?q=$ATT_val($Query)\" target=\"_new\">$Query</a>'
+			),
+			'NumResults' => 'Results',
+			'Quantity' => 'Searches',
+			'MostRecent' => 'Most Recent',
+		);
+	}
 
-    public function query($params)
-    {
-        $query = parent::query($params);
-        $query->selectField($this->periodfield, "FilterPeriod")
-            ->addSelect("SearchLog.Query")
-            ->selectField("Count(SearchLog.ID)", "Quantity")
-            ->selectField("Max(SearchLog.Created)", "MostRecent")
-            ->selectField("Max(SearchLog.NumResults)", "NumResults");
-        $query->addGroupby("SearchLog.Query");
-        $query->addWhere("\"SearchLog\".\"Filters\" is null AND \"SearchLog\".\"ParentSearchID\" = '0'");
-        $query->setOrderBy("Quantity", "DESC");
-        return $query;
-    }
+	public function query($params)
+	{
+		$query = parent::query($params);
+		$query->selectField($this->periodfield, "FilterPeriod")
+			->addSelect("SearchLog.Query")
+			->selectField("Count(SearchLog.ID)", "Quantity")
+			->selectField("Max(SearchLog.Created)", "MostRecent")
+			->selectField("Max(SearchLog.NumResults)", "NumResults");
+		$query->addGroupby("SearchLog.Query");
+		$query->addWhere("\"SearchLog\".\"Filters\" is null AND \"SearchLog\".\"ParentSearchID\" = '0'");
+		$query->setOrderBy("Quantity", "DESC");
+		return $query;
+	}
 }

code/ShopSearchForm.php

Indentation +141 added lines, -141 removed lines

@@ -8,145 +8,145 @@
  */
 class ShopSearchForm extends Form
 {
-    /** @var bool - setting this to true will remove the category dropdwon from the form */
-    private static $disable_category_dropdown = false;
-
-    /** @var string - this probably ought to be overridden with a vfi or solr facet unless you're products are only in one category */
-    private static $category_field = 'f[ParentID]';
-
-    /** @var string - setting to 'NONE' will mean the category dropdwon will have no empty option */
-    private static $category_empty_string = 'All Products';
-
-    /** @var int - how deep to list the categories for the dropdown */
-    private static $category_max_depth = 10;
-
-
-    /**
-     * @param Controller $controller
-     * @param String     $method
-     * @param string     $suggestURL
-     */
-    public function __construct($controller, $method, $suggestURL = '')
-    {
-        $searchField = TextField::create('q', '');
-        $searchField->setAttribute('placeholder', _t('ShopSearch.SEARCH', 'Search'));
-        if ($suggestURL) {
-            $searchField->setAttribute('data-suggest-url', $suggestURL);
-        }
-
-        $fields = FieldList::create($searchField);
-        if (!self::config()->disable_category_dropdown) {
-            $cats     = ShopSearch::get_category_hierarchy(0, '', self::config()->category_max_depth);
-            $catField = DropdownField::create(self::get_category_field(), '', $cats, Session::get('LastSearchCatID'));
-
-            $emptyString = self::config()->category_empty_string;
-            if ($emptyString !== 'NONE') {
-                $catField->setEmptyString(_t('ShopSearch.'.$emptyString, $emptyString));
-            }
-
-            $fields->push($catField);
-        }
-
-        parent::__construct($controller, $method, $fields, FieldList::create(array(FormAction::create('results', _t('ShopSearch.GO', 'Go')))));
-
-        $this->setFormMethod('GET');
-        $this->disableSecurityToken();
-        if ($c = self::config()->css_classes) {
-            $this->addExtraClass($c);
-        }
-
-        Requirements::css(SHOP_SEARCH_FOLDER . '/css/ShopSearch.css');
-
-        if (Config::inst()->get('ShopSearch', 'suggest_enabled')) {
-            Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
-            Requirements::css(THIRDPARTY_DIR . '/jquery-ui-themes/smoothness/jquery-ui.css');
-            Requirements::javascript(SHOP_SEARCH_FOLDER . '/javascript/search.suggest.js');
-            Requirements::javascript(SHOP_SEARCH_FOLDER . '/javascript/search.js');
-        }
-    }
-
-
-    /**
-     * @return string
-     */
-    public static function get_category_field()
-    {
-        return Config::inst()->get('ShopSearchForm', 'category_field');
-    }
-
-
-    /**
-     * @param array $data
-     * @return mixed
-     */
-    public function results(array $data)
-    {
-        // do the search
-        $results  = ShopSearch::inst()->search($data);
-        $request  = $this->controller->getRequest();
-        $baseLink = $request->getURL(false);
-
-        // if there was only one category filter, remember it for the category dropdown to retain it's value
-        if (!ShopSearchForm::config()->disable_category_dropdown) {
-            $qs_filters  = (string)Config::inst()->get('ShopSearch', 'qs_filters');
-            $categoryKey = (string)ShopSearchForm::config()->category_field;
-
-            if (preg_match('/\[(.+)\]/', $categoryKey, $matches)) {
-                // get right of the f[] around the actual key if present
-                $categoryKey = $matches[1];
-            }
-
-            if (!empty($data[$qs_filters][$categoryKey])) {
-                $categoryID = $data[$qs_filters][$categoryKey];
-                if (is_numeric($categoryID)) {
-                    // If it's set in the dropdown it will just be a number
-                    // If it's set from the checkboxes it will be something like LIST~1,2,3,4
-                    // We only want to remember the value in the former case
-                    Session::set('LastSearchCatID', $categoryID);
-                }
-            } else {
-                // If they unchecked every value, then clear the dropdown as well
-                Session::clear('LastSearchCatID');
-            }
-        }
-
-        // add links for any facets
-        if ($results->Facets && $results->Facets->count()) {
-            $qs_ps      = (string)Config::inst()->get('ShopSearch', 'qs_parent_search');
-            $baseParams = array_merge($data, array($qs_ps => $results->SearchLogID));
-            unset($baseParams['url']);
-            $results->Facets = FacetHelper::inst()->insertFacetLinks($results->Facets, $baseParams, $baseLink);
-        }
-
-        // add a dropdown for sorting
-        $qs_sort    = (string)Config::inst()->get('ShopSearch', 'qs_sort');
-        $options    = Config::inst()->get('ShopSearch', 'sort_options');
-        $sortParams = array_merge($data, array($qs_sort => 'NEWSORTVALUE'));
-        unset($sortParams['url']);
-        $results->SortControl = DropdownField::create($qs_sort, ShopSearch::config()->sort_label, $options, $results->Sort)
-            ->setAttribute('data-url', $baseLink . '?' . http_build_query($sortParams));
-
-        // a little more output management
-        $results->Title = "Search Results";
-        $results->Results = $results->Matches; // this makes us compatible with the default search template
-
-        // Give a hook for the parent controller to format the results, for example,
-        // interpreting filters in a specific way to affect the title or content
-        // when no results are returned. Since this is domain-specific we just leave
-        // it up to the host app.
-        if ($this->controller->hasMethod('onBeforeSearchDisplay')) {
-            $this->controller->onBeforeSearchDisplay($results);
-        }
-
-        // give a hook for processing ajax requests through a different template (i.e. for returning only fragments)
-        $tpl = Config::inst()->get('ShopSearch', 'ajax_results_template');
-        if (!empty($tpl) && Director::is_ajax()) {
-            return $this->controller->customise($results)->renderWith($tpl);
-        }
-
-        // Give a hook for modifying the search responses
-        $this->controller->extend('updateSearchResultsResponse', $request, $response, $results, $data);
-
-        return $response ?: $this->controller->customise($results)->renderWith(array('ShopSearch_results', 'Page_results', 'Page'));
-    }
+	/** @var bool - setting this to true will remove the category dropdwon from the form */
+	private static $disable_category_dropdown = false;
+
+	/** @var string - this probably ought to be overridden with a vfi or solr facet unless you're products are only in one category */
+	private static $category_field = 'f[ParentID]';
+
+	/** @var string - setting to 'NONE' will mean the category dropdwon will have no empty option */
+	private static $category_empty_string = 'All Products';
+
+	/** @var int - how deep to list the categories for the dropdown */
+	private static $category_max_depth = 10;
+
+
+	/**
+	 * @param Controller $controller
+	 * @param String     $method
+	 * @param string     $suggestURL
+	 */
+	public function __construct($controller, $method, $suggestURL = '')
+	{
+		$searchField = TextField::create('q', '');
+		$searchField->setAttribute('placeholder', _t('ShopSearch.SEARCH', 'Search'));
+		if ($suggestURL) {
+			$searchField->setAttribute('data-suggest-url', $suggestURL);
+		}
+
+		$fields = FieldList::create($searchField);
+		if (!self::config()->disable_category_dropdown) {
+			$cats     = ShopSearch::get_category_hierarchy(0, '', self::config()->category_max_depth);
+			$catField = DropdownField::create(self::get_category_field(), '', $cats, Session::get('LastSearchCatID'));
+
+			$emptyString = self::config()->category_empty_string;
+			if ($emptyString !== 'NONE') {
+				$catField->setEmptyString(_t('ShopSearch.'.$emptyString, $emptyString));
+			}
+
+			$fields->push($catField);
+		}
+
+		parent::__construct($controller, $method, $fields, FieldList::create(array(FormAction::create('results', _t('ShopSearch.GO', 'Go')))));
+
+		$this->setFormMethod('GET');
+		$this->disableSecurityToken();
+		if ($c = self::config()->css_classes) {
+			$this->addExtraClass($c);
+		}
+
+		Requirements::css(SHOP_SEARCH_FOLDER . '/css/ShopSearch.css');
+
+		if (Config::inst()->get('ShopSearch', 'suggest_enabled')) {
+			Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
+			Requirements::css(THIRDPARTY_DIR . '/jquery-ui-themes/smoothness/jquery-ui.css');
+			Requirements::javascript(SHOP_SEARCH_FOLDER . '/javascript/search.suggest.js');
+			Requirements::javascript(SHOP_SEARCH_FOLDER . '/javascript/search.js');
+		}
+	}
+
+
+	/**
+	 * @return string
+	 */
+	public static function get_category_field()
+	{
+		return Config::inst()->get('ShopSearchForm', 'category_field');
+	}
+
+
+	/**
+	 * @param array $data
+	 * @return mixed
+	 */
+	public function results(array $data)
+	{
+		// do the search
+		$results  = ShopSearch::inst()->search($data);
+		$request  = $this->controller->getRequest();
+		$baseLink = $request->getURL(false);
+
+		// if there was only one category filter, remember it for the category dropdown to retain it's value
+		if (!ShopSearchForm::config()->disable_category_dropdown) {
+			$qs_filters  = (string)Config::inst()->get('ShopSearch', 'qs_filters');
+			$categoryKey = (string)ShopSearchForm::config()->category_field;
+
+			if (preg_match('/\[(.+)\]/', $categoryKey, $matches)) {
+				// get right of the f[] around the actual key if present
+				$categoryKey = $matches[1];
+			}
+
+			if (!empty($data[$qs_filters][$categoryKey])) {
+				$categoryID = $data[$qs_filters][$categoryKey];
+				if (is_numeric($categoryID)) {
+					// If it's set in the dropdown it will just be a number
+					// If it's set from the checkboxes it will be something like LIST~1,2,3,4
+					// We only want to remember the value in the former case
+					Session::set('LastSearchCatID', $categoryID);
+				}
+			} else {
+				// If they unchecked every value, then clear the dropdown as well
+				Session::clear('LastSearchCatID');
+			}
+		}
+
+		// add links for any facets
+		if ($results->Facets && $results->Facets->count()) {
+			$qs_ps      = (string)Config::inst()->get('ShopSearch', 'qs_parent_search');
+			$baseParams = array_merge($data, array($qs_ps => $results->SearchLogID));
+			unset($baseParams['url']);
+			$results->Facets = FacetHelper::inst()->insertFacetLinks($results->Facets, $baseParams, $baseLink);
+		}
+
+		// add a dropdown for sorting
+		$qs_sort    = (string)Config::inst()->get('ShopSearch', 'qs_sort');
+		$options    = Config::inst()->get('ShopSearch', 'sort_options');
+		$sortParams = array_merge($data, array($qs_sort => 'NEWSORTVALUE'));
+		unset($sortParams['url']);
+		$results->SortControl = DropdownField::create($qs_sort, ShopSearch::config()->sort_label, $options, $results->Sort)
+			->setAttribute('data-url', $baseLink . '?' . http_build_query($sortParams));
+
+		// a little more output management
+		$results->Title = "Search Results";
+		$results->Results = $results->Matches; // this makes us compatible with the default search template
+
+		// Give a hook for the parent controller to format the results, for example,
+		// interpreting filters in a specific way to affect the title or content
+		// when no results are returned. Since this is domain-specific we just leave
+		// it up to the host app.
+		if ($this->controller->hasMethod('onBeforeSearchDisplay')) {
+			$this->controller->onBeforeSearchDisplay($results);
+		}
+
+		// give a hook for processing ajax requests through a different template (i.e. for returning only fragments)
+		$tpl = Config::inst()->get('ShopSearch', 'ajax_results_template');
+		if (!empty($tpl) && Director::is_ajax()) {
+			return $this->controller->customise($results)->renderWith($tpl);
+		}
+
+		// Give a hook for modifying the search responses
+		$this->controller->extend('updateSearchResultsResponse', $request, $response, $results, $data);
+
+		return $response ?: $this->controller->customise($results)->renderWith(array('ShopSearch_results', 'Page_results', 'Page'));
+	}
 }

Spacing +6 added lines, -6 removed lines

@@ -55,13 +55,13 @@ 
             $this->addExtraClass($c);
         }
 
-        Requirements::css(SHOP_SEARCH_FOLDER . '/css/ShopSearch.css');
+        Requirements::css(SHOP_SEARCH_FOLDER.'/css/ShopSearch.css');
 
         if (Config::inst()->get('ShopSearch', 'suggest_enabled')) {
-            Requirements::javascript(THIRDPARTY_DIR . '/jquery-ui/jquery-ui.js');
-            Requirements::css(THIRDPARTY_DIR . '/jquery-ui-themes/smoothness/jquery-ui.css');
-            Requirements::javascript(SHOP_SEARCH_FOLDER . '/javascript/search.suggest.js');
-            Requirements::javascript(SHOP_SEARCH_FOLDER . '/javascript/search.js');
+            Requirements::javascript(THIRDPARTY_DIR.'/jquery-ui/jquery-ui.js');
+            Requirements::css(THIRDPARTY_DIR.'/jquery-ui-themes/smoothness/jquery-ui.css');
+            Requirements::javascript(SHOP_SEARCH_FOLDER.'/javascript/search.suggest.js');
+            Requirements::javascript(SHOP_SEARCH_FOLDER.'/javascript/search.js');
         }
     }
 
@@ -124,7 +124,7 @@ 
         $sortParams = array_merge($data, array($qs_sort => 'NEWSORTVALUE'));
         unset($sortParams['url']);
         $results->SortControl = DropdownField::create($qs_sort, ShopSearch::config()->sort_label, $options, $results->Sort)
-            ->setAttribute('data-url', $baseLink . '?' . http_build_query($sortParams));
+            ->setAttribute('data-url', $baseLink.'?'.http_build_query($sortParams));
 
         // a little more output management
         $results->Title = "Search Results";

code/helpers/VirtualFieldIndexQueuedJob.php

Indentation +46 added lines, -46 removed lines

@@ -9,64 +9,64 @@
  * @subpackage helpers
  */
 if (!interface_exists('QueuedJob')) {
-    return;
+	return;
 }
 
 class VirtualFieldIndexQueuedJob extends AbstractQueuedJob implements QueuedJob
 {
-    /**
-     * The QueuedJob queue to use when processing updates
-     * @config
-     * @var int
-     */
-    private static $reindex_queue = 2; // QueuedJob::QUEUED;
+	/**
+	 * The QueuedJob queue to use when processing updates
+	 * @config
+	 * @var int
+	 */
+	private static $reindex_queue = 2; // QueuedJob::QUEUED;
 
 
-    /**
-     * @param DataObject $object
-     * @param array $fields
-     */
-    public function __construct($object = null, $fields = array())
-    {
-        if ($object) {
-            $this->setObject($object);
-        }
-        $this->rebuildFields = $fields;
-    }
+	/**
+	 * @param DataObject $object
+	 * @param array $fields
+	 */
+	public function __construct($object = null, $fields = array())
+	{
+		if ($object) {
+			$this->setObject($object);
+		}
+		$this->rebuildFields = $fields;
+	}
 
 
-    /**
-     * Helper method
-     */
-    public function triggerProcessing()
-    {
-        singleton('QueuedJobService')->queueJob($this);
-    }
+	/**
+	 * Helper method
+	 */
+	public function triggerProcessing()
+	{
+		singleton('QueuedJobService')->queueJob($this);
+	}
 
 
-    /**
-     * @return string
-     */
-    public function getTitle()
-    {
-        $obj = $this->getObject();
-        return "Update Virtual Field Indexes: " . ($obj ? $obj->getTitle() : '???');
-    }
+	/**
+	 * @return string
+	 */
+	public function getTitle()
+	{
+		$obj = $this->getObject();
+		return "Update Virtual Field Indexes: " . ($obj ? $obj->getTitle() : '???');
+	}
 
 
-    /**
-     * Reprocess any needed fields
-     */
-    public function process()
-    {
-        Versioned::reading_stage('Stage');
-        /** @var DataObject|VirtualFieldIndex $obj */
-        $obj = $this->getObject();
+	/**
+	 * Reprocess any needed fields
+	 */
+	public function process()
+	{
+		Versioned::reading_stage('Stage');
+		/** @var DataObject|VirtualFieldIndex $obj */
+		$obj = $this->getObject();
 
-        if ($obj) {
-            $obj->rebuildVFI();
-        }
+		if ($obj) {
+			$obj->rebuildVFI();
+		}
 
-        $this->isComplete = true;
-    }
+		$this->isComplete = true;
+	}
 }

Spacing +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     public function getTitle()
     {
         $obj = $this->getObject();
-        return "Update Virtual Field Indexes: " . ($obj ? $obj->getTitle() : '???');
+        return "Update Virtual Field Indexes: ".($obj ? $obj->getTitle() : '???');
     }
 
 

code/helpers/BetweenFilter.php

Indentation +73 added lines, -73 removed lines

@@ -10,89 +10,89 @@
  */
 class BetweenFilter extends SearchFilter
 {
-    /**
-     * @param DataQuery $query
-     * @return DataQuery
-     */
-    protected function applyOne(DataQuery $query)
-    {
-        $this->model = $query->applyRelation($this->relation);
-        $value = $this->getDbFormattedValue();
+	/**
+	 * @param DataQuery $query
+	 * @return DataQuery
+	 */
+	protected function applyOne(DataQuery $query)
+	{
+		$this->model = $query->applyRelation($this->relation);
+		$value = $this->getDbFormattedValue();
 
-        if (is_numeric($value)) {
-            $filter = sprintf("%s > %s", $this->getDbName(), Convert::raw2sql($value));
-        } else {
-            $filter = sprintf("%s > '%s'", $this->getDbName(), Convert::raw2sql($value));
-        }
+		if (is_numeric($value)) {
+			$filter = sprintf("%s > %s", $this->getDbName(), Convert::raw2sql($value));
+		} else {
+			$filter = sprintf("%s > '%s'", $this->getDbName(), Convert::raw2sql($value));
+		}
 
-        return $query->where($filter);
-    }
+		return $query->where($filter);
+	}
 
-    /**
-     * @param DataQuery $query
-     * @return DataQuery
-     */
-    protected function excludeOne(DataQuery $query)
-    {
-        $this->model = $query->applyRelation($this->relation);
-        $value = $this->getDbFormattedValue();
+	/**
+	 * @param DataQuery $query
+	 * @return DataQuery
+	 */
+	protected function excludeOne(DataQuery $query)
+	{
+		$this->model = $query->applyRelation($this->relation);
+		$value = $this->getDbFormattedValue();
 
-        if (is_numeric($value)) {
-            $filter = sprintf("%s <= %s", $this->getDbName(), Convert::raw2sql($value));
-        } else {
-            $filter = sprintf("%s <= '%s'", $this->getDbName(), Convert::raw2sql($value));
-        }
+		if (is_numeric($value)) {
+			$filter = sprintf("%s <= %s", $this->getDbName(), Convert::raw2sql($value));
+		} else {
+			$filter = sprintf("%s <= '%s'", $this->getDbName(), Convert::raw2sql($value));
+		}
 
-        return $query->where($filter);
-    }
+		return $query->where($filter);
+	}
 
-    /**
-     * @param DataQuery $query
-     * @return DataQuery
-     */
-    protected function applyMany(DataQuery $query)
-    {
-        $this->model = $query->applyRelation($this->relation);
+	/**
+	 * @param DataQuery $query
+	 * @return DataQuery
+	 */
+	protected function applyMany(DataQuery $query)
+	{
+		$this->model = $query->applyRelation($this->relation);
 
-        $filters = array();
-        $ops = array('>=', '<=');
-        foreach ($this->getValue() as $i => $value) {
-            if (is_numeric($value)) {
-                $filters[] = sprintf("%s %s %s", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
-            } else {
-                $filters[] = sprintf("%s %s '%s'", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
-            }
-        }
+		$filters = array();
+		$ops = array('>=', '<=');
+		foreach ($this->getValue() as $i => $value) {
+			if (is_numeric($value)) {
+				$filters[] = sprintf("%s %s %s", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
+			} else {
+				$filters[] = sprintf("%s %s '%s'", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
+			}
+		}
 
-        return $query->where(implode(' AND ', $filters));
-    }
+		return $query->where(implode(' AND ', $filters));
+	}
 
-    /**
-     * @param DataQuery $query
-     * @return DataQuery
-     */
-    protected function excludeMany(DataQuery $query)
-    {
-        $this->model = $query->applyRelation($this->relation);
+	/**
+	 * @param DataQuery $query
+	 * @return DataQuery
+	 */
+	protected function excludeMany(DataQuery $query)
+	{
+		$this->model = $query->applyRelation($this->relation);
 
-        $filters = array();
-        $ops = array('<', '>');
-        foreach ($this->getValue() as $i => $value) {
-            if (is_numeric($value)) {
-                $filters[] = sprintf("%s %s %s", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
-            } else {
-                $filters[] = sprintf("%s %s '%s'", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
-            }
-        }
+		$filters = array();
+		$ops = array('<', '>');
+		foreach ($this->getValue() as $i => $value) {
+			if (is_numeric($value)) {
+				$filters[] = sprintf("%s %s %s", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
+			} else {
+				$filters[] = sprintf("%s %s '%s'", $this->getDbName(), $ops[$i], Convert::raw2sql($value));
+			}
+		}
 
-        return $query->where(implode(' OR ', $filters));
-    }
+		return $query->where(implode(' OR ', $filters));
+	}
 
-    /**
-     * @return bool
-     */
-    public function isEmpty()
-    {
-        return $this->getValue() === array() || $this->getValue() === null || $this->getValue() === '';
-    }
+	/**
+	 * @return bool
+	 */
+	public function isEmpty()
+	{
+		return $this->getValue() === array() || $this->getValue() === null || $this->getValue() === '';
+	}
 }

code/adapters/ShopSearchSimple.php

Indentation +81 added lines, -81 removed lines

@@ -10,95 +10,95 @@
  */
 class ShopSearchSimple extends Object implements ShopSearchAdapter
 {
-    /**
-     * @param string $keywords
-     * @param array $filters [optional]
-     * @param array $facetSpec [optional]
-     * @param int $start [optional]
-     * @param int $limit [optional]
-     * @param string $sort [optional]
-     * @return ArrayData
-     */
-    public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='')
-    {
-        $searchable = ShopSearch::get_searchable_classes();
-        $matches = new ArrayList;
+	/**
+	 * @param string $keywords
+	 * @param array $filters [optional]
+	 * @param array $facetSpec [optional]
+	 * @param int $start [optional]
+	 * @param int $limit [optional]
+	 * @param string $sort [optional]
+	 * @return ArrayData
+	 */
+	public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='')
+	{
+		$searchable = ShopSearch::get_searchable_classes();
+		$matches = new ArrayList;
 
-        foreach ($searchable as $className) {
-            $list = DataObject::get($className);
+		foreach ($searchable as $className) {
+			$list = DataObject::get($className);
 
-            // get searchable fields
-            $keywordFields = $this->scaffoldSearchFields($className);
+			// get searchable fields
+			$keywordFields = $this->scaffoldSearchFields($className);
 
-            // convert that list into something we can pass to Datalist::filter
-            $keywordFilter = array();
-            if (!empty($keywords)) {
-                foreach ($keywordFields as $searchField) {
-                    $name = (strpos($searchField, ':') !== false) ? $searchField : "$searchField:PartialMatch";
-                    $keywordFilter[$name] = $keywords;
-                }
-            }
-            if (count($keywordFilter) > 0) {
-                $list = $list->filterAny($keywordFilter);
-            }
+			// convert that list into something we can pass to Datalist::filter
+			$keywordFilter = array();
+			if (!empty($keywords)) {
+				foreach ($keywordFields as $searchField) {
+					$name = (strpos($searchField, ':') !== false) ? $searchField : "$searchField:PartialMatch";
+					$keywordFilter[$name] = $keywords;
+				}
+			}
+			if (count($keywordFilter) > 0) {
+				$list = $list->filterAny($keywordFilter);
+			}
 
-            // add in any other filters
-            $list = FacetHelper::inst()->addFiltersToDataList($list, $filters);
+			// add in any other filters
+			$list = FacetHelper::inst()->addFiltersToDataList($list, $filters);
 
-            // add any matches to the big list
-            $matches->merge($list);
-        }
+			// add any matches to the big list
+			$matches->merge($list);
+		}
 
-        return new ArrayData(array(
-            'Matches'   => $matches,
-            'Facets'    => FacetHelper::inst()->buildFacets($matches, $facetSpec, (bool)Config::inst()->get('ShopSearch', 'auto_facet_attributes')),
-        ));
-    }
+		return new ArrayData(array(
+			'Matches'   => $matches,
+			'Facets'    => FacetHelper::inst()->buildFacets($matches, $facetSpec, (bool)Config::inst()->get('ShopSearch', 'auto_facet_attributes')),
+		));
+	}
 
 
-    /**
-     * This is verbatim copied from GridFieldAddExistingAutocompleter, with the exception
-     * that the default is 'PartialMatch' instead of 'StartsWith'
-     *
-     * @param String $dataClass - the class name
-     * @return Array|null - names of the searchable fields, with filters if appropriate
-     */
-    protected function scaffoldSearchFields($dataClass)
-    {
-        $obj = singleton($dataClass);
-        $fields = null;
-        if ($fieldSpecs = $obj->searchableFields()) {
-            $customSearchableFields = $obj->stat('searchable_fields');
-            foreach ($fieldSpecs as $name => $spec) {
-                if (is_array($spec) && array_key_exists('filter', $spec)) {
-                    // The searchableFields() spec defaults to PartialMatch,
-                    // so we need to check the original setting.
-                    // If the field is defined $searchable_fields = array('MyField'),
-                    // then default to StartsWith filter, which makes more sense in this context.
-                    if (!$customSearchableFields || array_search($name, $customSearchableFields)) {
-                        $filter = 'PartialMatch';
-                    } else {
-                        $filter = preg_replace('/Filter$/', '', $spec['filter']);
-                    }
+	/**
+	 * This is verbatim copied from GridFieldAddExistingAutocompleter, with the exception
+	 * that the default is 'PartialMatch' instead of 'StartsWith'
+	 *
+	 * @param String $dataClass - the class name
+	 * @return Array|null - names of the searchable fields, with filters if appropriate
+	 */
+	protected function scaffoldSearchFields($dataClass)
+	{
+		$obj = singleton($dataClass);
+		$fields = null;
+		if ($fieldSpecs = $obj->searchableFields()) {
+			$customSearchableFields = $obj->stat('searchable_fields');
+			foreach ($fieldSpecs as $name => $spec) {
+				if (is_array($spec) && array_key_exists('filter', $spec)) {
+					// The searchableFields() spec defaults to PartialMatch,
+					// so we need to check the original setting.
+					// If the field is defined $searchable_fields = array('MyField'),
+					// then default to StartsWith filter, which makes more sense in this context.
+					if (!$customSearchableFields || array_search($name, $customSearchableFields)) {
+						$filter = 'PartialMatch';
+					} else {
+						$filter = preg_replace('/Filter$/', '', $spec['filter']);
+					}
 
-                    if (class_exists($filter . 'Filter')) {
-                        $fields[] = "{$name}:{$filter}";
-                    } else {
-                        $fields[] = $name;
-                    }
-                } else {
-                    $fields[] = $name;
-                }
-            }
-        }
-        if (is_null($fields)) {
-            if ($obj->hasDatabaseField('Title')) {
-                $fields = array('Title');
-            } elseif ($obj->hasDatabaseField('Name')) {
-                $fields = array('Name');
-            }
-        }
+					if (class_exists($filter . 'Filter')) {
+						$fields[] = "{$name}:{$filter}";
+					} else {
+						$fields[] = $name;
+					}
+				} else {
+					$fields[] = $name;
+				}
+			}
+		}
+		if (is_null($fields)) {
+			if ($obj->hasDatabaseField('Title')) {
+				$fields = array('Title');
+			} elseif ($obj->hasDatabaseField('Name')) {
+				$fields = array('Name');
+			}
+		}
 
-        return $fields;
-    }
+		return $fields;
+	}
 }

Spacing +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
      * @param string $sort [optional]
      * @return ArrayData
      */
-    public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='')
+    public function searchFromVars($keywords, array $filters = array(), array $facetSpec = array(), $start = -1, $limit = -1, $sort = '')
     {
         $searchable = ShopSearch::get_searchable_classes();
         $matches = new ArrayList;
@@ -81,7 +81,7 @@ 
                         $filter = preg_replace('/Filter$/', '', $spec['filter']);
                     }
 
-                    if (class_exists($filter . 'Filter')) {
+                    if (class_exists($filter.'Filter')) {
                         $fields[] = "{$name}:{$filter}";
                     } else {
                         $fields[] = $name;

code/adapters/ShopSearchSolr.php

Spacing +10 added lines, -10 removed lines

@@ -173,8 +173,8 @@ 
         // create a sorting column
         if (isset($this->fieldMap['Title']) || ShopSearch::config()->solr_title_sort_field) {
             $f = empty(ShopSearch::config()->title_sort_field) ? '_titleSort' : ShopSearch::config()->solr_title_sort_field;
-            $xml .= "\n\t\t" . '<field name="' . $f . '" type="alphaOnlySort" indexed="true" stored="false" required="false" multiValued="false" />';
-            $xml .= "\n\t\t" . '<copyField source="SiteTree_Title" dest="' . $f . '"/>';
+            $xml .= "\n\t\t".'<field name="'.$f.'" type="alphaOnlySort" indexed="true" stored="false" required="false" multiValued="false" />';
+            $xml .= "\n\t\t".'<copyField source="SiteTree_Title" dest="'.$f.'"/>';
         }
 
         // create an autocomplete column
@@ -251,7 +251,7 @@ 
      * @param string $sort [optional]
      * @return ArrayData
      */
-    public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='score desc')
+    public function searchFromVars($keywords, array $filters = array(), array $facetSpec = array(), $start = -1, $limit = -1, $sort = 'score desc')
     {
         $query = new SearchQuery();
         $params = array(
@@ -302,13 +302,13 @@ 
         // process the keywords a bit
         $terms      = preg_split('/\s+/', trim(strtolower($keywords)));
         $lastTerm   = count($terms) > 0 ? array_pop($terms) : '';
-        $prefix     = count($terms) > 0 ? implode(' ', $terms) . ' ' : '';
+        $prefix     = count($terms) > 0 ? implode(' ', $terms).' ' : '';
         //$terms[]    = $lastTerm;
-        $terms[]    = $lastTerm . '*'; // this allows for partial words to still match
+        $terms[]    = $lastTerm.'*'; // this allows for partial words to still match
 
         // convert that to something solr adapater can handle
         $query = new SearchQuery();
-        $query->search('+' . implode(' +', $terms));
+        $query->search('+'.implode(' +', $terms));
 
         $params = array(
             'sort'          => 'score desc',
@@ -432,7 +432,7 @@ 
                 }
             }
 
-            $fq[] = ($missing ? "+{$field}:[* TO *] " : '') . '-('.implode(' ', $excludeq).')';
+            $fq[] = ($missing ? "+{$field}:[* TO *] " : '').'-('.implode(' ', $excludeq).')';
         }
 
 //		if(!headers_sent()) {
@@ -474,7 +474,7 @@ 
         $ret['suggestions'] = array();
         if (isset($res->facet_counts->facet_fields->_autocomplete)) {
             foreach ($res->facet_counts->facet_fields->_autocomplete as $term => $count) {
-                $ret['suggestions'][] = $prefix . $term;
+                $ret['suggestions'][] = $prefix.$term;
             }
         }
 
@@ -549,7 +549,7 @@ 
                 if ($fields) {
                     $searchq = array();
                     foreach ($fields as $field) {
-                        $boost = (isset($search['boost'][$field])) ? '^' . $search['boost'][$field] : '';
+                        $boost = (isset($search['boost'][$field])) ? '^'.$search['boost'][$field] : '';
                         $searchq[] = "{$field}:".$part.$fuzzy.$boost;
                     }
                     $q[] = '+('.implode(' OR ', $searchq).')';
@@ -627,7 +627,7 @@ 
                 }
             }
 
-            $fq[] = ($missing ? "+{$field}:[* TO *] " : '') . '-('.implode(' ', $excludeq).')';
+            $fq[] = ($missing ? "+{$field}:[* TO *] " : '').'-('.implode(' ', $excludeq).')';
         }
 
 //		if(!headers_sent()) {

Indentation +643 added lines, -643 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 if (!class_exists('SolrIndex')) {
-    return;
+	return;
 }
 
 /**
@@ -12,46 +12,46 @@ 
  */
 class ShopSearchSolr extends SolrIndex implements ShopSearchAdapter
 {
-    /** @var array - maps our names for fields to Solr's names (i.e. Title => SiteTree_Title) */
-    protected $fieldMap = array();
-
-    /**
-     * Sets up the index
-     */
-    public function init()
-    {
-        $searchables = ShopSearch::get_searchable_classes();
-
-        // Add each class to the index
-        foreach ($searchables as $class) {
-            $this->addClass($class);
-        }
-
-        // add the fields they've specifically asked for
-        $fields = $this->getFulltextSpec();
-        foreach ($fields as $def) {
-            $this->addFulltextField($def['field'], $def['type'], $def['params']);
-        }
-
-        // add the filters they've asked for
-        $filters = $this->getFilterSpec();
-        foreach ($filters as $filterName => $def) {
-            // NOTE: I'm pulling the guts out of this function so we can access Solr's full name
-            // for the field (SiteTree_Title for Title) and build the fieldMap in one step instead
-            // of two.
-            //$this->addFilterField($def['field'], $def['type'], $def['params']);
-            $singleFilter = $this->fieldData($def['field'], $def['type'], $def['params']);
-            $this->filterFields = array_merge($this->filterFields, $singleFilter);
-            foreach ($singleFilter as $solrName => $solrDef) {
-                if ($def['field'] == $solrDef['field']) {
-                    $this->fieldMap[$filterName] = $solrName;
-                }
-            }
-        }
+	/** @var array - maps our names for fields to Solr's names (i.e. Title => SiteTree_Title) */
+	protected $fieldMap = array();
+
+	/**
+	 * Sets up the index
+	 */
+	public function init()
+	{
+		$searchables = ShopSearch::get_searchable_classes();
+
+		// Add each class to the index
+		foreach ($searchables as $class) {
+			$this->addClass($class);
+		}
+
+		// add the fields they've specifically asked for
+		$fields = $this->getFulltextSpec();
+		foreach ($fields as $def) {
+			$this->addFulltextField($def['field'], $def['type'], $def['params']);
+		}
+
+		// add the filters they've asked for
+		$filters = $this->getFilterSpec();
+		foreach ($filters as $filterName => $def) {
+			// NOTE: I'm pulling the guts out of this function so we can access Solr's full name
+			// for the field (SiteTree_Title for Title) and build the fieldMap in one step instead
+			// of two.
+			//$this->addFilterField($def['field'], $def['type'], $def['params']);
+			$singleFilter = $this->fieldData($def['field'], $def['type'], $def['params']);
+			$this->filterFields = array_merge($this->filterFields, $singleFilter);
+			foreach ($singleFilter as $solrName => $solrDef) {
+				if ($def['field'] == $solrDef['field']) {
+					$this->fieldMap[$filterName] = $solrName;
+				}
+			}
+		}
 
 //		Debug::dump($this->filterFields);
 
-        // Add spellcheck fields
+		// Add spellcheck fields
 //		$spellFields = $cfg->get('ShopSearch', 'spellcheck_dictionary_source');
 //		if (empty($spellFields) || !is_array($spellFields)) {
 //			$spellFields = array();
@@ -65,11 +65,11 @@ 
 //			$this->addCopyField($f, '_spellcheckContent');
 //		}
 
-        // Technically, filter and sort fields are the same in Solr/Lucene
+		// Technically, filter and sort fields are the same in Solr/Lucene
 //		$this->addSortField('ViewCount');
 //		$this->addSortField('LastEdited', 'SSDatetime');
 
-        // Aggregate fields for spelling checks
+		// Aggregate fields for spelling checks
 //		$this->addCopyField('Title', 'spellcheckData');
 //		$this->addCopyField('Content', 'spellcheckData');
 
@@ -82,144 +82,144 @@ 
 //			)
 //		));
 
-        // I can't get this to work. Need a way to create the Category field that get used
+		// I can't get this to work. Need a way to create the Category field that get used
 //		$this->addFilterField('Category', 'Int');
 //		$this->addFilterField('Parent.ID');
 //		$this->addFilterField('ProductCategories.ID');
 //		$this->addCopyField('SiteTree_Parent_ID', 'Category');
 //		$this->addCopyField('Product_ProductCategories_ID', 'Category');
 
-        // These will be added in a pull request to shop module. If they're not present they'll be ignored
+		// These will be added in a pull request to shop module. If they're not present they'll be ignored
 //		$this->addFilterField('AllCategoryIDs', 'Int', array('multiValued' => 'true'));
 //		$this->addFilterField('AllRecursiveCategoryIDs', 'Int', array('multiValued' => 'true'));
 
-        // This will cause only live pages to be indexed. There are two ways to do
-        // this. See fulltextsearch/docs/en/index.md for more information.
-        // Not sure if this is really the way to go or not, but for now this is it.
-        $this->excludeVariantState(array('SearchVariantVersioned' => 'Stage'));
-    }
-
-
-    /**
-     * Transforms different formats of field list into something we can pass to solr
-     * @param array $in
-     * @return array
-     */
-    protected function scrubFieldList($in)
-    {
-        $out = array();
-        if (empty($in) || !is_array($in)) {
-            return $out;
-        }
-
-        foreach ($in as $name => $val) {
-            // supports an indexed array format of simple field names
-            if (is_numeric($name)) {
-                $name = $val;
-                $val = true;
-            }
-
-            // supports a boolean value meaning "use the default setup"
-            $params = !is_array($val) ? array() : array_slice($val, 0);
-
-            // build a normalized structur
-            $def = array(
-                'field'     => isset($params['field']) ? $params['field'] : $name,
-                'type'      => isset($params['type']) ? $params['type'] : null,
-                'params'    => $params,
-            );
-
-            if (isset($def['params']['field'])) {
-                unset($def['params']['field']);
-            }
-            if (isset($def['params']['type'])) {
-                unset($def['params']['type']);
-            }
-
-            $out[$name] = $def;
-        }
-
-        return $out;
-    }
-
-
-    /**
-     * @return array
-     */
-    protected function getFulltextSpec()
-    {
-        $fields = Config::inst()->get('ShopSearch', 'solr_fulltext_fields');
-        if (empty($fields)) {
-            $fields = array('Title', 'Content');
-        }
-        return $this->scrubFieldList($fields);
-    }
-
-
-    /**
-     *
-     */
-    protected function getFilterSpec()
-    {
-        $fields = Config::inst()->get('ShopSearch', 'solr_filter_fields');
-        return $this->scrubFieldList($fields);
-    }
-
-
-    /**
-     * @return string
-     */
-    public function getFieldDefinitions()
-    {
-        $xml = parent::getFieldDefinitions();
+		// This will cause only live pages to be indexed. There are two ways to do
+		// this. See fulltextsearch/docs/en/index.md for more information.
+		// Not sure if this is really the way to go or not, but for now this is it.
+		$this->excludeVariantState(array('SearchVariantVersioned' => 'Stage'));
+	}
+
+
+	/**
+	 * Transforms different formats of field list into something we can pass to solr
+	 * @param array $in
+	 * @return array
+	 */
+	protected function scrubFieldList($in)
+	{
+		$out = array();
+		if (empty($in) || !is_array($in)) {
+			return $out;
+		}
+
+		foreach ($in as $name => $val) {
+			// supports an indexed array format of simple field names
+			if (is_numeric($name)) {
+				$name = $val;
+				$val = true;
+			}
+
+			// supports a boolean value meaning "use the default setup"
+			$params = !is_array($val) ? array() : array_slice($val, 0);
+
+			// build a normalized structur
+			$def = array(
+				'field'     => isset($params['field']) ? $params['field'] : $name,
+				'type'      => isset($params['type']) ? $params['type'] : null,
+				'params'    => $params,
+			);
+
+			if (isset($def['params']['field'])) {
+				unset($def['params']['field']);
+			}
+			if (isset($def['params']['type'])) {
+				unset($def['params']['type']);
+			}
+
+			$out[$name] = $def;
+		}
+
+		return $out;
+	}
+
+
+	/**
+	 * @return array
+	 */
+	protected function getFulltextSpec()
+	{
+		$fields = Config::inst()->get('ShopSearch', 'solr_fulltext_fields');
+		if (empty($fields)) {
+			$fields = array('Title', 'Content');
+		}
+		return $this->scrubFieldList($fields);
+	}
+
+
+	/**
+	 *
+	 */
+	protected function getFilterSpec()
+	{
+		$fields = Config::inst()->get('ShopSearch', 'solr_filter_fields');
+		return $this->scrubFieldList($fields);
+	}
+
+
+	/**
+	 * @return string
+	 */
+	public function getFieldDefinitions()
+	{
+		$xml = parent::getFieldDefinitions();
 //		$xml .= "\n\t\t<field name='_spellcheckContent' type='htmltext' indexed='true' stored='false' multiValued='true' />";
 
-        // create a sorting column
-        if (isset($this->fieldMap['Title']) || ShopSearch::config()->solr_title_sort_field) {
-            $f = empty(ShopSearch::config()->title_sort_field) ? '_titleSort' : ShopSearch::config()->solr_title_sort_field;
-            $xml .= "\n\t\t" . '<field name="' . $f . '" type="alphaOnlySort" indexed="true" stored="false" required="false" multiValued="false" />';
-            $xml .= "\n\t\t" . '<copyField source="SiteTree_Title" dest="' . $f . '"/>';
-        }
-
-        // create an autocomplete column
-        if (ShopSearch::config()->suggest_enabled) {
-            $xml .= "\n\t\t<field name='_autocomplete' type='autosuggest_text' indexed='true' stored='false' multiValued='true'/>";
-        }
-
-        return $xml;
-    }
-
-
-    /**
-     * @return string
-     */
-    public function getCopyFieldDefinitions()
-    {
-        $xml = parent::getCopyFieldDefinitions();
-
-        if (ShopSearch::config()->suggest_enabled) {
-            foreach ($this->fulltextFields as $name => $field) {
-                $xml .= "\n\t<copyField source='{$name}' dest='_autocomplete' />";
-                //$xml .= "\n\t<copyField source='{$name}' dest='_spellcheckContent' />";
-            }
-        }
-
-        return $xml;
-    }
-
-
-        /**
-     * Overrides the parent to add a field for autocomplete
-     * @return HTMLText
-     */
-    public function getTypes()
-    {
-        $val = parent::getTypes();
-        if (!$val || !is_object($val)) {
-            return $val;
-        }
-        $xml = $val->getValue();
-        $xml .= <<<XML
+		// create a sorting column
+		if (isset($this->fieldMap['Title']) || ShopSearch::config()->solr_title_sort_field) {
+			$f = empty(ShopSearch::config()->title_sort_field) ? '_titleSort' : ShopSearch::config()->solr_title_sort_field;
+			$xml .= "\n\t\t" . '<field name="' . $f . '" type="alphaOnlySort" indexed="true" stored="false" required="false" multiValued="false" />';
+			$xml .= "\n\t\t" . '<copyField source="SiteTree_Title" dest="' . $f . '"/>';
+		}
+
+		// create an autocomplete column
+		if (ShopSearch::config()->suggest_enabled) {
+			$xml .= "\n\t\t<field name='_autocomplete' type='autosuggest_text' indexed='true' stored='false' multiValued='true'/>";
+		}
+
+		return $xml;
+	}
+
+
+	/**
+	 * @return string
+	 */
+	public function getCopyFieldDefinitions()
+	{
+		$xml = parent::getCopyFieldDefinitions();
+
+		if (ShopSearch::config()->suggest_enabled) {
+			foreach ($this->fulltextFields as $name => $field) {
+				$xml .= "\n\t<copyField source='{$name}' dest='_autocomplete' />";
+				//$xml .= "\n\t<copyField source='{$name}' dest='_spellcheckContent' />";
+			}
+		}
+
+		return $xml;
+	}
+
+
+		/**
+		 * Overrides the parent to add a field for autocomplete
+		 * @return HTMLText
+		 */
+	public function getTypes()
+	{
+		$val = parent::getTypes();
+		if (!$val || !is_object($val)) {
+			return $val;
+		}
+		$xml = $val->getValue();
+		$xml .= <<<XML
 
 	        <fieldType name="autosuggest_text" class="solr.TextField"
 	                   positionIncrementGap="100">
@@ -238,89 +238,89 @@ 
 	        </fieldType>
 
 XML;
-        $val->setValue($xml);
-        return $val;
-    }
-
-    /**
-     * This is an intermediary to bridge the search form input
-     * and the SearchQuery class. It allows us to have other
-     * drivers that may not use the FullTextSearch module.
-     *
-     * @param string $keywords
-     * @param array $filters [optional]
-     * @param array $facetSpec [optional]
-     * @param int $start [optional]
-     * @param int $limit [optional]
-     * @param string $sort [optional]
-     * @return ArrayData
-     */
-    public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='score desc')
-    {
-        $query = new SearchQuery();
-        $params = array(
-            'sort'  => $sort,
-        );
-
-        // swap out title search
-        if ($params['sort'] == 'SiteTree_Title') {
-            $params['sort'] = '_titleSort';
-        }
-
-        // search by keywords
-        $query->search(empty($keywords) ? '*:*' : $keywords);
-
-        // search by filter
-        foreach ($filters as $k => $v) {
-            if (isset($this->fieldMap[$k])) {
-                if (is_string($v) && preg_match('/^RANGE\~(.+)\~(.+)$/', $v, $m)) {
-                    // Is it a range value?
-                    $range = new SearchQuery_Range($m[1], $m[2]);
-                    $query->filter($this->fieldMap[$k], $range);
-                } else {
-                    // Or a normal scalar value
-                    $query->filter($this->fieldMap[$k], $v);
-                }
-            }
-        }
-
-        // add facets
-        $facetSpec = FacetHelper::inst()->expandFacetSpec($facetSpec);
-        $params += $this->buildFacetParams($facetSpec);
-
-        // TODO: add spellcheck
-
-        return $this->search($query, $start, $limit, $params, $facetSpec);
-    }
-
-
-    /**
-     * @param string $keywords
-     * @param array  $filters
-     * @return array
-     */
-    public function suggestWithResults($keywords, array $filters = array())
-    {
-        $limit      = (int)ShopSearch::config()->sayt_limit;
-
-        // process the keywords a bit
-        $terms      = preg_split('/\s+/', trim(strtolower($keywords)));
-        $lastTerm   = count($terms) > 0 ? array_pop($terms) : '';
-        $prefix     = count($terms) > 0 ? implode(' ', $terms) . ' ' : '';
-        //$terms[]    = $lastTerm;
-        $terms[]    = $lastTerm . '*'; // this allows for partial words to still match
-
-        // convert that to something solr adapater can handle
-        $query = new SearchQuery();
-        $query->search('+' . implode(' +', $terms));
-
-        $params = array(
-            'sort'          => 'score desc',
-            'facet'         => 'true',
-            'facet.field'   => '_autocomplete',
-            'facet.limit'   => ShopSearch::config()->suggest_limit,
-            'facet.prefix'  => $lastTerm,
-        );
+		$val->setValue($xml);
+		return $val;
+	}
+
+	/**
+	 * This is an intermediary to bridge the search form input
+	 * and the SearchQuery class. It allows us to have other
+	 * drivers that may not use the FullTextSearch module.
+	 *
+	 * @param string $keywords
+	 * @param array $filters [optional]
+	 * @param array $facetSpec [optional]
+	 * @param int $start [optional]
+	 * @param int $limit [optional]
+	 * @param string $sort [optional]
+	 * @return ArrayData
+	 */
+	public function searchFromVars($keywords, array $filters=array(), array $facetSpec=array(), $start=-1, $limit=-1, $sort='score desc')
+	{
+		$query = new SearchQuery();
+		$params = array(
+			'sort'  => $sort,
+		);
+
+		// swap out title search
+		if ($params['sort'] == 'SiteTree_Title') {
+			$params['sort'] = '_titleSort';
+		}
+
+		// search by keywords
+		$query->search(empty($keywords) ? '*:*' : $keywords);
+
+		// search by filter
+		foreach ($filters as $k => $v) {
+			if (isset($this->fieldMap[$k])) {
+				if (is_string($v) && preg_match('/^RANGE\~(.+)\~(.+)$/', $v, $m)) {
+					// Is it a range value?
+					$range = new SearchQuery_Range($m[1], $m[2]);
+					$query->filter($this->fieldMap[$k], $range);
+				} else {
+					// Or a normal scalar value
+					$query->filter($this->fieldMap[$k], $v);
+				}
+			}
+		}
+
+		// add facets
+		$facetSpec = FacetHelper::inst()->expandFacetSpec($facetSpec);
+		$params += $this->buildFacetParams($facetSpec);
+
+		// TODO: add spellcheck
+
+		return $this->search($query, $start, $limit, $params, $facetSpec);
+	}
+
+
+	/**
+	 * @param string $keywords
+	 * @param array  $filters
+	 * @return array
+	 */
+	public function suggestWithResults($keywords, array $filters = array())
+	{
+		$limit      = (int)ShopSearch::config()->sayt_limit;
+
+		// process the keywords a bit
+		$terms      = preg_split('/\s+/', trim(strtolower($keywords)));
+		$lastTerm   = count($terms) > 0 ? array_pop($terms) : '';
+		$prefix     = count($terms) > 0 ? implode(' ', $terms) . ' ' : '';
+		//$terms[]    = $lastTerm;
+		$terms[]    = $lastTerm . '*'; // this allows for partial words to still match
+
+		// convert that to something solr adapater can handle
+		$query = new SearchQuery();
+		$query->search('+' . implode(' +', $terms));
+
+		$params = array(
+			'sort'          => 'score desc',
+			'facet'         => 'true',
+			'facet.field'   => '_autocomplete',
+			'facet.limit'   => ShopSearch::config()->suggest_limit,
+			'facet.prefix'  => $lastTerm,
+		);
 
 //		$facetSpec = array(
 //			'_autocomplete' => array(
@@ -339,14 +339,14 @@ 
 //		$suggestsion = array();
 ////		if ($)
 
-        $service = $this->getService();
+		$service = $this->getService();
 
-        SearchVariant::with(count($query->classes) == 1 ? $query->classes[0]['class'] : null)->call('alterQuery', $query, $this);
+		SearchVariant::with(count($query->classes) == 1 ? $query->classes[0]['class'] : null)->call('alterQuery', $query, $this);
 
-        $q = $terms;
-        $fq = array();
+		$q = $terms;
+		$fq = array();
 
-        // Build the search itself
+		// Build the search itself
 //		foreach ($query->search as $search) {
 //			$text = $search['text'];
 //			preg_match_all('/"[^"]*"|\S+/', $text, $parts);
@@ -370,408 +370,408 @@ 
 //			}
 //		}
 
-        // Filter by class if requested
-        $classq = array();
-
-        foreach ($query->classes as $class) {
-            if (!empty($class['includeSubclasses'])) {
-                $classq[] = 'ClassHierarchy:'.$class['class'];
-            } else {
-                $classq[] = 'ClassName:'.$class['class'];
-            }
-        }
-
-        if ($classq) {
-            $fq[] = '+('.implode(' ', $classq).')';
-        }
-
-        // Filter by filters
-        foreach ($query->require as $field => $values) {
-            $requireq = array();
-
-            foreach ($values as $value) {
-                if ($value === SearchQuery::$missing) {
-                    $requireq[] = "(*:* -{$field}:[* TO *])";
-                } elseif ($value === SearchQuery::$present) {
-                    $requireq[] = "{$field}:[* TO *]";
-                } elseif ($value instanceof SearchQuery_Range) {
-                    $start = $value->start;
-                    if ($start === null) {
-                        $start = '*';
-                    }
-                    $end = $value->end;
-                    if ($end === null) {
-                        $end = '*';
-                    }
-                    $requireq[] = "$field:[$start TO $end]";
-                } else {
-                    $requireq[] = $field.':"'.$value.'"';
-                }
-            }
-
-            $fq[] = '+('.implode(' ', $requireq).')';
-        }
-
-        foreach ($query->exclude as $field => $values) {
-            $excludeq = array();
-            $missing = false;
-
-            foreach ($values as $value) {
-                if ($value === SearchQuery::$missing) {
-                    $missing = true;
-                } elseif ($value === SearchQuery::$present) {
-                    $excludeq[] = "{$field}:[* TO *]";
-                } elseif ($value instanceof SearchQuery_Range) {
-                    $start = $value->start;
-                    if ($start === null) {
-                        $start = '*';
-                    }
-                    $end = $value->end;
-                    if ($end === null) {
-                        $end = '*';
-                    }
-                    $excludeq[] = "$field:[$start TO $end]";
-                } else {
-                    $excludeq[] = $field.':"'.$value.'"';
-                }
-            }
-
-            $fq[] = ($missing ? "+{$field}:[* TO *] " : '') . '-('.implode(' ', $excludeq).')';
-        }
+		// Filter by class if requested
+		$classq = array();
+
+		foreach ($query->classes as $class) {
+			if (!empty($class['includeSubclasses'])) {
+				$classq[] = 'ClassHierarchy:'.$class['class'];
+			} else {
+				$classq[] = 'ClassName:'.$class['class'];
+			}
+		}
+
+		if ($classq) {
+			$fq[] = '+('.implode(' ', $classq).')';
+		}
+
+		// Filter by filters
+		foreach ($query->require as $field => $values) {
+			$requireq = array();
+
+			foreach ($values as $value) {
+				if ($value === SearchQuery::$missing) {
+					$requireq[] = "(*:* -{$field}:[* TO *])";
+				} elseif ($value === SearchQuery::$present) {
+					$requireq[] = "{$field}:[* TO *]";
+				} elseif ($value instanceof SearchQuery_Range) {
+					$start = $value->start;
+					if ($start === null) {
+						$start = '*';
+					}
+					$end = $value->end;
+					if ($end === null) {
+						$end = '*';
+					}
+					$requireq[] = "$field:[$start TO $end]";
+				} else {
+					$requireq[] = $field.':"'.$value.'"';
+				}
+			}
+
+			$fq[] = '+('.implode(' ', $requireq).')';
+		}
+
+		foreach ($query->exclude as $field => $values) {
+			$excludeq = array();
+			$missing = false;
+
+			foreach ($values as $value) {
+				if ($value === SearchQuery::$missing) {
+					$missing = true;
+				} elseif ($value === SearchQuery::$present) {
+					$excludeq[] = "{$field}:[* TO *]";
+				} elseif ($value instanceof SearchQuery_Range) {
+					$start = $value->start;
+					if ($start === null) {
+						$start = '*';
+					}
+					$end = $value->end;
+					if ($end === null) {
+						$end = '*';
+					}
+					$excludeq[] = "$field:[$start TO $end]";
+				} else {
+					$excludeq[] = $field.':"'.$value.'"';
+				}
+			}
+
+			$fq[] = ($missing ? "+{$field}:[* TO *] " : '') . '-('.implode(' ', $excludeq).')';
+		}
 
 //		if(!headers_sent()) {
 //			if ($q) header('X-Query: '.implode(' ', $q));
 //			if ($fq) header('X-Filters: "'.implode('", "', $fq).'"');
 //		}
 
-        $params = array_merge($params, array('fq' => implode(' ', $fq)));
-
-        $res = $service->search(
-            implode(' ', $q),
-            0,
-            $limit,
-            $params,
-            Apache_Solr_Service::METHOD_POST
-        );
-
-        $results = new ArrayList();
-        if ($res->getHttpStatus() >= 200 && $res->getHttpStatus() < 300) {
-            foreach ($res->response->docs as $doc) {
-                $result = DataObject::get_by_id($doc->ClassName, $doc->ID);
-                if ($result) {
-                    $results->push($result);
-                }
-            }
-            $numFound = $res->response->numFound;
-        } else {
-            $numFound = 0;
-        }
-
-        $ret = array();
-        $ret['products'] = new PaginatedList($results);
-        $ret['products']->setLimitItems(false);
-        $ret['products']->setTotalItems($numFound);
-        $ret['products']->setPageStart(0);
-        $ret['products']->setPageLength($limit);
-
-        // Facets (this is how we're doing suggestions for now...
-        $ret['suggestions'] = array();
-        if (isset($res->facet_counts->facet_fields->_autocomplete)) {
-            foreach ($res->facet_counts->facet_fields->_autocomplete as $term => $count) {
-                $ret['suggestions'][] = $prefix . $term;
-            }
-        }
-
-        // Suggestions (requires custom setup, assumes spellcheck.collate=true)
+		$params = array_merge($params, array('fq' => implode(' ', $fq)));
+
+		$res = $service->search(
+			implode(' ', $q),
+			0,
+			$limit,
+			$params,
+			Apache_Solr_Service::METHOD_POST
+		);
+
+		$results = new ArrayList();
+		if ($res->getHttpStatus() >= 200 && $res->getHttpStatus() < 300) {
+			foreach ($res->response->docs as $doc) {
+				$result = DataObject::get_by_id($doc->ClassName, $doc->ID);
+				if ($result) {
+					$results->push($result);
+				}
+			}
+			$numFound = $res->response->numFound;
+		} else {
+			$numFound = 0;
+		}
+
+		$ret = array();
+		$ret['products'] = new PaginatedList($results);
+		$ret['products']->setLimitItems(false);
+		$ret['products']->setTotalItems($numFound);
+		$ret['products']->setPageStart(0);
+		$ret['products']->setPageLength($limit);
+
+		// Facets (this is how we're doing suggestions for now...
+		$ret['suggestions'] = array();
+		if (isset($res->facet_counts->facet_fields->_autocomplete)) {
+			foreach ($res->facet_counts->facet_fields->_autocomplete as $term => $count) {
+				$ret['suggestions'][] = $prefix . $term;
+			}
+		}
+
+		// Suggestions (requires custom setup, assumes spellcheck.collate=true)
 //		if(isset($res->spellcheck->suggestions->collation)) {
 //			$ret['Suggestion'] = $res->spellcheck->suggestions->collation;
 //		}
 
-        return $ret;
-    }
-
-    /**
-     * @param $facets
-     * @return array
-     */
-    protected function buildFacetParams(array $facets)
-    {
-        $params = array();
-
-        if (!empty($facets)) {
-            $params['facet'] = 'true';
-
-            foreach ($facets as $name => $spec) {
-                // With our current implementation, "range" facets aren't true facets in solr terms.
-                // They're just a type of filter which can be handled elsewhere.
-                // For the other types we just ignore the rest of the spec and let Solr do its thing
-                if ($spec['Type'] != ShopSearch::FACET_TYPE_RANGE && isset($this->fieldMap[$name])) {
-                    $params['facet.field'] = $this->fieldMap[$name];
-                }
-            }
-        }
-
-        return $params;
-    }
-
-
-    /**
-     * Fulltextsearch module doesn't yet support facets very well, so I've just copied this function here so
-     * we have access to the results. I'd prefer to modify it minimally so we can eventually get rid of it
-     * once they add faceting or hooks to get directly at the returned response.
-     *
-     * @param SearchQuery $query
-     * @param integer $offset
-     * @param integer $limit
-     * @param  Array $params Extra request parameters passed through to Solr
-     * @param array $facetSpec - Added for ShopSearch so we can process the facets
-     * @return ArrayData Map with the following keys:
-     *  - 'Matches': ArrayList of the matched object instances
-     */
-    public function search(SearchQuery $query, $offset = -1, $limit = -1, $params = array(), $facetSpec = array())
-    {
-        $service = $this->getService();
-
-        SearchVariant::with(count($query->classes) == 1 ? $query->classes[0]['class'] : null)->call('alterQuery', $query, $this);
-
-        $q = array();
-        $fq = array();
-
-        // Build the search itself
-
-        foreach ($query->search as $search) {
-            $text = $search['text'];
-            preg_match_all('/"[^"]*"|\S+/', $text, $parts);
-
-            $fuzzy = $search['fuzzy'] ? '~' : '';
-
-            foreach ($parts[0] as $part) {
-                $fields = (isset($search['fields'])) ? $search['fields'] : array();
-                if (isset($search['boost'])) {
-                    $fields = array_merge($fields, array_keys($search['boost']));
-                }
-                if ($fields) {
-                    $searchq = array();
-                    foreach ($fields as $field) {
-                        $boost = (isset($search['boost'][$field])) ? '^' . $search['boost'][$field] : '';
-                        $searchq[] = "{$field}:".$part.$fuzzy.$boost;
-                    }
-                    $q[] = '+('.implode(' OR ', $searchq).')';
-                } else {
-                    $q[] = '+'.$part.$fuzzy;
-                }
-            }
-        }
-
-        // Filter by class if requested
-
-        $classq = array();
-
-        foreach ($query->classes as $class) {
-            if (!empty($class['includeSubclasses'])) {
-                $classq[] = 'ClassHierarchy:'.$class['class'];
-            } else {
-                $classq[] = 'ClassName:'.$class['class'];
-            }
-        }
-
-        if ($classq) {
-            $fq[] = '+('.implode(' ', $classq).')';
-        }
-
-        // Filter by filters
-
-        foreach ($query->require as $field => $values) {
-            $requireq = array();
-
-            foreach ($values as $value) {
-                if ($value === SearchQuery::$missing) {
-                    $requireq[] = "(*:* -{$field}:[* TO *])";
-                } elseif ($value === SearchQuery::$present) {
-                    $requireq[] = "{$field}:[* TO *]";
-                } elseif ($value instanceof SearchQuery_Range) {
-                    $start = $value->start;
-                    if ($start === null) {
-                        $start = '*';
-                    }
-                    $end = $value->end;
-                    if ($end === null) {
-                        $end = '*';
-                    }
-                    $requireq[] = "$field:[$start TO $end]";
-                } else {
-                    $requireq[] = $field.':"'.$value.'"';
-                }
-            }
-
-            $fq[] = '+('.implode(' ', $requireq).')';
-        }
-
-        foreach ($query->exclude as $field => $values) {
-            $excludeq = array();
-            $missing = false;
-
-            foreach ($values as $value) {
-                if ($value === SearchQuery::$missing) {
-                    $missing = true;
-                } elseif ($value === SearchQuery::$present) {
-                    $excludeq[] = "{$field}:[* TO *]";
-                } elseif ($value instanceof SearchQuery_Range) {
-                    $start = $value->start;
-                    if ($start === null) {
-                        $start = '*';
-                    }
-                    $end = $value->end;
-                    if ($end === null) {
-                        $end = '*';
-                    }
-                    $excludeq[] = "$field:[$start TO $end]";
-                } else {
-                    $excludeq[] = $field.':"'.$value.'"';
-                }
-            }
-
-            $fq[] = ($missing ? "+{$field}:[* TO *] " : '') . '-('.implode(' ', $excludeq).')';
-        }
+		return $ret;
+	}
+
+	/**
+	 * @param $facets
+	 * @return array
+	 */
+	protected function buildFacetParams(array $facets)
+	{
+		$params = array();
+
+		if (!empty($facets)) {
+			$params['facet'] = 'true';
+
+			foreach ($facets as $name => $spec) {
+				// With our current implementation, "range" facets aren't true facets in solr terms.
+				// They're just a type of filter which can be handled elsewhere.
+				// For the other types we just ignore the rest of the spec and let Solr do its thing
+				if ($spec['Type'] != ShopSearch::FACET_TYPE_RANGE && isset($this->fieldMap[$name])) {
+					$params['facet.field'] = $this->fieldMap[$name];
+				}
+			}
+		}
+
+		return $params;
+	}
+
+
+	/**
+	 * Fulltextsearch module doesn't yet support facets very well, so I've just copied this function here so
+	 * we have access to the results. I'd prefer to modify it minimally so we can eventually get rid of it
+	 * once they add faceting or hooks to get directly at the returned response.
+	 *
+	 * @param SearchQuery $query
+	 * @param integer $offset
+	 * @param integer $limit
+	 * @param  Array $params Extra request parameters passed through to Solr
+	 * @param array $facetSpec - Added for ShopSearch so we can process the facets
+	 * @return ArrayData Map with the following keys:
+	 *  - 'Matches': ArrayList of the matched object instances
+	 */
+	public function search(SearchQuery $query, $offset = -1, $limit = -1, $params = array(), $facetSpec = array())
+	{
+		$service = $this->getService();
+
+		SearchVariant::with(count($query->classes) == 1 ? $query->classes[0]['class'] : null)->call('alterQuery', $query, $this);
+
+		$q = array();
+		$fq = array();
+
+		// Build the search itself
+
+		foreach ($query->search as $search) {
+			$text = $search['text'];
+			preg_match_all('/"[^"]*"|\S+/', $text, $parts);
+
+			$fuzzy = $search['fuzzy'] ? '~' : '';
+
+			foreach ($parts[0] as $part) {
+				$fields = (isset($search['fields'])) ? $search['fields'] : array();
+				if (isset($search['boost'])) {
+					$fields = array_merge($fields, array_keys($search['boost']));
+				}
+				if ($fields) {
+					$searchq = array();
+					foreach ($fields as $field) {
+						$boost = (isset($search['boost'][$field])) ? '^' . $search['boost'][$field] : '';
+						$searchq[] = "{$field}:".$part.$fuzzy.$boost;
+					}
+					$q[] = '+('.implode(' OR ', $searchq).')';
+				} else {
+					$q[] = '+'.$part.$fuzzy;
+				}
+			}
+		}
+
+		// Filter by class if requested
+
+		$classq = array();
+
+		foreach ($query->classes as $class) {
+			if (!empty($class['includeSubclasses'])) {
+				$classq[] = 'ClassHierarchy:'.$class['class'];
+			} else {
+				$classq[] = 'ClassName:'.$class['class'];
+			}
+		}
+
+		if ($classq) {
+			$fq[] = '+('.implode(' ', $classq).')';
+		}
+
+		// Filter by filters
+
+		foreach ($query->require as $field => $values) {
+			$requireq = array();
+
+			foreach ($values as $value) {
+				if ($value === SearchQuery::$missing) {
+					$requireq[] = "(*:* -{$field}:[* TO *])";
+				} elseif ($value === SearchQuery::$present) {
+					$requireq[] = "{$field}:[* TO *]";
+				} elseif ($value instanceof SearchQuery_Range) {
+					$start = $value->start;
+					if ($start === null) {
+						$start = '*';
+					}
+					$end = $value->end;
+					if ($end === null) {
+						$end = '*';
+					}
+					$requireq[] = "$field:[$start TO $end]";
+				} else {
+					$requireq[] = $field.':"'.$value.'"';
+				}
+			}
+
+			$fq[] = '+('.implode(' ', $requireq).')';
+		}
+
+		foreach ($query->exclude as $field => $values) {
+			$excludeq = array();
+			$missing = false;
+
+			foreach ($values as $value) {
+				if ($value === SearchQuery::$missing) {
+					$missing = true;
+				} elseif ($value === SearchQuery::$present) {
+					$excludeq[] = "{$field}:[* TO *]";
+				} elseif ($value instanceof SearchQuery_Range) {
+					$start = $value->start;
+					if ($start === null) {
+						$start = '*';
+					}
+					$end = $value->end;
+					if ($end === null) {
+						$end = '*';
+					}
+					$excludeq[] = "$field:[$start TO $end]";
+				} else {
+					$excludeq[] = $field.':"'.$value.'"';
+				}
+			}
+
+			$fq[] = ($missing ? "+{$field}:[* TO *] " : '') . '-('.implode(' ', $excludeq).')';
+		}
 
 //		if(!headers_sent()) {
 //			if ($q) header('X-Query: '.implode(' ', $q));
 //			if ($fq) header('X-Filters: "'.implode('", "', $fq).'"');
 //		}
 
-        if ($offset == -1) {
-            $offset = $query->start;
-        }
-        if ($limit == -1) {
-            $limit = $query->limit;
-        }
-        if ($limit == -1) {
-            $limit = SearchQuery::$default_page_size;
-        }
-
-        $params = array_merge($params, array('fq' => implode(' ', $fq)));
-
-        $res = $service->search(
-            $q ? implode(' ', $q) : '*:*',
-            $offset,
-            $limit,
-            $params,
-            Apache_Solr_Service::METHOD_POST
-        );
-        //Debug::dump($res);
-
-        $results = new ArrayList();
-        if ($res->getHttpStatus() >= 200 && $res->getHttpStatus() < 300) {
-            foreach ($res->response->docs as $doc) {
-                $result = DataObject::get_by_id($doc->ClassName, $doc->ID);
-                if ($result) {
-                    $results->push($result);
-
-                    // Add highlighting (optional)
-                    $docId = $doc->_documentid;
-                    if ($res->highlighting && $res->highlighting->$docId) {
-                        // TODO Create decorator class for search results rather than adding arbitrary object properties
-                        // TODO Allow specifying highlighted field, and lazy loading
-                        // in case the search API needs another query (similar to SphinxSearchable->buildExcerpt()).
-                        $combinedHighlights = array();
-                        foreach ($res->highlighting->$docId as $field => $highlights) {
-                            $combinedHighlights = array_merge($combinedHighlights, $highlights);
-                        }
-
-                        // Remove entity-encoded U+FFFD replacement character. It signifies non-displayable characters,
-                        // and shows up as an encoding error in browsers.
-                        $result->Excerpt = DBField::create_field(
-                            'HTMLText',
-                            str_replace(
-                                '&#65533;',
-                                '',
-                                implode(' ... ', $combinedHighlights)
-                            )
-                        );
-                    }
-                }
-            }
-            $numFound = $res->response->numFound;
-        } else {
-            $numFound = 0;
-        }
-
-        $ret = array();
-        $ret['Matches'] = new PaginatedList($results);
-        $ret['Matches']->setLimitItems(false);
-        // Tell PaginatedList how many results there are
-        $ret['Matches']->setTotalItems($numFound);
-        // Results for current page start at $offset
-        $ret['Matches']->setPageStart($offset);
-        // Results per page
-        $ret['Matches']->setPageLength($limit);
-
-        // Facets
-        //Debug::dump($res);
-        if (isset($res->facet_counts->facet_fields)) {
-            $ret['Facets'] = $this->buildFacetResults($res->facet_counts->facet_fields, $facetSpec);
-        }
-
-        // Suggestions (requires custom setup, assumes spellcheck.collate=true)
-        if (isset($res->spellcheck->suggestions->collation)) {
-            $ret['Suggestion'] = $res->spellcheck->suggestions->collation;
-        }
-
-        return new ArrayData($ret);
-    }
-
-
-    /**
-     * @param stdClass $facetFields
-     * @param array $facetSpec
-     * @return ArrayList
-     */
-    protected function buildFacetResults($facetFields, array $facetSpec)
-    {
-        $out = new ArrayList;
-
-        foreach ($facetSpec as $field => $facet) {
-            if ($facet['Type'] == ShopSearch::FACET_TYPE_RANGE) {
-                // If it's a range facet, set up the min/max
-                // TODO: we could probably get the real min and max with solr's range faceting if we tried
-                if (isset($facet['RangeMin'])) {
-                    $facet['MinValue'] = $facet['RangeMin'];
-                }
-                if (isset($facet['RangeMax'])) {
-                    $facet['MaxValue'] = $facet['RangeMax'];
-                }
-                $out->push(new ArrayData($facet));
-            } elseif (isset($this->fieldMap[$field])) {
-                // Otherwise, look through Solr's results
-                $mySolrName = $this->fieldMap[$field];
-                foreach ($facetFields as $solrName => $values) {
-                    if ($solrName == $mySolrName) {
-                        // we found a match, look through the values we were given
-                        foreach ($values as $val => $count) {
-                            if (!isset($facet['Values'][$val])) {
-                                // for link type facets we want to add anything
-                                // for checkboxes, if it's not in the provided list we leave it out
-                                if ($facet['Type'] != ShopSearch::FACET_TYPE_CHECKBOX && $count > 0) {
-                                    $facet['Values'][$val] = new ArrayData(array(
-                                        'Label'     => $val,
-                                        'Value'     => $val,
-                                        'Count'     => $count,
-                                    ));
-                                }
-                            } elseif ($facet['Values'][$val]) {
-                                $facet['Values'][$val]->Count = $count;
-                            }
-                        }
-                    }
-                }
-
-                // then add that to the stack
-                $facet['Values'] = new ArrayList($facet['Values']);
-                $out->push(new ArrayData($facet));
-            }
-        }
-
-        //Debug::dump($out);
-        return $out;
-    }
+		if ($offset == -1) {
+			$offset = $query->start;
+		}
+		if ($limit == -1) {
+			$limit = $query->limit;
+		}
+		if ($limit == -1) {
+			$limit = SearchQuery::$default_page_size;
+		}
+
+		$params = array_merge($params, array('fq' => implode(' ', $fq)));
+
+		$res = $service->search(
+			$q ? implode(' ', $q) : '*:*',
+			$offset,
+			$limit,
+			$params,
+			Apache_Solr_Service::METHOD_POST
+		);
+		//Debug::dump($res);
+
+		$results = new ArrayList();
+		if ($res->getHttpStatus() >= 200 && $res->getHttpStatus() < 300) {
+			foreach ($res->response->docs as $doc) {
+				$result = DataObject::get_by_id($doc->ClassName, $doc->ID);
+				if ($result) {
+					$results->push($result);
+
+					// Add highlighting (optional)
+					$docId = $doc->_documentid;
+					if ($res->highlighting && $res->highlighting->$docId) {
+						// TODO Create decorator class for search results rather than adding arbitrary object properties
+						// TODO Allow specifying highlighted field, and lazy loading
+						// in case the search API needs another query (similar to SphinxSearchable->buildExcerpt()).
+						$combinedHighlights = array();
+						foreach ($res->highlighting->$docId as $field => $highlights) {
+							$combinedHighlights = array_merge($combinedHighlights, $highlights);
+						}
+
+						// Remove entity-encoded U+FFFD replacement character. It signifies non-displayable characters,
+						// and shows up as an encoding error in browsers.
+						$result->Excerpt = DBField::create_field(
+							'HTMLText',
+							str_replace(
+								'&#65533;',
+								'',
+								implode(' ... ', $combinedHighlights)
+							)
+						);
+					}
+				}
+			}
+			$numFound = $res->response->numFound;
+		} else {
+			$numFound = 0;
+		}
+
+		$ret = array();
+		$ret['Matches'] = new PaginatedList($results);
+		$ret['Matches']->setLimitItems(false);
+		// Tell PaginatedList how many results there are
+		$ret['Matches']->setTotalItems($numFound);
+		// Results for current page start at $offset
+		$ret['Matches']->setPageStart($offset);
+		// Results per page
+		$ret['Matches']->setPageLength($limit);
+
+		// Facets
+		//Debug::dump($res);
+		if (isset($res->facet_counts->facet_fields)) {
+			$ret['Facets'] = $this->buildFacetResults($res->facet_counts->facet_fields, $facetSpec);
+		}
+
+		// Suggestions (requires custom setup, assumes spellcheck.collate=true)
+		if (isset($res->spellcheck->suggestions->collation)) {
+			$ret['Suggestion'] = $res->spellcheck->suggestions->collation;
+		}
+
+		return new ArrayData($ret);
+	}
+
+
+	/**
+	 * @param stdClass $facetFields
+	 * @param array $facetSpec
+	 * @return ArrayList
+	 */
+	protected function buildFacetResults($facetFields, array $facetSpec)
+	{
+		$out = new ArrayList;
+
+		foreach ($facetSpec as $field => $facet) {
+			if ($facet['Type'] == ShopSearch::FACET_TYPE_RANGE) {
+				// If it's a range facet, set up the min/max
+				// TODO: we could probably get the real min and max with solr's range faceting if we tried
+				if (isset($facet['RangeMin'])) {
+					$facet['MinValue'] = $facet['RangeMin'];
+				}
+				if (isset($facet['RangeMax'])) {
+					$facet['MaxValue'] = $facet['RangeMax'];
+				}
+				$out->push(new ArrayData($facet));
+			} elseif (isset($this->fieldMap[$field])) {
+				// Otherwise, look through Solr's results
+				$mySolrName = $this->fieldMap[$field];
+				foreach ($facetFields as $solrName => $values) {
+					if ($solrName == $mySolrName) {
+						// we found a match, look through the values we were given
+						foreach ($values as $val => $count) {
+							if (!isset($facet['Values'][$val])) {
+								// for link type facets we want to add anything
+								// for checkboxes, if it's not in the provided list we leave it out
+								if ($facet['Type'] != ShopSearch::FACET_TYPE_CHECKBOX && $count > 0) {
+									$facet['Values'][$val] = new ArrayData(array(
+										'Label'     => $val,
+										'Value'     => $val,
+										'Count'     => $count,
+									));
+								}
+							} elseif ($facet['Values'][$val]) {
+								$facet['Values'][$val]->Count = $count;
+							}
+						}
+					}
+				}
+
+				// then add that to the stack
+				$facet['Values'] = new ArrayList($facet['Values']);
+				$out->push(new ArrayData($facet));
+			}
+		}
+
+		//Debug::dump($out);
+		return $out;
+	}
 }