VirtualFieldIndexQueuedJob

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	4
Bugs	2	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	triggerProcessing()	0	4	1
A	getTitle()	0	5	2
A	process()	0	12	2

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 15 and the first side effect is on line 12.

/**
 * If the queued jobs module is installed, this will be used instead of
 * updating vfi's in onBeforeWrite.
 *
 * @author  Mark Guinn <mark@adaircreative.com>
 * @date    07.02.2015
 * @package shop_search
 * @subpackage helpers
 */
if (!interface_exists('QueuedJob')) {
    return;
}

class VirtualFieldIndexQueuedJob extends AbstractQueuedJob implements QueuedJob

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * The QueuedJob queue to use when processing updates
     * @config
     * @var int
     */
    private static $reindex_queue = 2; // QueuedJob::QUEUED;

The property $reindex_queue is not used and could be removed.

    /**
     * @param DataObject $object
     * @param array $fields
     */
    public function __construct($object = null, $fields = array())
    {
        if ($object) {
            $this->setObject($object);
        }
        $this->rebuildFields = $fields;
    }


    /**
     * Helper method
     */
    public function triggerProcessing()
    {
        singleton('QueuedJobService')->queueJob($this);
    }


    /**
     * @return string
     */
    public function getTitle()
    {
        $obj = $this->getObject();
        return "Update Virtual Field Indexes: " . ($obj ? $obj->getTitle() : '???');
    }


    /**
     * Reprocess any needed fields
     */
    public function process()
    {
        Versioned::reading_stage('Stage');
        /** @var DataObject|VirtualFieldIndex $obj */
        $obj = $this->getObject();

        if ($obj) {
            $obj->rebuildVFI();

The method rebuildVFI does only exist in VirtualFieldIndex, but not in DataObject.

        }

        $this->isComplete = true;
    }
}