Issues in vsc.php (master) - Issues in master - mariusor/vsc - Measure and Improve Code Quality continuously with Scrutinizer

Issues (222)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/infrastructure/vsc.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @package infrastructure
 * @author marius orcsik <[email protected]>
 * @date 09.08.31
 */
namespace vsc\infrastructure;

use vsc\application\dispatchers\DispatcherA;
use vsc\application\dispatchers\HttpDispatcherA;
use vsc\application\dispatchers\RwDispatcher;
use vsc\application\sitemaps\ModuleMap;
use vsc\application\sitemaps\SiteMapA;
use vsc\presentation\requests\HttpRequestA;
use vsc\presentation\requests\RawHttpRequest;
use vsc\presentation\requests\RwHttpRequest;
use vsc\presentation\responses\HttpResponse;
use vsc\presentation\responses\HttpResponseA;

class vsc extends BaseObject {
	/**
	 * @var vsc
	 */
	static private $oInstance;

	/**
	 * @var HttpRequestA
	 */
	private $oRequest = null;

	/**
	 * @var HttpResponseA
	 */
	private $oResponse = null;

	/**
	 * @var DispatcherA
	 */
	private $oDispatcher;

	/**
	 * @param vsc $envObject
	 */
	public static function setInstance(vsc $envObject) {
		self::$oInstance = $envObject;
	}

	/**
	 * @return vsc
	 */
	public static function getEnv() {
		if (!(vsc::isValid(self::$oInstance))) {
			self::$oInstance = new self();
		}
		return self::$oInstance;
	}

	/**
	 * @param HttpRequestA $oRequest
	 */
	public function setHttpRequest(HttpRequestA $oRequest) {
		if (HttpRequestA::isValid($oRequest)) {
			$this->oRequest = $oRequest;
		}
	}

	/**
	 * @returns HttpRequestA
	 */
	public function getHttpRequest() {
		if (is_null($this->oRequest)) {
			// @todo FIX this ugly stuff
			if (array_key_exists('CONTENT_TYPE', $_SERVER) && strlen($_SERVER['CONTENT_TYPE']) > 0) {
				$this->oRequest = new RawHttpRequest();
			} else {
				$this->oRequest = new RwHttpRequest();
			}
		}
		return $this->oRequest;
	}

	/**
	 * @param HttpResponseA $oResponse
	 */
	public function setHttpResponse(HttpResponseA $oResponse) {
		if (HttpResponseA::isValid($oResponse) && (is_null($this->oResponse) || get_class($this->oResponse) != get_class($oResponse))) {
			$this->oResponse = $oResponse;
		}
	}

	/**
	 * @returns HttpResponseA
	 */
	public function getHttpResponse() {
		if (is_null($this->oResponse)) {
			$this->oResponse = new HttpResponse();
		}
		return $this->oResponse;
	}

	/**
	 * @param HttpDispatcherA $oDispatcher
	 */
	public function setDispatcher($oDispatcher) {
		if (DispatcherA::isValid($oDispatcher)) {
			$this->oDispatcher = $oDispatcher;
		}
	}

	/**
	 * @returns HttpDispatcherA
	 */
	public function getDispatcher() {
		if (!HttpDispatcherA::isValid($this->oDispatcher)) {
			$this->oDispatcher = new RwDispatcher();
		}
		return $this->oDispatcher;
	}

	/**
	 * @return SiteMapA
	 */
	public function getSiteMap() {
		return $this->getDispatcher()->getSiteMap();
	}

	/**
	 * @return boolean
	 */
	public function isDevelopment() {
		return (
			self::isCli() || (
				stristr($_SERVER['REMOTE_ADDR'], '127.0.0.1') != false ||

				stristr($_SERVER['REMOTE_ADDR'], '192.168') != false

			)
		);
	}

	/**
	 * @return bool
	 */
	protected function _isCli() {
		return (php_sapi_name() == 'cli');
	}

	/**
	 * @return bool
	 */
	public static function isCli() {
		return self::getEnv()->_isCli();
	}

	/**
	 * @return string
	 */
	public static function name() {
		return 'V<sup>S<sup>C</sup></sup>';
	}

	/**
	 * returns an end of line, based on the environment
	 * @return string
	 */
	public static function nl() {
		return self::isCli() ? "\n" : '<br/>' . "\n";
	}

	/**
	 * @param array ...$values
	 * @return string

	 */
	public static function d(...$values) {
		$output = '';
		for ($i = 0; $i < ob_get_level(); $i++) {
			// cleaning the buffers
			ob_end_clean();
		}

		if (!self::isCLi() && self::getEnv()->getHttpRequest()->accepts('application/json')) {
			$output = json_encode($values);
		} elseif (self::isCLi() || self::getEnv()->getHttpRequest()->accepts('text/html')) {
			foreach ($values as $object) {
				ob_start();
				var_dump($object);

				$output .= ob_get_clean();

				if (!self::isCli()) {
					$output .= '<hr/>' . "\n";
				}
			}
		}

		if (!stristr($_SERVER['PHP_SELF'], 'phpunit')) {
			ob_start();
			debug_print_backtrace();
			$output .= ob_get_clean();

			if (self::isCLi() || self::getEnv()->getHttpRequest()->accepts('application/json')) {
				echo StringUtils::stripTags(StringUtils::br2nl($output));
			} elseif (self::getEnv()->getHttpRequest()->accepts('text/html')) {
				echo '<pre>' . $output . '</pre>';
			} else {
				echo StringUtils::stripTags(StringUtils::br2nl($output));
			}

			exit ();
		} else {
			return $output;
		}
	}

	public static function getIncludePaths() {
		return explode(PATH_SEPARATOR, get_include_path());
	}

	/**
	 * @returns ModuleMap
	 */
	public function getCurrentModuleMap() {

		return $this->getDispatcher()->getCurrentModuleMap();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	public static function getPaths() {
		return explode(PATH_SEPARATOR, get_include_path());
	}
}


GitHub Access Token became invalid

Issues (222)

Security Analysis not enabled

src/infrastructure/vsc.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1		<?php
2		/**
3		* @package infrastructure
4		* @author marius orcsik <[email protected]>
5		* @date 09.08.31
6		*/
7		namespace vsc\infrastructure;
8
9		use vsc\application\dispatchers\DispatcherA;
10		use vsc\application\dispatchers\HttpDispatcherA;
11		use vsc\application\dispatchers\RwDispatcher;
12		use vsc\application\sitemaps\ModuleMap;
13		use vsc\application\sitemaps\SiteMapA;
14		use vsc\presentation\requests\HttpRequestA;
15		use vsc\presentation\requests\RawHttpRequest;
16		use vsc\presentation\requests\RwHttpRequest;
17		use vsc\presentation\responses\HttpResponse;
18		use vsc\presentation\responses\HttpResponseA;
19
20		class vsc extends BaseObject {
21		/**
22		* @var vsc
23		*/
24		static private $oInstance;
25
26		/**
27		* @var HttpRequestA
28		*/
29		private $oRequest = null;
30
31		/**
32		* @var HttpResponseA
33		*/
34		private $oResponse = null;
35
36		/**
37		* @var DispatcherA
38		*/
39		private $oDispatcher;
40
41		/**
42		* @param vsc $envObject
43		*/
44	19	public static function setInstance(vsc $envObject) {
45	19	self::$oInstance = $envObject;
46	19	}
47
48		/**
49		* @return vsc
50		*/
51	26	public static function getEnv() {
52	26	if (!(vsc::isValid(self::$oInstance))) {
53		self::$oInstance = new self();
54		}
55	26	return self::$oInstance;
56		}
57
58		/**
59		* @param HttpRequestA $oRequest
60		*/
61	18	public function setHttpRequest(HttpRequestA $oRequest) {
62	18	if (HttpRequestA::isValid($oRequest)) {
63	18	$this->oRequest = $oRequest;
64		}
65	18	}
66
67		/**
68		* @returns HttpRequestA
69		*/
70	20	public function getHttpRequest() {
71	20	if (is_null($this->oRequest)) {
72		// @todo FIX this ugly stuff
73		if (array_key_exists('CONTENT_TYPE', $_SERVER) && strlen($_SERVER['CONTENT_TYPE']) > 0) {
74		$this->oRequest = new RawHttpRequest();
75		} else {
76		$this->oRequest = new RwHttpRequest();
77		}
78		}
79	20	return $this->oRequest;
80		}
81
82		/**
83		* @param HttpResponseA $oResponse
84		*/
85	1	public function setHttpResponse(HttpResponseA $oResponse) {
86	1	if (HttpResponseA::isValid($oResponse) && (is_null($this->oResponse) \|\| get_class($this->oResponse) != get_class($oResponse))) {
87	1	$this->oResponse = $oResponse;
88		}
89	1	}
90
91		/**
92		* @returns HttpResponseA
93		*/
94	1	public function getHttpResponse() {
95	1	if (is_null($this->oResponse)) {
96	1	$this->oResponse = new HttpResponse();
97		}
98	1	return $this->oResponse;
99		}
100
101		/**
102		* @param HttpDispatcherA $oDispatcher
103		*/
104	1	public function setDispatcher($oDispatcher) {
105	1	if (DispatcherA::isValid($oDispatcher)) {
106	1	$this->oDispatcher = $oDispatcher;
107		}
108	1	}
109
110		/**
111		* @returns HttpDispatcherA
112		*/
113	3	public function getDispatcher() {
114	3	if (!HttpDispatcherA::isValid($this->oDispatcher)) {
115	1	$this->oDispatcher = new RwDispatcher();
116		}
117	3	return $this->oDispatcher;
118		}
119
120		/**
121		* @return SiteMapA
122		*/
123	2	public function getSiteMap() {
124	2	return $this->getDispatcher()->getSiteMap();
125		}
126
127		/**
128		* @return boolean
129		*/
130	1	public function isDevelopment() {
131		return (
132	1	self::isCli() \|\| (
133		stristr($_SERVER['REMOTE_ADDR'], '127.0.0.1') != false \|\|
		0 ignored issues – show Bug Best Practice introduced 2016-01-01 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing `stristr($_SERVER['REMOTE_ADDR'], '127.0.0.1')` of type `string` to the boolean `false`. If you are specifically checking for a non-empty string, consider using the more explicit `!== ''` instead. Loading history...
134	1	stristr($_SERVER['REMOTE_ADDR'], '192.168') != false
		0 ignored issues – show Bug Best Practice introduced 2016-01-01 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing `stristr($_SERVER['REMOTE_ADDR'], '192.168')` of type `string` to the boolean `false`. If you are specifically checking for a non-empty string, consider using the more explicit `!== ''` instead. Loading history...
135		)
136		);
137		}
138
139		/**
140		* @return bool
141		*/
142	4	protected function _isCli() {
143	4	return (php_sapi_name() == 'cli');
144		}
145
146		/**
147		* @return bool
148		*/
149	5	public static function isCli() {
150	5	return self::getEnv()->_isCli();
151		}
152
153		/**
154		* @return string
155		*/
156	1	public static function name() {
157	1	return 'V<sup>S<sup>C</sup></sup>';
158		}
159
160		/**
161		* returns an end of line, based on the environment
162		* @return string
163		*/
164	1	public static function nl() {
165	1	return self::isCli() ? "\n" : '<br/>' . "\n";
166		}
167
168		/**
169		* @param array ...$values
170		* @return string
		0 ignored issues – show Documentation introduced 2017-01-28 12:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `null\|string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
171		*/
172	1	public static function d(...$values) {
173	1	$output = '';
174	1	for ($i = 0; $i < ob_get_level(); $i++) {
175		// cleaning the buffers
176	1	ob_end_clean();
177		}
178
179	1	if (!self::isCLi() && self::getEnv()->getHttpRequest()->accepts('application/json')) {
180		$output = json_encode($values);
181	1	} elseif (self::isCLi() \|\| self::getEnv()->getHttpRequest()->accepts('text/html')) {
182	1	foreach ($values as $object) {
183	1	ob_start();
184	1	var_dump($object);
		0 ignored issues – show Security Debugging Code introduced 2016-01-01 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `var_dump($object);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
185	1	$output .= ob_get_clean();
186
187	1	if (!self::isCli()) {
188	1	$output .= '<hr/>' . "\n";
189		}
190		}
191		}
192
193	1	if (!stristr($_SERVER['PHP_SELF'], 'phpunit')) {
194		ob_start();
195		debug_print_backtrace();
196		$output .= ob_get_clean();
197
198		if (self::isCLi() \|\| self::getEnv()->getHttpRequest()->accepts('application/json')) {
199		echo StringUtils::stripTags(StringUtils::br2nl($output));
200		} elseif (self::getEnv()->getHttpRequest()->accepts('text/html')) {
201		echo '<pre>' . $output . '</pre>';
202		} else {
203		echo StringUtils::stripTags(StringUtils::br2nl($output));
204		}
205
206		exit ();
207		} else {
208	1	return $output;
209		}
210		}
211
212	1	public static function getIncludePaths() {
213	1	return explode(PATH_SEPARATOR, get_include_path());
214		}
215
216		/**
217		* @returns ModuleMap
218		*/
219	1	public function getCurrentModuleMap() {
		0 ignored issues – show Documentation introduced 2018-04-25 09:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
220	1	return $this->getDispatcher()->getCurrentModuleMap();
		0 ignored issues – show Documentation Bug introduced 2016-01-01 13:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getCurrentModuleMap` does not exist on `object<vsc\application\dispatchers\DispatcherA>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
221		}
222
223	1	public static function getPaths() {
224	1	return explode(PATH_SEPARATOR, get_include_path());
225		}
226		}
227

mariusor / vsc

GitHub Access Token became invalid

Issues (222)

Security Analysis not enabled

src/infrastructure/vsc.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like