ViewA - Code Metrics - Inspection of "Fix version for scrutinizer" - mariusor/vsc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 290674...0f9d71 )

by Marius

created 2018-04-25 09:12 UTC

ViewA B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	281
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Test Coverage

Coverage

81%

Importance

Changes

Metric	Value
dl	0
loc	281
ccs	81
cts	100
cp	0.81
rs	8.2608
c	0
b	0
f	0
wmc	40
lcom	1
cbo	11

19 Methods

Rating	Name	Size	Complexity
A	setMainTemplate()	6	2
A	getMainTemplate()	3	1
A	getContentType()	3	1
A	getViewFolder()	3	1
A	setModel()	3	1
A	setMap()	3	1
A	registerHelper()	3	1
A	getModel()	6	2
A	getTemplate()	7	2
A	setTemplate()	7	2
A	getCurrentSiteUri()	3	1
A	getCurrentUri()	3	1
B	getTitle()	18	5
A	getMap()	7	2
A	__call()	11	3
A	__get()	10	2
B	fetch()	36	5
A	getOutput()	13	3
A	getTemplatePath()	16	4

How to fix Complexity

<?php
/**
 * @package presentation
 * @subpackage views
 * @author marius orcsik <[email protected]>
 * @date 09.08.30
 */
namespace vsc\presentation\views;

use vsc\application\sitemaps\ClassMap;
use vsc\application\sitemaps\MappingA;
use vsc\domain\models\EmptyModel;
use vsc\domain\models\HttpModelInterface;
use vsc\domain\models\ModelA;
use vsc\infrastructure\urls\UrlParserA;
use vsc\infrastructure\vsc;
use vsc\infrastructure\Base;
use vsc\infrastructure\BaseObject;
use vsc\presentation\helpers\ViewHelperA;
use vsc\ExceptionPath;

abstract class ViewA extends BaseObject implements ViewInterface {
	/**
	 * @var string
	 */
	private $sTitle;

	/**
	 * @var ModelA
	 */
	private $oModel;

	/**
	 * @var ViewHelperA[]
	 */
	private $aHelpers = array();


	/**
	 * @var string
	 */
	private $sMainTemplate;

	/**
	 * @var ClassMap
	 */
	private $oCurrentMap;

	/**
	 * type of view (html, rss, etc)
	 * @var string
	 */
	protected $sContentType;

	/**
	 * @var string
	 */
	protected $sFolder;

	/**
	 * @param $sPath
	 * @throws ExceptionPath
	 */
	public function setMainTemplate($sPath) {
		if (!is_file($sPath)) {
			throw new ExceptionPath('The main template [' . $sPath . '] is not accessible.');
		}
		$this->sMainTemplate = $sPath;
	}

	/**
	 * @return string
	 */
	public function getMainTemplate() {
		return $this->sMainTemplate;
	}

	/**
	 * @return string
	 */
	public function getContentType() {
		return $this->sContentType;
	}

	/**
	 * @return string
	 */
	public function getViewFolder() {
		return $this->sFolder;
	}

	/**
	 * @return string
	 * @throws ExceptionView
	 */
	public function getTitle() {
		try {
			/** @var EmptyModel $oModel */
			$oModel = $this->getModel();
			if (($oModel instanceof HttpModelInterface) && $oModel->getPageTitle() != '') {
				return  $oModel->getPageTitle();
			}
		} catch (\Exception $e) {
			//
		}

		$sStaticTitle = $this->getMap()->getTitle();
		if (!empty ($sStaticTitle)) {
			return $sStaticTitle;
		}

		return $this->sTitle;
	}

	/**
	 * @param ModelA $oModel
	 */
	public function setModel(ModelA $oModel) {
		$this->oModel = $oModel;
	}

	/**
	 * @throws ExceptionView
	 * @returns ClassMap
	 */
	public function getMap() {
		if (MappingA::isValid($this->oCurrentMap)) {
			return $this->oCurrentMap;
		} else {
			throw new ExceptionView('Make sure the current map is correctly set.');
		}
	}

	/**
	 * @param ClassMap $oMap
	 */
	public function setMap($oMap) {
		$this->oCurrentMap = $oMap;
	}

	public function registerHelper(ViewHelperA $oHelper) {
		$this->getMap()->registerHelper($oHelper);
	}

	public function __call($sMethodName, $aParameters = array()) {

		// to be used with helpers
		foreach ($this->getMap()->getViewHelpers() as $key => $oHelper) {
			$oReflection = new \ReflectionClass($oHelper);
			if ($oReflection->hasMethod($sMethodName)) {
				$oMethod = $oReflection->getMethod($sMethodName);
				return $oMethod->invokeArgs($oHelper, $aParameters);
			}
		}
		return $aParameters;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

	/**
	 * @param $sVarName
	 * @return Base
	 */
	public function __get($sVarName) {
		try {
			// TODO: use proper reflection
			return $this->getModel()->$sVarName;
		} catch (\Exception $e) {
			// most likely the variable doesn't exist
			vsc::d($e->getTraceAsString());
		}
		return null;
	}

	/**
	 * @returns ModelA
	 */
	public function getModel() {
		if (!ModelA::isValid($this->oModel)) {
			$this->oModel = new EmptyModel();
		}
		return $this->oModel;
	}

//	public function setBody ($sText) {

//		$this->sBody = $sText;
//	}

	/**
	 * @param string $includePath
	 * @return string
	 * @throws ExceptionPath
	 * @throws ExceptionView
	 */
	public function fetch($includePath) {
		if (empty($includePath)) {
			throw new ExceptionPath('Template could not be located');
		}

		ob_start();
		if (!is_file($includePath)) {
			$includePath = $this->getTemplatePath() . $includePath;
			if (!is_file($includePath)) {
				ob_end_clean();
				throw new ExceptionPath('Template [' . $includePath . '] could not be located');
			}
		}
		// outputting the model's content into the local scope
		$model = $this->getModel();
		extract(
			array(

				'model'     => $model,
				'view'      => $this,
				'helper'    => $this->getMap(),
				'request'   => vsc::getEnv()->getHttpRequest()
			),
			EXTR_SKIP
		);

		$bIncluded = include ($includePath);

		if (!$bIncluded) {
			ob_end_clean();
			throw new ExceptionView('Template [' . $includePath . '] could not be included');
		} else {
			$sContent = ob_get_contents();
			ob_end_clean();
			return $sContent;
		}
	}

	/**
	 * @return string
	 * @throws ExceptionView
	 */
	public function getOutput() {
		try {
			// by default try to load the main template
			return $this->fetch($this->getMainTemplate());
		} catch (ExceptionPath $e) {
			// if it fails, we load the regular template.
			try {
				return $this->fetch($this->getTemplatePath() . DIRECTORY_SEPARATOR . $this->getMap()->getTemplate());
			} catch (ExceptionPath $e) {
				return '';
			}
		}
	}

	/**
	 * @return string
	 * @throws ExceptionView
	 */
	public function getTemplatePath() {
		$sTemplatePath = $this->getMap()->getTemplatePath();
		$sViewFolder = $this->getViewFolder();
$a = "a";
$ab = "ab";
$abc = "abc";

		if (!empty($sViewFolder)) {
			$sTemplatePath .= DIRECTORY_SEPARATOR . $sViewFolder;
		}

		if (!is_dir($sTemplatePath)) {
			return '';
		}
		if (!UrlParserA::hasGoodTermination($sTemplatePath, DIRECTORY_SEPARATOR)) {
			$sTemplatePath .= DIRECTORY_SEPARATOR;
		}
		return $sTemplatePath;
	}

	/**
	 * @return string
	 */
	public function getTemplate() {
		try {
			return $this->getMap()->getTemplate();
		} catch (ExceptionView $e) {
			return '';
		}
	}

	/**
	 * @param string $sPath
	 */
	public function setTemplate($sPath) {
		try {
			$this->getMap()->setTemplate($sPath);
		} catch (ExceptionView $e) {
			//
		}
	}

	/**
	 * @return string
	 */
	public static function getCurrentSiteUri() {
		return htmlspecialchars(UrlParserA::getCurrentUrl()->getUrl());
	}

	/**
	 * @return string
	 */
	public static function getCurrentUri() {
		return htmlspecialchars(vsc::getEnv()->getHttpRequest()->getUri(true));
	}
}


GitHub Access Token became invalid

Push — master ( 290674...0f9d71 )

ViewA B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

19 Methods

How to fix Complexity

Complex Class

1		<?php
2		/**
3		* @package presentation
4		* @subpackage views
5		* @author marius orcsik <[email protected]>
6		* @date 09.08.30
7		*/
8		namespace vsc\presentation\views;
9
10		use vsc\application\sitemaps\ClassMap;
11		use vsc\application\sitemaps\MappingA;
12		use vsc\domain\models\EmptyModel;
13		use vsc\domain\models\HttpModelInterface;
14		use vsc\domain\models\ModelA;
15		use vsc\infrastructure\urls\UrlParserA;
16		use vsc\infrastructure\vsc;
17		use vsc\infrastructure\Base;
18		use vsc\infrastructure\BaseObject;
19		use vsc\presentation\helpers\ViewHelperA;
20		use vsc\ExceptionPath;
21
22		abstract class ViewA extends BaseObject implements ViewInterface {
23		/**
24		* @var string
25		*/
26		private $sTitle;
27
28		/**
29		* @var ModelA
30		*/
31		private $oModel;
32
33		/**
34		* @var ViewHelperA[]
35		*/
36		private $aHelpers = array();
		0 ignored issues – show Unused Code introduced 2016-01-01 13:53 UTC by Report Bug Copy Issue Report The property `$aHelpers` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
37
38		/**
39		* @var string
40		*/
41		private $sMainTemplate;
42
43		/**
44		* @var ClassMap
45		*/
46		private $oCurrentMap;
47
48		/**
49		* type of view (html, rss, etc)
50		* @var string
51		*/
52		protected $sContentType;
53
54		/**
55		* @var string
56		*/
57		protected $sFolder;
58
59		/**
60		* @param $sPath
61		* @throws ExceptionPath
62		*/
63	3	public function setMainTemplate($sPath) {
64	3	if (!is_file($sPath)) {
65	2	throw new ExceptionPath('The main template [' . $sPath . '] is not accessible.');
66		}
67	2	$this->sMainTemplate = $sPath;
68	2	}
69
70		/**
71		* @return string
72		*/
73	1	public function getMainTemplate() {
74	1	return $this->sMainTemplate;
75		}
76
77		/**
78		* @return string
79		*/
80	1	public function getContentType() {
81	1	return $this->sContentType;
82		}
83
84		/**
85		* @return string
86		*/
87	3	public function getViewFolder() {
88	3	return $this->sFolder;
89		}
90
91		/**
92		* @return string
93		* @throws ExceptionView
94		*/
95	2	public function getTitle() {
96		try {
97		/** @var EmptyModel $oModel */
98	2	$oModel = $this->getModel();
99	2	if (($oModel instanceof HttpModelInterface) && $oModel->getPageTitle() != '') {
100	2	return $oModel->getPageTitle();
101		}
102		} catch (\Exception $e) {
103		//
104		}
105
106	2	$sStaticTitle = $this->getMap()->getTitle();
107	2	if (!empty ($sStaticTitle)) {
108	1	return $sStaticTitle;
109		}
110
111	2	return $this->sTitle;
112		}
113
114		/**
115		* @param ModelA $oModel
116		*/
117	2	public function setModel(ModelA $oModel) {
118	2	$this->oModel = $oModel;
119	2	}
120
121		/**
122		* @throws ExceptionView
123		* @returns ClassMap
124		*/
125	1	public function getMap() {
126	1	if (MappingA::isValid($this->oCurrentMap)) {
127		return $this->oCurrentMap;
128		} else {
129	1	throw new ExceptionView('Make sure the current map is correctly set.');
130		}
131		}
132
133		/**
134		* @param ClassMap $oMap
135		*/
136	2	public function setMap($oMap) {
137	2	$this->oCurrentMap = $oMap;
138	2	}
139
140	1	public function registerHelper(ViewHelperA $oHelper) {
141	1	$this->getMap()->registerHelper($oHelper);
142	1	}
143
144	1	public function __call($sMethodName, $aParameters = array()) {
		0 ignored issues – show Documentation introduced 2018-04-25 09:18 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
145		// to be used with helpers
146	1	foreach ($this->getMap()->getViewHelpers() as $key => $oHelper) {
147		$oReflection = new \ReflectionClass($oHelper);
148		if ($oReflection->hasMethod($sMethodName)) {
149		$oMethod = $oReflection->getMethod($sMethodName);
150		return $oMethod->invokeArgs($oHelper, $aParameters);
151		}
152		}
153		return $aParameters;
		0 ignored issues – show Bug Best Practice introduced 2018-04-25 09:18 UTC by Report Bug Copy Issue Report The return type of `return $aParameters;` (`array`) is incompatible with the return type of the parent method `vsc\infrastructure\BaseObject::__call` of type `vsc\infrastructure\Base`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
154		}
155
156		/**
157		* @param $sVarName
158		* @return Base
159		*/
160	1	public function __get($sVarName) {
161		try {
162		// TODO: use proper reflection
163	1	return $this->getModel()->$sVarName;
164		} catch (\Exception $e) {
165		// most likely the variable doesn't exist
166		vsc::d($e->getTraceAsString());
167		}
168		return null;
169		}
170
171		/**
172		* @returns ModelA
173		*/
174	1	public function getModel() {
175	1	if (!ModelA::isValid($this->oModel)) {
176	1	$this->oModel = new EmptyModel();
177		}
178	1	return $this->oModel;
179		}
180
181		// public function setBody ($sText) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2018-04-25 09:18 UTC by Report Bug Copy Issue Report `44%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
182		// $this->sBody = $sText;
183		// }
184
185		/**
186		* @param string $includePath
187		* @return string
188		* @throws ExceptionPath
189		* @throws ExceptionView
190		*/
191	1	public function fetch($includePath) {
192	1	if (empty($includePath)) {
193	1	throw new ExceptionPath('Template could not be located');
194		}
195
196	1	ob_start();
197	1	if (!is_file($includePath)) {
198	1	$includePath = $this->getTemplatePath() . $includePath;
199	1	if (!is_file($includePath)) {
200		ob_end_clean();
201		throw new ExceptionPath('Template [' . $includePath . '] could not be located');
202		}
203		}
204		// outputting the model's content into the local scope
205	1	$model = $this->getModel();
206	1	extract(
207		array(
		0 ignored issues – show Bug introduced 2016-01-01 13:53 UTC by Report Bug Copy Issue Report `array('model' => $model,...nv()->getHttpRequest())` cannot be passed to `extract()` as the parameter `$var_array` expects a reference. Loading history...
208	1	'model' => $model,
209	1	'view' => $this,
210	1	'helper' => $this->getMap(),
211	1	'request' => vsc::getEnv()->getHttpRequest()
212		),
213	1	EXTR_SKIP
214		);
215
216	1	$bIncluded = include ($includePath);
217
218	1	if (!$bIncluded) {
219		ob_end_clean();
220		throw new ExceptionView('Template [' . $includePath . '] could not be included');
221		} else {
222	1	$sContent = ob_get_contents();
223	1	ob_end_clean();
224	1	return $sContent;
225		}
226		}
227
228		/**
229		* @return string
230		* @throws ExceptionView
231		*/
232	1	public function getOutput() {
233		try {
234		// by default try to load the main template
235	1	return $this->fetch($this->getMainTemplate());
236	1	} catch (ExceptionPath $e) {
237		// if it fails, we load the regular template.
238		try {
239	1	return $this->fetch($this->getTemplatePath() . DIRECTORY_SEPARATOR . $this->getMap()->getTemplate());
240	1	} catch (ExceptionPath $e) {
241		return '';
242		}
243		}
244		}
245
246		/**
247		* @return string
248		* @throws ExceptionView
249		*/
250	1	public function getTemplatePath() {
251	1	$sTemplatePath = $this->getMap()->getTemplatePath();
252	1	$sViewFolder = $this->getViewFolder();
		0 ignored issues – show Coding Style introduced 2016-01-01 13:53 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
253
254	1	if (!empty($sViewFolder)) {
255		$sTemplatePath .= DIRECTORY_SEPARATOR . $sViewFolder;
256		}
257
258	1	if (!is_dir($sTemplatePath)) {
259	1	return '';
260		}
261		if (!UrlParserA::hasGoodTermination($sTemplatePath, DIRECTORY_SEPARATOR)) {
262		$sTemplatePath .= DIRECTORY_SEPARATOR;
263		}
264		return $sTemplatePath;
265		}
266
267		/**
268		* @return string
269		*/
270	1	public function getTemplate() {
271		try {
272	1	return $this->getMap()->getTemplate();
273	1	} catch (ExceptionView $e) {
274	1	return '';
275		}
276		}
277
278		/**
279		* @param string $sPath
280		*/
281	1	public function setTemplate($sPath) {
282		try {
283	1	$this->getMap()->setTemplate($sPath);
284	1	} catch (ExceptionView $e) {
285		//
286		}
287	1	}
288
289		/**
290		* @return string
291		*/
292	1	public static function getCurrentSiteUri() {
293	1	return htmlspecialchars(UrlParserA::getCurrentUrl()->getUrl());
294		}
295
296		/**
297		* @return string
298		*/
299	1	public static function getCurrentUri() {
300	1	return htmlspecialchars(vsc::getEnv()->getHttpRequest()->getUri(true));
301		}
302		}
303

mariusor / vsc

GitHub Access Token became invalid

Push — master ( 290674...0f9d71 )

ViewA B

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

19 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like