vsc\application\processors\ProcessorA

Complexity

Total Complexity

16

Size/Duplication

Total Lines	109
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

87.5%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	getMap()	0	8	2
A	getLocalVars()	0	3	1
A	setVar()	0	7	2
A	setMap()	0	7	3
A	setLocalVars()	0	12	3
A	getVar()	0	7	2
A	delegateRequest()	0	22	3

<?php
/**
 * @package application
 * @subpackage processors
 * @author marius orcsik <marius@habarnam.ro>
 * @date 09.08.31
 */
namespace vsc\application\processors;

use vsc\application\sitemaps\ClassMap;
use vsc\application\sitemaps\MappingA;
use vsc\domain\models\ModelA;
use vsc\infrastructure\vsc;
use vsc\infrastructure\BaseObject;
use vsc\presentation\requests\HttpRequestA;
use vsc\presentation\responses\HttpResponse;
use vsc\presentation\responses\HttpResponseA;
use vsc\application\dispatchers\RwDispatcher;

abstract class ProcessorA extends BaseObject implements ProcessorInterface {
	private $oCurrentMap;
	protected $aLocalVars = array();

	/**
	 * @returns ClassMap
	 */
	public function getMap() {
		if (MappingA::isValid($this->oCurrentMap)) {
			return $this->oCurrentMap;
		} else {
			$oMirror = new \ReflectionClass($this);
			return new ClassMap($oMirror->getName(), '.*');

Consider using $oMirror->name. There is an issue with getName() and APC-enabled PHP versions.

		}
	}

	/**
	 * @param MappingA $oMap
	 */
	public function setMap(MappingA $oMap) {
		$this->oCurrentMap = $oMap;
		$aTainted = $oMap->getTaintedVars();

Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space

		if (is_array($aTainted) && count($aTainted) >= 1) {
			$this->setLocalVars($aTainted);
		}
	}

	/**
	 *
	 * @param array $aVars
	 * @param bool $bPreserveKeys
	 * @return void
	 */
	public function setLocalVars($aVars = array(), $bPreserveKeys = false) {
		if ($bPreserveKeys) {
			$this->aLocalVars = array_merge($this->aLocalVars, $aVars);
		} else {
			// This needs improvement to take into account incoming arrays
			//  containing both string keys - which exist or not in the $aLocalVars array
			//  and numeric indexes
			foreach ($this->aLocalVars as $sKey => $sValue) {
				$this->aLocalVars[$sKey] = array_shift($aVars);
			}
		}
	}

	/**
	 * @return array
	 */
	public function getLocalVars() {
		return $this->aLocalVars;
	}

	/**
	 * @param string $sVar
	 * @param string $sValue
	 * @return bool
	 */
	public function setVar($sVar, $sValue) {
		if (array_key_exists($sVar, $this->aLocalVars)) {
			$this->aLocalVars[$sVar] = $sValue;
			return true;
		}
		return false;
	}

	/**
	 * @param string $sVar
	 * @return null
	 */
	public function getVar($sVar) {
		if (array_key_exists($sVar, $this->aLocalVars)) {
			return $this->aLocalVars[$sVar];
		} else {
			return null;
		}
	}

	/**
	 *
	 * @see ProcessorI::delegateRequest()
	 * @param HttpRequestA $oHttpRequest
	 * @param ProcessorA $oNewProcessor
	 * @param HttpResponseA $oResponse

Should the type for parameter $oResponse not be null|HttpResponseA?

	 * @returns ModelA
	 */
	public function delegateRequest(HttpRequestA $oHttpRequest, ProcessorA $oNewProcessor, HttpResponseA $oResponse = null) {

The return type could not be reliably inferred; please add a @return annotation.

		$oDispatcher = vsc::getEnv()->getDispatcher();
		/** @var ClassMap $oMap */
		$oMap = $oDispatcher->getSiteMap()->findProcessorMap($oNewProcessor);

		if (MappingA::isValid($oMap)) {
			$oNewProcessor->setMap($oMap);
			$oNewProcessor->init();

			/* @var RwDispatcher $oDispatcher */
			$oMap->merge($this->getMap());

			if (HttpResponse::isValid($oResponse)) {
				$oMap->setResponse($oResponse);

It seems like $oResponse defined by parameter $oResponse on line 106 can be null; however, vsc\application\sitemaps\ProcessorMapTrait::setResponse() does not accept null, maybe add an additional type check?

			}

			$this->setMap($oMap);
		}
		$oNewProcessor->setLocalVars($this->getLocalVars(), true);

		return $oNewProcessor->handleRequest($oHttpRequest);
	}
}