RwDispatcher - Code Metrics - Inspection of "Fix version for scrutinizer" - mariusor/vsc - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 290674...0f9d71 )

by Marius
created 2018-04-25 09:12 UTC
RwDispatcher C

↳ Parent: Project
Complexity

Total Complexity
Size/Duplication

Total Lines	230
Duplicated Lines	0 %
Coupling/Cohesion

Components	1
Dependencies	20
Test Coverage

Coverage
81.73%
Importance

Changes
Metric	Value
dl	0
loc	230
ccs	85
cts	104
cp	0.8173
rs	5.3986
c	0
b	0
f	0
wmc	42
lcom	1
cbo	20
9 Methods

Rating	Name	Size	Complexity
A	getView()	1	1
C	getCurrentMap()	35	7
A	getCurrentModuleMap()	8	2
A	getCurrentProcessorMap()	7	2
B	getCurrentControllerMap()	26	6
B	getFrontController()	22	5
C	getProcessController()	58	14
A	loadSiteMap()	15	3
A	getTemplatePath()	11	2
How to fix Complexity

<?php
/**
 * Parses the current request into a valid Front Controller / Controller pair
 * @package presentation
 * @subpackage dispatchers
 * @author marius orcsik <[email protected]>
 * @date 09.09.24
 */
namespace vsc\application\dispatchers;

use vsc\application\controllers\FrontControllerA;
use vsc\application\controllers\Html5Controller;
use vsc\application\processors\ErrorProcessor;
use vsc\application\processors\NotFoundProcessor;
use vsc\application\processors\ProcessorA;
use vsc\application\processors\StaticFileProcessor;
use vsc\application\sitemaps\ClassMap;
use vsc\application\sitemaps\ErrorControllerMap;
use vsc\application\sitemaps\ErrorProcessorMap;
use vsc\application\sitemaps\ExceptionSitemap;
use vsc\application\sitemaps\MappingA;
use vsc\application\sitemaps\ModuleMap;
use vsc\application\sitemaps\RootMap;
use vsc\infrastructure\vsc;
use vsc\presentation\requests\RwHttpRequest;
use vsc\presentation\responses\ExceptionResponseError;
use vsc\presentation\responses\ExceptionResponseRedirect;
use vsc\ExceptionError;
use vsc\presentation\responses\HttpResponseType;

class RwDispatcher extends HttpDispatcherA {
	/**
	 * @param array $aMaps
	 * @throws ExceptionError
	 * @returns ClassMap
	 */
	static protected function getCurrentMap($aMaps, $sUri = null) {

		if (!is_array($aMaps) || empty($aMaps)) {
			return new ErrorProcessorMap();
		}

		if (is_null($sUri)) {
			$sUri = vsc::getEnv()->getHttpRequest()->getUri(true);
		}
		$aRegexes = array_keys($aMaps);

		$aMatches = array();
		foreach ($aRegexes as $sRegex) {
			$sFullRegex = '#' . str_replace('#', '\#', $sRegex) . '#iu'; // i for insensitive, u for utf8
			try {
				$iMatch = preg_match_all($sFullRegex, $sUri, $aMatches, PREG_SET_ORDER);
			} catch (ExceptionError $e) {
				$f = new ExceptionError(
					$e->getMessage() . '<br/> Offending regular expression: <span style="font-weight:normal">' . $sFullRegex . '</span>',
					$e->getCode());
				throw $f;
			}
			if ($iMatch) {
				$aMatches = array_shift($aMatches);
				$aMatches = array_slice($aMatches, 1);

				/* @var MappingA $oMapping */
				$oMapping = $aMaps[$sRegex];
				$oMapping->setTaintedVars($aMatches);
				$oMapping->setUrl($sUri);
				$oMapping->getModuleMap()->setUrl($sUri);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
				return $oMapping;
			}
		}
		return null;
	}

	/**
	 * @returns ModuleMap
	 * @throws ExceptionSitemap
	 */
	public function getCurrentModuleMap() {

		$oProcessorMap = $this->getCurrentProcessorMap();
		if (ClassMap::isValid($oProcessorMap)) {
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			return $this->getCurrentProcessorMap()->getModuleMap();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
		} else {
			return $this->getSiteMap()->getCurrentModuleMap();
		}
	}

	/**
	 * @returns ClassMap
	 * @throws ExceptionSitemap
	 * @throws ExceptionError
	 */
	public function getCurrentProcessorMap() {
		$oProcessorMap = self::getCurrentMap($this->getSiteMap()->getMaps());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		if (!ClassMap::isValid($oProcessorMap)) {
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			$oProcessorMap = new ErrorProcessorMap(NotFoundProcessor::class);
		}
		return $oProcessorMap;
	}

	/**
	 * @returns ClassMap
	 * @throws ExceptionError
	 */
	public function getCurrentControllerMap() {
 		$oProcessorMap = $this->getCurrentProcessorMap();

		$oCurrentMap = null;
		// check if the current processor has some set maps
		$aProcessorCtrlMaps = $oProcessorMap->getControllerMaps();
		if (count($aProcessorCtrlMaps) > 0) {
			$oCurrentMap = self::getCurrentMap($aProcessorCtrlMaps);
			if (ClassMap::isValid($oCurrentMap) && !ErrorControllerMap::isValid($oCurrentMap)) {
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
				return $oCurrentMap;
			}
		}

		$oCurrentModule = $oProcessorMap->getModuleMap();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
		// merging all controller maps found in the processor map's parent modules
		do {
			// check the current module for maps
			$aModuleCtrlMaps = $oCurrentModule->getControllerMaps();
			if (count($aModuleCtrlMaps) > 0) {
				$oCurrentMap = self::getCurrentMap($aModuleCtrlMaps);
			}
			$oCurrentModule = $oCurrentModule->getModuleMap();
		} while (!ClassMap::isValid($oCurrentMap));
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

		return $oCurrentMap;
	}

	/**
	 * @throws \vsc\application\sitemaps\ExceptionSitemap
	 * @throws \vsc\presentation\responses\ExceptionResponseError
	 * @returns FrontControllerA
	 */
	public function getFrontController() {
		if (!FrontControllerA::isValid($this->oController)) {
			$oControllerMapping = $this->getCurrentControllerMap();

			if (ClassMap::isValid($oControllerMapping)) {
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
				$sControllerName = $oControllerMapping->getPath();
			}

			if (empty($sControllerName)) {
				throw new ExceptionResponseError('Could not find the correct front controller', HttpResponseType::NOT_FOUND);
			}

			/* @var $this->oController FrontControllerA */
			$this->oController = new $sControllerName();
			if (FrontControllerA::isValid($this->oController)) {
				// adding the map to the controller, allows it to add resources (styles,scripts) from inside it
				$this->oController->setMap($oControllerMapping);
			}
		}

		return $this->oController;
	}

	/**
	 * (non-PHPdoc)
	 * @see vsc/presentation/dispatchers/HttpDispatcherA::getProcessController()
	 * @throws ExceptionSitemap
	 * @throws ExceptionResponseError
	 * @returns ProcessorA
	 */
	public function getProcessController() {
		if (!ProcessorA::isValid($this->oProcessor)) {
			$oProcessorMap = $this->getCurrentProcessorMap();
			if (!ClassMap::isValid($oProcessorMap)) {
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
				// this mainly means nothing was matched to our url, or no mappings exist, so we're falling back to 404
				$oProcessorMap = new ErrorProcessorMap(NotFoundProcessor::class, '.*');

				$oProcessorMap->setTemplatePath(VSC_SRC_PATH . 'templates');
				$oProcessorMap->setTemplate('404.php');
			}

			$sPath = $oProcessorMap->getPath();
			try {
				if (ClassMap::isValidMap($sPath) || (stristr(basename($sPath), '.') === false && !is_file($sPath))) {

					try {
						if (class_exists($sPath)) {
							$this->oProcessor = new $sPath();
						} else {
							$this->oProcessor = new NotFoundProcessor();
						}
					} catch (\Exception $e) {
						$this->oProcessor = new ErrorProcessor($e);
					}
				} elseif ($this->getSiteMap()->isValidStaticPath($sPath)) {
					// static stuff
					$this->oProcessor = new StaticFileProcessor();
					$this->oProcessor->setFilePath($sPath);
				} /*else {

					$this->oProcessor = new NotFoundProcessor();
				}*/

				if (ProcessorA::isValid($this->oProcessor)) {
					if (!(ErrorProcessor::isValid($this->oProcessor) && MappingA::isValid($this->oProcessor->getMap()))) {
						// @TODO: this should be a MappingA->merge() when the processor already has a map
						$this->oProcessor->setMap($oProcessorMap);
					}

					// setting the variables defined in the processor into the tainted variables
					/** @var RwHttpRequest $oRawRequest */
					$oRawRequest = $this->getRequest();
					if (RwHttpRequest::isValid($oRawRequest)) {
						$oRawRequest->setTaintedVars($this->oProcessor->getLocalVars()); // FIXME!!!
					}
				} else {
					// broken URL
					throw new ExceptionResponseError('Broken URL', 400);
				}
			} catch (ExceptionResponseRedirect $e) {
				// get the response
				$oResponse = vsc::getEnv()->getHttpResponse();
				$oResponse->setLocation($e->getLocation());
				ob_end_flush();
				$oResponse->outputHeaders();
			}
		}

		return $this->oProcessor;
	}

	/**
	 *
	 * @param string $sIncPath
	 * @throws \Exception
	 * @throws ExceptionSitemap
	 * @return boolean
	 */
	public function loadSiteMap($sIncPath) {
		try {
			// hic sunt leones
			/** @var ModuleMap $oMap */
			$oMap = $this->getSiteMap()->map('\A/', $sIncPath);
			if (count($oMap->getControllerMaps()) == 0) {
				$oMap->map('\A.*\Z', Html5Controller::class);
			}
		} catch (ExceptionSitemap $e) {
			// there was a faulty controller in the sitemap
			// this will probably result in a incomplete parsed sitemap tree
			throw ($e);
		}
		return true;
	}

	public function getView() {}

	public function getTemplatePath() {

		$aMaps = $this->getSiteMap()->getMaps();
$a = "a";
$ab = "ab";
$abc = "abc";
		$oProcessorMap = self::getCurrentMap($aMaps);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		if (ClassMap::isValid($oProcessorMap)) {
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
			$sPath = $oProcessorMap->getTemplatePath();
		} else {
			$sPath = $this->getCurrentControllerMap()->getTemplatePath();
		}
		return $sPath;
	}
}

GitHub Access Token became invalid

Push — master ( 290674...0f9d71 )

RwDispatcher C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Complexity

Complex Class

mariusor / vsc

GitHub Access Token became invalid

Push — master ( 290674...0f9d71 )

RwDispatcher C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like
