vsc\presentation\requests\RawHttpRequest

Complexity

Total Complexity

27

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

85%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	3
A	setRawVars()	0	9	3
B	getRawVars()	0	23	6
A	getRawVar()	0	8	3
A	getVars()	0	12	3
A	hasVar()	0	6	2
A	hasRawVar()	0	4	2
A	getVar()	0	7	2
A	getRawInput()	0	3	1
A	constructRawVars()	0	8	2

<?php
/**
 * @package presentation
 * @subpackage requests
 * @author marius orcsik <marius@habarnam.ro>
 * @date 2011.08.11
 */
namespace vsc\presentation\requests;

class RawHttpRequest extends RwHttpRequest {
	protected $aRawVars = [];
	protected $sRawInput;

	public function __construct() {
		parent::__construct();

		if (isset($_SERVER) && !$this->isGet()) {
			$this->constructRawVars();
		}
	}

	// this seems quite unsafe
	public function setRawVars($aVars) {
		if (is_array($aVars)) {
			if (is_array($this->aRawVars)) {
				$this->aRawVars = array_merge($aVars, $this->aRawVars);
			} else {
				$this->aRawVars = $aVars;
			}
		}
	}

	public function getRawVars() {
		if (!empty($this->aRawVars)) {
			return $this->aRawVars;
		}
		$sContentType = $this->getContentType();

		$vars = array();
		switch ($sContentType) {
		case 'application/x-www-form-urlencoded':
			parse_str($this->sRawInput, $vars);
			break;
		case 'application/json':
			$vars = json_decode($this->sRawInput, true);
			break;
		case 'application/xml':
		default:
			break;
		}
		if (!empty ($vars)) {
			$this->aRawVars = $vars;

It seems like $vars of type * is incompatible with the declared type array of property $aRawVars.

		}
		return $this->aRawVars;
	}

	/**
	 * @param string $sVarName
	 * @return mixed
	 */
	public function getRawVar($sVarName) {
		$aRawVars = $this->getRawVars();
		if (is_array($aRawVars) && array_key_exists($sVarName, $aRawVars)) {
			return self::getDecodedVar($aRawVars[$sVarName]);
		} else {
			return null;
		}
	}

	public function getVars() {
		$aRawVars = $this->getRawVars();
		$aParentVars = parent::getVars();
		if (!is_array($aRawVars)) {
			return parent::getVars();
		} else {
			if (is_array($aParentVars)) {
				return array_merge($aRawVars, $aParentVars);
			}
			return $aRawVars;
		}
	}

	public function hasVar($sVarName) {
		return (
			$this->hasRawVar($sVarName) ||
			parent::hasVar($sVarName)
		);
	}

	public function hasRawVar($sVarName) {
		$aRawVars = $this->getRawVars();
		return (is_array($aRawVars) && array_key_exists($sVarName, $aRawVars));
	}

	/**
	 * @param string $sVarName
	 * @return mixed
	 */
	public function getVar($sVarName) {
		$mValue = parent::getVar($sVarName);
		if (!$mValue) {
			$mValue = $this->getRawVar($sVarName);
		}
		return $mValue;
	}

	/**
	 * @return string
	 */
	protected function getRawInput() {
		return file_get_contents('php://input');
	}

	/**
	 * @todo this has to be moved in the rw url handler
	 * @param string $sRawInput

Should the type for parameter $sRawInput not be string|null?

	 * @return void
	 */
	protected function constructRawVars($sRawInput = null) {
		if (is_null($sRawInput)) {
			$this->sRawInput = $this->getRawInput();
		} else {
			$this->sRawInput = $sRawInput;
		}
		$this->aRawVars = null;

It seems like null of type null is incompatible with the declared type array of property $aRawVars.

	}
}