vsc\rest\application\processors\RESTProcessorA

Complexity

Total Complexity

12

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	6

Test Coverage

Coverage

86.67%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
	handleGet()	0	1	?
	handleHead()	0	1	?
	handlePost()	0	1	?
	handlePut()	0	1	?
	handleDelete()	0	1	?
A	getValidRequestMethods()	0	3	1
A	getValidContentTypes()	0	3	1
A	validRequestMethod()	0	3	1
A	validContentType()	0	3	1
B	handleRequest()	0	27	8

<?php
/**
 * A processor for RESTful calls
 *
 * @package application/processors
 * @author marius orcsik <marius@habarnam.ro>
 * @date 2013.10.04
 */
namespace vsc\rest\application\processors;

use vsc\application\processors\ProcessorA;
use vsc\infrastructure\vsc;
use vsc\presentation\requests\ContentType;
use vsc\presentation\requests\HttpRequestA;
use vsc\presentation\requests\HttpRequestTypes;
use vsc\presentation\requests\RawHttpRequest;
use vsc\presentation\responses\ExceptionResponseError;
use vsc\presentation\responses\HttpResponseType;

abstract class RESTProcessorA extends ProcessorA {
	protected $validRequestMethods = array( );

	public function getValidRequestMethods() {
		return $this->validRequestMethods;
	}

	protected $validContentTypes = array('*/*');

	public function getValidContentTypes() {
		return $this->validContentTypes;
	}

	public function validRequestMethod($sRequestMethod) {
		return (in_array($sRequestMethod, $this->getValidRequestMethods()));
	}

	public function validContentType($sContentType) {
		return ContentType::isAccepted($sContentType, $this->getValidContentTypes());
	}

	abstract public function handleGet(HttpRequestA $oRequest);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

	abstract public function handleHead(HttpRequestA $oRequest);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

	abstract public function handlePost(HttpRequestA $oRequest);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

	abstract public function handlePut(RawHttpRequest $oRequest);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

	abstract public function handleDelete(RawHttpRequest $oRequest);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

	/**
	 * @param HttpRequestA $oRequest
	 * @return \vsc\domain\models\ModelA
	 * @throws \vsc\presentation\responses\ExceptionResponseError
	 */
	public function handleRequest(HttpRequestA $oRequest) {
		if (!$oRequest->isGet() && !RawHttpRequest::isValid($oRequest)) {
			$oRequest = new RawHttpRequest();
			vsc::getEnv()->setHttpRequest($oRequest);
		}

		switch ($oRequest->getHttpMethod()) {
		case HttpRequestTypes::GET:
			$oModel = $this->handleGet($oRequest);
			break;
		case HttpRequestTypes::HEAD:
			$oModel = $this->handleHead($oRequest);
			break;
		case HttpRequestTypes::POST:
			$oModel = $this->handlePost($oRequest);
			break;
		case HttpRequestTypes::PUT:
			$oModel = $this->handlePut($oRequest);

$oRequest of type object<vsc\presentation\requests\HttpRequestA> is not a sub-type of object<vsc\presentation\requests\RawHttpRequest>. It seems like you assume a child class of the class vsc\presentation\requests\HttpRequestA to be always present.

			break;
		case HttpRequestTypes::DELETE:
			$oModel = $this->handleDelete($oRequest);

$oRequest of type object<vsc\presentation\requests\HttpRequestA> is not a sub-type of object<vsc\presentation\requests\RawHttpRequest>. It seems like you assume a child class of the class vsc\presentation\requests\HttpRequestA to be always present.

			break;
		default:
			throw new ExceptionResponseError('Method [' . $oRequest->getHttpMethod() . '] is unavailable.', HttpResponseType::METHOD_NOT_ALLOWED);
		}
		return $oModel;
	}
}