Maba\Bundle\RestBundle\Service\Annotation\ReflectionMethodWrapper

Complexity

Total Complexity

8

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getParameterByName()	0	14	3
A	getNonBuiltInTypeForParameter()	0	16	3
A	getFriendlyName()	0	8	1

<?php
declare(strict_types=1);

namespace Maba\Bundle\RestBundle\Service\Annotation;

use Maba\Bundle\RestBundle\Exception\ConfigurationException;
use ReflectionMethod;
use ReflectionParameter;

/**
 * @internal
 */
class ReflectionMethodWrapper
{
    private $reflectionMethod;

    public function __construct(ReflectionMethod $reflectionMethod)
    {
        $this->reflectionMethod = $reflectionMethod;
    }

    public function getParameterByName(string $name): ReflectionParameter
    {
        foreach ($this->reflectionMethod->getParameters() as $parameter) {
            if ($parameter->getName() === $name) {

Consider using $parameter->name. There is an issue with getName() and APC-enabled PHP versions.

                return $parameter;
            }
        }

        throw new ConfigurationException(sprintf(
            'Parameter %s is configured but not found in method %s',
            '$' . $name,
            $this->getFriendlyName()
        ));
    }

    public function getNonBuiltInTypeForParameter(string $name): string
    {
        $parameter = $this->getParameterByName($name);

        $type = $parameter->getType();
        if ($type === null || $type->isBuiltin()) {
            throw new ConfigurationException(sprintf(
                'Expected non built-in type-hint for %s in %s',
                '$' . $parameter->getName(),

Consider using $parameter->name. There is an issue with getName() and APC-enabled PHP versions.

                $this->getFriendlyName()
            ));
        }

        // `$type->getName()` should be used when 7.0 support is dropped
        return (string)$type;
    }

    public function getFriendlyName()
    {
        return sprintf(
            '%s::%s',
            $this->reflectionMethod->getDeclaringClass()->getName(),

Consider using $this->reflectionMethod->class. There is an issue with getName() and APC-enabled PHP versions.

            $this->reflectionMethod->getName()

Consider using $this->reflectionMethod->name. There is an issue with getName() and APC-enabled PHP versions.

        );
    }
}