Marcusgsta\Comment\CommentController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	186
Duplicated Lines	18.28 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

31.08%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	getComments()	0	31	4
A	getPostCreateComment()	17	17	1
B	getPostEditComment()	0	30	3
A	deleteComment()	17	17	1
A	getRole()	0	8	2
A	isEditable()	0	13	3

<?php

namespace Marcusgsta\Comment;

use \Anax\Configure\ConfigureInterface;
use \Anax\Configure\ConfigureTrait;
use \Anax\DI\InjectionAwareInterface;
use \Anax\DI\InjectionAwareTrait;
use \Marcusgsta\Comment\HTMLForm\EditCommentForm;
use \Marcusgsta\Comment\HTMLForm\CreateCommentForm;
use \Marcusgsta\Comment\HTMLForm\DeleteCommentForm;

/**
 * A controller class.
 */
class CommentController implements
    ConfigureInterface,
    InjectionAwareInterface
{
    use ConfigureTrait,
        InjectionAwareTrait;



    /**
     * @var $data description
     */
    //private $data;



    /**
     * Description.
     *
     * @param datatype $variable Description

There is no parameter named $variable. Was it maybe removed?

     *
     * @throws Exception
     *
     * @return void
     */
    public function getComments($test = "not_test")
    {
        //$route = $this->di->request->getRoute();

        $comment = new Comment();
        $comment->setDb($this->di->get("db"));

        $allComments = $comment->findAll();

        // filter array of comments to current page
        $newArray = array_filter($allComments, function ($obj) use ($test) {

            $route = $this->di->get("request")->getRoute();
            $route = empty($route) ? "index" : $route;

            // for testing purposes
            if ($test == "test") {
                $route = "index";
            }

            if ($obj->page != $route) {
                return false;
            }
            return true;
        });

        $data = [
            "items" => $newArray,
        ];
        return $data;
    }

    /**
     * Description.
     *
     * @param datatype $variable Description

There is no parameter named $variable. Was it maybe removed?

     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostCreateComment()

This method seems to be duplicated in your project.

    {
        $title      = "A create comment page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form       = new CreateCommentForm($this->di);

        $form->check();

        $data = [
            "content" => $form->getHTML(),
        ];

        $view->add("default2/article", $data);

        $pageRender->renderPage(["title" => $title]);
    }

    /**
     * Description.
     *
     * @param datatype $variable Description

There is no parameter named $variable. Was it maybe removed?

     *
     * @throws Exception
     *
     * @return void
     */
    public function getPostEditComment($key, $itemId)
    {
        $data = ["page" => $key, "commentid" => $itemId];

        $commentId = $data['commentid'];
        $loggedInUser = $this->di->session->get("user");
        $role = $this->getRole($loggedInUser);

        if ($role != 10) {
            if (!$this->isEditable($commentId, $loggedInUser)) {

The expression $this->isEditable($commentId, $loggedInUser) of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

                echo "Du har inte tillgång till att redigera denna kommentar.";
                return false;
            }
        }

        $title      = "An edit comment page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form       = new EditCommentForm($this->di, $data);

        $form->check();

        $data = [
            "content" => $form->getHTML(),
        ];

        $view->add("default2/article", $data);

        $pageRender->renderPage(["title" => $title]);
    }

    /**
     * Description.
     *
     * @param datatype $variable Description

There is no parameter named $variable. Was it maybe removed?

     *
     * @throws Exception
     *
     * @return void
     */
    public function deleteComment()

This method seems to be duplicated in your project.

    {
        $title      = "A delete comments page";
        $view       = $this->di->get("view");
        $pageRender = $this->di->get("pageRender");
        $form       = new DeleteCommentForm($this->di);

        $form->check();

        $data = [
            "content" => $form->getHTML(),
        ];

        $view->add("default2/article", $data);

        $pageRender->renderPage(["title" => $title]);
    }

    /**
    * get a user's role
    * @param string user's acronym
    *
    * @return integer user's role
    **/
    public function getRole($acronym)
    {
        $user = new \Anax\User\User();
        $user->setDb($this->di->get("db"));
        $user->find("acronym", $acronym);
        $role = isset($user->role) ? $user->role : null;

The property role does not seem to exist in Anax\User\User.

        return $role;
    }

    /**
    * check if logged in user can edit the comment
    * @param string commentid
    *
    * @return bool
    **/
    public function isEditable($commentId, $user)
    {
        $comment = new Comment;
        $comment->setDb($this->di->get("db"));
        $comment = $comment->find("id", $commentId);

        if ($comment) {

The expression $comment of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            if ($comment->acronym != $user) {
                return false;
            }
            return true;
        }
    }
}