Anax\User\HTMLForm\CreateUserForm

Complexity

Total Complexity

5

Size/Duplication

Total Lines	104
Duplicated Lines	35.58 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

50.94%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	callbackSubmit()	37	38	2
A	__construct()	0	50	3

<?php

namespace Anax\User\HTMLForm;

use \Anax\HTMLForm\FormModel;
use \Anax\DI\DIInterface;
use \Anax\User\User;

/**
 * Example of FormModel implementation.
 */
class CreateUserForm extends FormModel
{
    /**
     * Constructor injects with DI container.
     *
     * @param Anax\DI\DIInterface $di a service container
     */
    public function __construct(DIInterface $di)
    {
        parent::__construct($di);

        $editable = "hidden";
        $acronym = $this->di->session->get("user");

        if (isset($acronym)) {
            $role = $this->di->get("commentController")->getRole($acronym);
            if ($role == 10) {
                $editable = "text";
            }
        }

        $this->form->create(
            [
                "id" => __CLASS__,
                "legend" => "Create user",
            ],
            [
                "acronym" => [
                    "type"        => "text",
                ],

                "password" => [
                    "type"        => "password",
                ],

                "password-again" => [
                    "type"        => "password",
                    "validation" => [
                        "match" => "password"
                    ],
                ],
                "email" => [
                    "type"        => "text",
                ],
                "role" => [
                    "type"        => $editable,
                    "value"       => 1,
                ],

                "submit" => [
                    "type" => "submit",
                    "value" => "Create user",
                    "callback" => [$this, "callbackSubmit"]
                ],
            ]
        );
    }


    /**
    * Callback for submit-button which should return true if it could
    * carry out its work and false if something failed.
    *
    * @return boolean true if okey, false if something went wrong.
    */
    public function callbackSubmit()

This method seems to be duplicated in your project.

    {
    // Get values from the submitted form

        $acronym       = $this->form->value("acronym");
        $password      = $this->form->value("password");
        $passwordAgain = $this->form->value("password-again");
        $email         = $this->form->value("email");
        $role          = $this->form->value("role");

        // Check password matches
        if ($password !== $passwordAgain) {
            $this->form->rememberValues();
            $this->form->addOutput("Password did not match.");
            return false;
        }

        // Save to database
        // $db = $this->di->get("db");
        // $password = password_hash($password, PASSWORD_DEFAULT);
        // $db->connect()
        //    ->insert("User", ["acronym", "password"])
        //    ->execute([$acronym, $password]);
        $user = new User();
        $user->setDb($this->di->get("db"));
        $user->acronym = $acronym;
        $user->email = $email;
        $user->role = $role;

The property role does not seem to exist in Anax\User\User.

        // create gravatar from email
        $gravatar = $user->gravatar($email);
        $user->gravatar = $gravatar;

        $user->setPassword($password);
        $user->save();

        $this->form->addOutput("User was created.");
        return true;
    }
}