Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
22 | View Code Duplication | class UnexpectedTypeException extends InvalidArgumentException |
|
|
|||
23 | { |
||
24 | /** |
||
25 | * Creates a new exception for the given value type. |
||
26 | * |
||
27 | * @param string $type The name of the expected type. |
||
28 | * @param mixed $value The specified value. |
||
29 | * @param int $code The exception code. |
||
30 | * @param Exception|null $cause The exception that caused this exception. |
||
31 | * |
||
32 | * @return UnexpectedTypeException The new exception. |
||
33 | */ |
||
34 | 2 | public static function forType($type, $value, $code = 0, Exception $cause = null) |
|
46 | } |
||
47 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.