Marcosh\PhpValidationDSL\Basic\IsNotNull

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	2
A	withTranslator()	0	4	1

<?php

declare(strict_types=1);

namespace Marcosh\PhpValidationDSL\Basic;

use Marcosh\PhpValidationDSL\Result\ValidationResult;
use Marcosh\PhpValidationDSL\Translator\Translator;
use Marcosh\PhpValidationDSL\Validation;
use function is_callable;

final class IsNotNull extends ComposingAssertion implements Validation
{
    public const NOT_NOT_NULL = 'is-not-null.not-not-null';

    public function __construct(?callable $errorFormatter = null)
    {
        $this->isAsAsserted = IsAsAsserted::withAssertionAndErrorFormatter(
            function ($data) {
                return null !== $data;
            },
            is_callable($errorFormatter) ?

It seems like is_callable($errorFormatter) ? $errorFormatter : function(...) { /* ... */ } can also be of type null; however, parameter $errorFormatter of Marcosh\PhpValidationDSL\Basic\IsAsAsserted::withAssertionAndErrorFormatter() does only seem to accept callable, maybe add an additional type check?

                $errorFormatter :
                function ($data) {

The parameter $data is not used and could be removed.

                    return [self::NOT_NOT_NULL];
                }
        );
    }

    public static function withTranslator(Translator $translator): self
    {
        return new self(function ($data) use ($translator) {

The parameter $data is not used and could be removed.

            return [$translator->translate(self::NOT_NOT_NULL)];
        });
    }
}