Conditions | 11 |
Paths | 67 |
Total Lines | 17 |
Code Lines | 13 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
56 | public function typeDoesNotCoincideWithDocBlock(): bool |
||
57 | { |
||
58 | $docBlockTypes = $this->docBlockTypes(); |
||
59 | |||
60 | return !empty($docBlockTypes) && |
||
61 | $this->parameter->getTypeHint() instanceof Type && |
||
62 | !in_array($this->parameter->getTypeHint(), $docBlockTypes, false) && |
||
63 | !($this->parameter->getTypeHint() instanceof Array_ && $docBlockTypes[0] instanceof Array_) && |
||
64 | !($this->parameter->getTypeHint() instanceof Self_ && |
||
65 | $docBlockTypes[0] instanceof Object_ && |
||
66 | $this->parameter->getDeclaringClass()->getName() === ltrim((string) $docBlockTypes[0]->getFqsen(), '\\') |
||
67 | ) && |
||
68 | !($this->parameter->getTypeHint() instanceof Object_ && |
||
69 | $docBlockTypes[0] instanceof Self_ && |
||
70 | $this->parameter->getDeclaringClass()->getName() === ltrim((string) $this->parameter->getTypeHint()->getFqsen(), '\\') |
||
71 | ); |
||
72 | } |
||
73 | } |
||
74 |