MJanssen\Route\Factory::fromArray()

Complexity

Conditions	10
Paths	35

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function fromArray(array $route)
    {
        if (!isset($route['pattern'])) {
            throw new InvalidArgumentException('Required parameter pattern is not set.');
        }

        if (!isset($route['method'])) {
            throw new InvalidArgumentException('Required parameter method is not set.');
        }

        if (!isset($route['controller'])) {
            throw new InvalidArgumentException('Required parameter controller is not set.');
        }

        if (isset($route['value']) && !is_array($route['value'])) {
            $route['value'] = [];
        }

        $methods = !is_array($route['method']) ? [$route['method']] : $route['method'];
        $assert = isset($route['assert']) ? $route['assert'] : [];
        $value = isset($route['value']) ? $route['value'] : [];
        $name = isset($route['name']) ? $route['name'] : '';

        return new Route(
            new Methods($methods),
            new Pattern($route['pattern']),
            new Controller($route['controller']),
            new Asserts($assert),
            new Values($value),
            new Name($name)

It seems like $name defined by isset($route['name']) ? $route['name'] : '' on line 35 can also be of type array; however, MJanssen\Route\Name::__construct() does only seem to accept string, maybe add an additional type check?

        );
    }
}