BaseModelController::getFields() - Code Metrics - Inspection of "= Autopublish trait" - marcmascarell/laravel-artificer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 917cb5...992eab )

by Marc

created 2016-06-19 10:18 UTC

BaseModelController::getFields() B

↳ Parent: BaseModelController

Complexity

Conditions	4
Paths	4

Size

Total Lines	26
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	0	Features	0

Metric	Value
c	6
b	0
f	0
dl	0
loc	26
rs	8.5806
cc	4
eloc	13
nc	4
nop	1

<?php namespace Mascame\Artificer\Http\Controllers;

use App;
use Auth;
use File;
use Illuminate\Database\Eloquent\Collection;
use Illuminate\Routing\Redirector;
use Illuminate\Routing\Router;
use Illuminate\Support\Str;
use Illuminate\Support\Facades\Input;
use Mascame\Artificer\Fields\FieldFactory;
use Mascame\Formality\Parser\Parser;
use Mascame\Artificer\Permit\ModelPermit;
use Redirect;
use Route;
use Session;
use Validator;
use View;


class BaseModelController extends BaseController
{

    /**
     * The Eloquent model instance
     * @var \Eloquent
     */
    protected $model;

    /**
     *
     */
    public function __construct()
    {
        parent::__construct();

        // Todo: Do Sth with this
        if (false) {
            if (! Auth::check() || ! ModelPermit::access()) {
                App::abort('403', 'Forbidden access');
            }
        }

        $this->model = $this->modelObject->model;


        $this->checkPermissions();
    }

    /**
     *
     */
    protected function checkPermissions()
    {
        $permit = array(
            'read' => ModelPermit::to('read'),
            'create' => ModelPermit::to('create'),
            'update' => ModelPermit::to('update'),
            'delete' => ModelPermit::to('delete'),
        );

        ModelPermit::routeAction(Route::currentRouteName());

        View::share('permit', $permit);
    }

    /**
     * @param $data
     */
    protected function handleData($data)
    {
        $this->data = $data;

        $this->getFields($data);

        View::share('data', $this->data);
    }

    /**
     * @param $data
     * @return null
     */
    protected function getFields($data)

    {
        if ($this->fields) return $this->fields;

        /**
         * @var $data Collection
         */
        $modelFields = $this->modelObject->getOption('fields');
        $types = config('admin.fields.types');
        $fields = [];

        foreach ($this->modelObject->columns as $column) {
            $options = [];

            if (isset($modelFields[$column])) $options = $modelFields[$column];

            $fields[$column] = $options;
        }

        $fieldFactory = new FieldFactory(new Parser($types), $types, $fields, config('admin.fields.classmap'));
        $this->fields = $fieldFactory->makeFields();

        View::share('fields', $this->fields);

        return $this->fields;
    }

    // Prepares fields for factory
//    protected function prepareFields($data) {
//        $fields = [];
//
//        foreach ($data as $key => $item) {
//            foreach ($this->modelObject->columns as $column) {
//                $fields[$key][$column] = $item->$column;
//            }
//        }
//
//        return $fields;
//    }

    /**
     * @return array
     */
    protected function getSort()
    {
        $sort = array();

        if (Input::has('sort_by')) {
            $sort['column'] = Input::get('sort_by');
            $sort['direction'] = Input::get('direction');
        } else {

            if ($this->modelObject->schema->hasColumn('sort_id')) {
                $sort['column'] = 'sort_id';
            } else {
                $sort['column'] = 'id';
            }

            $sort['direction'] = 'asc';
        }

        return $sort;
    }

    /**
     * @return array
     */
    protected function getRules()
    {
        if (isset($this->options['rules'])) {
            return $this->options['rules'];
        } else {
            if (isset($this->model->rules)) {
                return $this->model->rules;
            }
        }

        return array();
    }

    /**
     * @param $items
     * @return null
     */
    public static function getCurrentModelId($items)
    {
        return (isset($items->id)) ? $items->id : null;
    }

    /**
     * @return array|mixed
     */
    protected function filterInputData()
    {
        if ($this->modelObject->hasGuarded()) {
            $input = Input::all();
            $filtered_input = array();

            foreach ($input as $key => $value) {
                if (in_array($key, $this->modelObject->columns)) {
                    $filtered_input[$key] = $value;
                }
            }

            return $this->except($this->modelObject->getOption('guarded'), $filtered_input);
        }

        return Input::except('id');
    }

    /**
     * @param $keys
     * @param $values
     * @return mixed
     */
    protected function except($keys, $values)
    {
        $keys = is_array($keys) ? $keys : func_get_args();

        $results = $values;

        array_forget($results, $keys);

        return $results;
    }

    /**
     * @param $data
     * @return array
     */
    protected function handleFiles($data)
    {
        $new_data = array();
        $fields = $this->getFields($data);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

        if (!is_null($fields)) {
            foreach ($fields as $field) {
                if ($this->isFileInput($field->type)) {
                    if (Input::hasFile($field->name)) {
                        $new_data[$field->name] = $this->uploadFile($field->name);
                    } else {
                        unset($data[$field->name]);
                    }
                }
            }
        }

        return array_merge($data, $new_data);
    }

    /**
     * @param $type
     * @return bool
     */
    protected function isFileInput($type)
    {
        return ($type == 'file' || $type == 'image');
    }

    /**
     * This is used for simple upload (no plugins)
     *
     * @param $fieldName
     * @param null $path
     * @return string
     */
    protected function uploadFile($fieldName, $path = null)
    {
        if (!$path) {
            $path = public_path() . '/uploads/';
        }

        $file = Input::file($fieldName);

        if (!file_exists($path)) {
            File::makeDirectory($path);
        }

        $name = uniqid() . '-' . Str::slug($file->getFilename()) . '.' . $file->guessExtension();

        $file->move($path, $name);

        return $name;
    }

    /**
     * @param $modelName
     * @param $id
     * @param $field
     * @return null
     */
    protected function getRelatedFieldOutput($modelName, $id, $field)

    {
        if ($id != 0) {
            $this->handleData($this->model->with($this->modelObject->getRelations())->findOrFail($id));
        } else {
            if (Session::has('_set_relation_on_create_' . $this->modelObject->name)) {
                $relateds = Session::get('_set_relation_on_create_' . $this->modelObject->name);
                $related_ids = array();
                foreach ($relateds as $related) {
                    $related_ids[] = $related['id'];
                }

                $data = $relateds[0]['modelClass']::whereIn('id', $related_ids)->get();

                $this->handleData($data);
            } else {
                return null;
            }
        }

        return $this->fields[$field]->output();
    }

    /**
     * @param $validator
     * @param string $route
     * @return $this
     */
    protected function redirect($validator, $route, $id = null)
    {
        if (Input::has('_standalone')) {
            $routeParams = array('slug' => Input::get('_standalone'));

            if ($id) {
                $routeParams['id'] = $id;
            }

            return Redirect::route($route, $routeParams)

                ->withErrors($validator)
                ->withInput();
        }

        return Redirect::back()->withErrors($validator)->withInput();

    }

    /**
     * @param $data
     * @return \Illuminate\Validation\Validator
     */
    protected function validator($data)
    {
        return Validator::make($data, $this->getRules());
    }

    /**
     * @param $modelName
     * @param null $data
     * @param $sort
     * @return $this
     */
    protected function all($modelName, $data = null, $sort)
    {
        $this->handleData($data);

        return View::make($this->getView('all'))
            ->with('items', $this->data)
            ->with('sort', $sort);
    }
}

1			<?php namespace Mascame\Artificer\Http\Controllers;
2
3			use App;
4			use Auth;
5			use File;
6			use Illuminate\Database\Eloquent\Collection;
7			use Illuminate\Routing\Redirector;
8			use Illuminate\Routing\Router;
9			use Illuminate\Support\Str;
10			use Illuminate\Support\Facades\Input;
11			use Mascame\Artificer\Fields\FieldFactory;
12			use Mascame\Formality\Parser\Parser;
13			use Mascame\Artificer\Permit\ModelPermit;
14			use Redirect;
15			use Route;
16			use Session;
17			use Validator;
18			use View;
19
20
21			class BaseModelController extends BaseController
22			{
23
24			/**
25			* The Eloquent model instance
26			* @var \Eloquent
27			*/
28			protected $model;
29
30			/**
31			*
32			*/
33			public function __construct()
34			{
35			parent::__construct();
36
37			// Todo: Do Sth with this
38			if (false) {
39			if (! Auth::check() \|\| ! ModelPermit::access()) {
40			App::abort('403', 'Forbidden access');
41			}
42			}
43
44			$this->model = $this->modelObject->model;
			0 ignored issues – show Documentation Bug introduced 2016-04-02 22:07 UTC by Report Bug Copy Issue Report It seems like `$this->modelObject->model` of type `object<Illuminate\Database\Eloquent\Model>` is incompatible with the declared type `object<Eloquent>` of property `$model`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
45
46			$this->checkPermissions();
47			}
48
49			/**
50			*
51			*/
52			protected function checkPermissions()
53			{
54			$permit = array(
55			'read' => ModelPermit::to('read'),
56			'create' => ModelPermit::to('create'),
57			'update' => ModelPermit::to('update'),
58			'delete' => ModelPermit::to('delete'),
59			);
60
61			ModelPermit::routeAction(Route::currentRouteName());
62
63			View::share('permit', $permit);
64			}
65
66			/**
67			* @param $data
68			*/
69			protected function handleData($data)
70			{
71			$this->data = $data;
72
73			$this->getFields($data);
74
75			View::share('data', $this->data);
76			}
77
78			/**
79			* @param $data
80			* @return null
81			*/
82			protected function getFields($data)
			0 ignored issues – show Unused Code introduced 2016-03-29 06:13 UTC by Report Bug Copy Issue Report The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
83			{
84			if ($this->fields) return $this->fields;
85
86			/**
87			* @var $data Collection
88			*/
89			$modelFields = $this->modelObject->getOption('fields');
90			$types = config('admin.fields.types');
91			$fields = [];
92
93			foreach ($this->modelObject->columns as $column) {
94			$options = [];
95
96			if (isset($modelFields[$column])) $options = $modelFields[$column];
97
98			$fields[$column] = $options;
99			}
100
101			$fieldFactory = new FieldFactory(new Parser($types), $types, $fields, config('admin.fields.classmap'));
102			$this->fields = $fieldFactory->makeFields();
103
104			View::share('fields', $this->fields);
105
106			return $this->fields;
107			}
108
109			// Prepares fields for factory
110			// protected function prepareFields($data) {
111			// $fields = [];
112			//
113			// foreach ($data as $key => $item) {
114			// foreach ($this->modelObject->columns as $column) {
115			// $fields[$key][$column] = $item->$column;
116			// }
117			// }
118			//
119			// return $fields;
120			// }
121
122			/**
123			* @return array
124			*/
125			protected function getSort()
126			{
127			$sort = array();
128
129			if (Input::has('sort_by')) {
130			$sort['column'] = Input::get('sort_by');
131			$sort['direction'] = Input::get('direction');
132			} else {
133
134			if ($this->modelObject->schema->hasColumn('sort_id')) {
135			$sort['column'] = 'sort_id';
136			} else {
137			$sort['column'] = 'id';
138			}
139
140			$sort['direction'] = 'asc';
141			}
142
143			return $sort;
144			}
145
146			/**
147			* @return array
148			*/
149			protected function getRules()
150			{
151			if (isset($this->options['rules'])) {
152			return $this->options['rules'];
153			} else {
154			if (isset($this->model->rules)) {
155			return $this->model->rules;
156			}
157			}
158
159			return array();
160			}
161
162			/**
163			* @param $items
164			* @return null
165			*/
166			public static function getCurrentModelId($items)
167			{
168			return (isset($items->id)) ? $items->id : null;
169			}
170
171			/**
172			* @return array\|mixed
173			*/
174			protected function filterInputData()
175			{
176			if ($this->modelObject->hasGuarded()) {
177			$input = Input::all();
178			$filtered_input = array();
179
180			foreach ($input as $key => $value) {
181			if (in_array($key, $this->modelObject->columns)) {
182			$filtered_input[$key] = $value;
183			}
184			}
185
186			return $this->except($this->modelObject->getOption('guarded'), $filtered_input);
187			}
188
189			return Input::except('id');
190			}
191
192			/**
193			* @param $keys
194			* @param $values
195			* @return mixed
196			*/
197			protected function except($keys, $values)
198			{
199			$keys = is_array($keys) ? $keys : func_get_args();
200
201			$results = $values;
202
203			array_forget($results, $keys);
204
205			return $results;
206			}
207
208			/**
209			* @param $data
210			* @return array
211			*/
212			protected function handleFiles($data)
213			{
214			$new_data = array();
215			$fields = $this->getFields($data);
			0 ignored issues – show Bug introduced 2016-02-25 21:36 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$fields` is correct as `$this->getFields($data)` (which targets `Mascame\Artificer\Http\C...Controller::getFields()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
216
217			if (!is_null($fields)) {
218			foreach ($fields as $field) {
219			if ($this->isFileInput($field->type)) {
220			if (Input::hasFile($field->name)) {
221			$new_data[$field->name] = $this->uploadFile($field->name);
222			} else {
223			unset($data[$field->name]);
224			}
225			}
226			}
227			}
228
229			return array_merge($data, $new_data);
230			}
231
232			/**
233			* @param $type
234			* @return bool
235			*/
236			protected function isFileInput($type)
237			{
238			return ($type == 'file' \|\| $type == 'image');
239			}
240
241			/**
242			* This is used for simple upload (no plugins)
243			*
244			* @param $fieldName
245			* @param null $path
246			* @return string
247			*/
248			protected function uploadFile($fieldName, $path = null)
249			{
250			if (!$path) {
251			$path = public_path() . '/uploads/';
252			}
253
254			$file = Input::file($fieldName);
255
256			if (!file_exists($path)) {
257			File::makeDirectory($path);
258			}
259
260			$name = uniqid() . '-' . Str::slug($file->getFilename()) . '.' . $file->guessExtension();
261
262			$file->move($path, $name);
263
264			return $name;
265			}
266
267			/**
268			* @param $modelName
269			* @param $id
270			* @param $field
271			* @return null
272			*/
273			protected function getRelatedFieldOutput($modelName, $id, $field)
			0 ignored issues – show Unused Code introduced 2016-02-25 21:36 UTC by Report Bug Copy Issue Report The parameter `$modelName` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
274			{
275			if ($id != 0) {
276			$this->handleData($this->model->with($this->modelObject->getRelations())->findOrFail($id));
277			} else {
278			if (Session::has('_set_relation_on_create_' . $this->modelObject->name)) {
279			$relateds = Session::get('_set_relation_on_create_' . $this->modelObject->name);
280			$related_ids = array();
281			foreach ($relateds as $related) {
282			$related_ids[] = $related['id'];
283			}
284
285			$data = $relateds[0]['modelClass']::whereIn('id', $related_ids)->get();
286
287			$this->handleData($data);
288			} else {
289			return null;
290			}
291			}
292
293			return $this->fields[$field]->output();
294			}
295
296			/**
297			* @param $validator
298			* @param string $route
299			* @return $this
300			*/
301			protected function redirect($validator, $route, $id = null)
302			{
303			if (Input::has('_standalone')) {
304			$routeParams = array('slug' => Input::get('_standalone'));
305
306			if ($id) {
307			$routeParams['id'] = $id;
308			}
309
310			return Redirect::route($route, $routeParams)
			0 ignored issues – show Bug introduced 2016-02-25 21:36 UTC by Report Bug Copy Issue Report The method `route()` does not seem to exist on `object<redirect>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
311			->withErrors($validator)
312			->withInput();
313			}
314
315			return Redirect::back()->withErrors($validator)->withInput();
			0 ignored issues – show Bug introduced 2016-02-25 21:36 UTC by Report Bug Copy Issue Report The method `back()` does not seem to exist on `object<redirect>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
316			}
317
318			/**
319			* @param $data
320			* @return \Illuminate\Validation\Validator
321			*/
322			protected function validator($data)
323			{
324			return Validator::make($data, $this->getRules());
325			}
326
327			/**
328			* @param $modelName
329			* @param null $data
330			* @param $sort
331			* @return $this
332			*/
333			protected function all($modelName, $data = null, $sort)
334			{
335			$this->handleData($data);
336
337			return View::make($this->getView('all'))
338			->with('items', $this->data)
339			->with('sort', $sort);
340			}
341			}

marcmascarell / laravel-artificer

Push — dev ( 917cb5...992eab )

BaseModelController::getFields() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like