Relationable::getRelatedModel() - Code Metrics - Inspection of "= Starting reworking relation fields" - marcmascarell/laravel-artificer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 726aeb...0f045d )

by Marc

created 2016-04-03 20:00 UTC

Relationable::getRelatedModel() A

↳ Parent: Relationable

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	3
eloc	6
nc	3
nop	0

<?php namespace Mascame\Artificer\Fields;

trait Relationable
{
    private $relationOptions = null;

    public function getMethod()
    {
        return $this->getRelationAttribute('method');
    }

    public function getRelatedModel()
    {
        if ($this->relatedModel) return $this->relatedModel;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $modelName = $this->getRelationAttribute('model');

        if (isset($this->modelObject->schema->models[$modelName])) {
            return $this->relatedModel = $this->modelObject->schema->models[$modelName];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        throw new \Exception("Couldn't find the related model for '{$this->getName()}''");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function getType()
    {
        $type = $this->getRelationAttribute('type');

        if ($type) return $type;

        $pieces = explode('\\', get_called_class());

        return end($pieces);
    }

    public function getForeignKey()
    {
        return $this->getRelationAttribute('foreign');
    }

    public function getShow()
    {
        return $this->getRelationAttribute('show');
    }

    private function getRelationOptions() {
        if ($this->relationOptions) return $this->relationOptions;

        return $this->relationOptions = $this->getOption('relationship');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * @param string $attribute
     */
    public function getRelationAttribute($attribute)
    {
        $options = $this->getRelationOptions();

        return isset($options[$attribute]) ? $options[$attribute] : false;
    }
}

1			<?php namespace Mascame\Artificer\Fields;
2
3			trait Relationable
4			{
5			private $relationOptions = null;
6
7			public function getMethod()
8			{
9			return $this->getRelationAttribute('method');
10			}
11
12			public function getRelatedModel()
13			{
14			if ($this->relatedModel) return $this->relatedModel;
			0 ignored issues – show Bug introduced 2016-04-03 20:02 UTC by Report Bug Copy Issue Report The property `relatedModel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15
16			$modelName = $this->getRelationAttribute('model');
17
18			if (isset($this->modelObject->schema->models[$modelName])) {
19			return $this->relatedModel = $this->modelObject->schema->models[$modelName];
			0 ignored issues – show Bug introduced 2016-04-03 20:02 UTC by Report Bug Copy Issue Report The property `modelObject` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			}
21
22			throw new \Exception("Couldn't find the related model for '{$this->getName()}''");
			0 ignored issues – show Bug introduced 2016-04-03 20:02 UTC by Report Bug Copy Issue Report It seems like `getName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
23			}
24
25			public function getType()
26			{
27			$type = $this->getRelationAttribute('type');
28
29			if ($type) return $type;
30
31			$pieces = explode('\\', get_called_class());
32
33			return end($pieces);
34			}
35
36			public function getForeignKey()
37			{
38			return $this->getRelationAttribute('foreign');
39			}
40
41			public function getShow()
42			{
43			return $this->getRelationAttribute('show');
44			}
45
46			private function getRelationOptions() {
47			if ($this->relationOptions) return $this->relationOptions;
48
49			return $this->relationOptions = $this->getOption('relationship');
			0 ignored issues – show Bug introduced 2016-04-03 20:02 UTC by Report Bug Copy Issue Report It seems like `getOption()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
50			}
51
52			/**
53			* @param string $attribute
54			*/
55			public function getRelationAttribute($attribute)
56			{
57			$options = $this->getRelationOptions();
58
59			return isset($options[$attribute]) ? $options[$attribute] : false;
60			}
61			}

marcmascarell / laravel-artificer

Push — dev ( 726aeb...0f045d )

Relationable::getRelatedModel() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like