DynamicType::getType() - Code Metrics - Inspection of "Type upgrade" - marcioAlmada/annotations - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#65)

unknown

created 2017-04-29 21:22 UTC

DynamicType::getType() A

↳ Parent: DynamicType

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php

namespace Minime\Annotations\Types;

class DynamicType extends AbstractType
{
    /**
     * @var TypeInterface
     */
    private static $instance;

    public static function getType()
    {
        if (!isset(self::$instance)) {
            self::$instance = new DynamicType();

        }

        return self::$instance;

    }

    /**
     * Parse a given undefined type value
     *
     * @param  string $value
     * @param  null   $annotation Unused
     * @return mixed
     */
    public function parse($value, $annotation = null)
    {
        if ('' === $value) return true; // implicit boolean

        $json = JsonType::jsonDecode($value);

        if (JSON_ERROR_NONE === json_last_error()) {
            return $json;
        }
        elseif (false !== ($int = filter_var($value, FILTER_VALIDATE_INT))) {
            return $int;
        }
        elseif (false !== ($float = filter_var($value, FILTER_VALIDATE_FLOAT))) {
            return $float;
        }

        return $value;
    }

}


1			<?php
2
3			namespace Minime\Annotations\Types;
4
5			class DynamicType extends AbstractType
6			{
7			/**
8			* @var TypeInterface
9			*/
10			private static $instance;
11
12			public static function getType()
13			{
14			if (!isset(self::$instance)) {
15			self::$instance = new DynamicType();
			0 ignored issues – show Documentation Bug introduced 2017-04-29 21:24 UTC by Report Bug Copy Issue Report It seems like `new \Minime\Annotations\Types\DynamicType()` of type `object<Minime\Annotations\Types\DynamicType>` is incompatible with the declared type `object<Minime\Annotations\Types\TypeInterface>` of property `$instance`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
16			}
17
18			return self::$instance;
			0 ignored issues – show Bug Compatibility introduced 2017-04-29 21:24 UTC by Report Bug Copy Issue Report The expression `self::$instance;` of type `Minime\Annotations\Types...ons\Types\TypeInterface` adds the type `Minime\Annotations\Types\TypeInterface` to the return on line 18 which is incompatible with the return type declared by the abstract method `Minime\Annotations\Types\AbstractType::getType` of type `Minime\Annotations\Interfaces\TypeInterface`. Loading history...
19			}
20
21			/**
22			* Parse a given undefined type value
23			*
24			* @param string $value
25			* @param null $annotation Unused
26			* @return mixed
27			*/
28			public function parse($value, $annotation = null)
29			{
30			if ('' === $value) return true; // implicit boolean
31
32			$json = JsonType::jsonDecode($value);
33
34			if (JSON_ERROR_NONE === json_last_error()) {
35			return $json;
36			}
37			elseif (false !== ($int = filter_var($value, FILTER_VALIDATE_INT))) {
38			return $int;
39			}
40			elseif (false !== ($float = filter_var($value, FILTER_VALIDATE_FLOAT))) {
41			return $float;
42			}
43
44			return $value;
45			}
46
47			}
48

marcioAlmada / annotations

GitHub Access Token became invalid

Pull Request — master (#65)

DynamicType::getType() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like