Issues in routes.php (master) - Issues in master - marcinlawnik/shamir-secret-sharing-web - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/routes.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

use Illuminate\Http\Request as Request;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use TQ\Shamir\Secret;

$app->get('/', function () use ($app) {
    return view(
        'index',
        [
            'version' => $app->version(),
            'status'  => null,
        ]
    );
});

$app->post('/', function (Request $request) use ($app) {
    $response = 'An error ocurred';

    // Set up post values

    $action = $request->input('action');

    // Check if action was sent

    if (!isset($action) || trim($action) == '') {
        throw new \Exception('No action specified.');
    }

    // Share

    if ($action === 'share') {
        $sharesThreshold = (string) $request->input('shares_threshold');
        $sharesAmount = (string) $request->input('shares_amount');
        $secret = (string) $request->input('secret');
        try {
            //Check if fields are not empty
            $fields = [
                'secret',
                'shares_amount',
                'shares_threshold',
            ];
            foreach ($fields as $field) {
                $fieldValue = $request->input($field);
                if (!isset($fieldValue) || trim($fieldValue) == '') {
                    throw new \Exception('All of the fields are required.');
                }
            }

            if (!filter_var($sharesThreshold, FILTER_VALIDATE_INT)
                || !filter_var($sharesAmount, FILTER_VALIDATE_INT)) {
                throw new \Exception('The threshold and amount of shares must be integers.');
            }

            if ($sharesThreshold > $sharesAmount) {
                throw new \Exception('The threshold must be lower than or equal to the amount of shares.');
            }

            $status = 'success';
            $response = Secret::share(
                $secret,
                $sharesAmount,
                $sharesThreshold
            );
        } catch (Exception $exception) {
            $status = 'error';
            $response = $exception->getMessage();
        }
    }

    // Recover

    if ($action === 'recover') {
        $shares = $request->input('shares');
        try {
            $status = 'success';
            $response = Secret::recover(array_filter($shares));
        } catch (Exception $exception) {
            $status = 'error';
            $response = $exception->getMessage();
        }
    }

    // Return response
    return view(
        'index',
        [
            'version'        => $app->version(),
            'action'         => $action,
            'status'         => (empty($status)) ? null : $status,
            'response'       => json_encode($response),
            'shareAmount'    => (empty($sharesAmount)) ? null : $sharesAmount,
            'shareThreshold' => (empty($sharesThreshold)) ? null : $sharesThreshold,
        ]
    );
});


1			<?php
2
3			use Illuminate\Http\Request as Request;
			0 ignored issues – show Bug introduced 2016-06-26 19:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Request`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
4			use TQ\Shamir\Secret;
5
6			$app->get('/', function () use ($app) {
7			return view(
8			'index',
9			[
10			'version' => $app->version(),
11			'status' => null,
12			]
13			);
14			});
15
16			$app->post('/', function (Request $request) use ($app) {
17			$response = 'An error ocurred';
18
19			// Set up post values
20
21			$action = $request->input('action');
22
23			// Check if action was sent
24
25			if (!isset($action) \|\| trim($action) == '') {
26			throw new \Exception('No action specified.');
27			}
28
29			// Share
30
31			if ($action === 'share') {
32			$sharesThreshold = (string) $request->input('shares_threshold');
33			$sharesAmount = (string) $request->input('shares_amount');
34			$secret = (string) $request->input('secret');
35			try {
36			//Check if fields are not empty
37			$fields = [
38			'secret',
39			'shares_amount',
40			'shares_threshold',
41			];
42			foreach ($fields as $field) {
43			$fieldValue = $request->input($field);
44			if (!isset($fieldValue) \|\| trim($fieldValue) == '') {
45			throw new \Exception('All of the fields are required.');
46			}
47			}
48
49			if (!filter_var($sharesThreshold, FILTER_VALIDATE_INT)
50			\|\| !filter_var($sharesAmount, FILTER_VALIDATE_INT)) {
51			throw new \Exception('The threshold and amount of shares must be integers.');
52			}
53
54			if ($sharesThreshold > $sharesAmount) {
55			throw new \Exception('The threshold must be lower than or equal to the amount of shares.');
56			}
57
58			$status = 'success';
59			$response = Secret::share(
60			$secret,
61			$sharesAmount,
62			$sharesThreshold
63			);
64			} catch (Exception $exception) {
65			$status = 'error';
66			$response = $exception->getMessage();
67			}
68			}
69
70			// Recover
71
72			if ($action === 'recover') {
73			$shares = $request->input('shares');
74			try {
75			$status = 'success';
76			$response = Secret::recover(array_filter($shares));
77			} catch (Exception $exception) {
78			$status = 'error';
79			$response = $exception->getMessage();
80			}
81			}
82
83			// Return response
84			return view(
85			'index',
86			[
87			'version' => $app->version(),
88			'action' => $action,
89			'status' => (empty($status)) ? null : $status,
90			'response' => json_encode($response),
91			'shareAmount' => (empty($sharesAmount)) ? null : $sharesAmount,
92			'shareThreshold' => (empty($sharesThreshold)) ? null : $sharesThreshold,
93			]
94			);
95			});
96

marcinlawnik / shamir-secret-sharing-web

Issues (2)

Security Analysis not enabled

app/Http/routes.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like