Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 16 | class EnumSet implements Iterator, Countable |
||
| 17 | { |
||
| 18 | /** |
||
| 19 | * The classname of the Enumeration |
||
| 20 | * @var string |
||
| 21 | */ |
||
| 22 | private $enumeration; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * BitSet of all attached enumerations in little endian |
||
| 26 | * @var string |
||
| 27 | */ |
||
| 28 | private $bitset; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * Ordinal number of current iterator position |
||
| 32 | * @var int |
||
| 33 | */ |
||
| 34 | private $ordinal = 0; |
||
| 35 | |||
| 36 | /** |
||
| 37 | * Highest possible ordinal number |
||
| 38 | * @var int |
||
| 39 | */ |
||
| 40 | private $ordinalMax; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Constructor |
||
| 44 | * |
||
| 45 | * @param string $enumeration The classname of the enumeration |
||
| 46 | * @throws InvalidArgumentException |
||
| 47 | */ |
||
| 48 | 20 | public function __construct($enumeration) |
|
| 63 | |||
| 64 | /** |
||
| 65 | * Get the classname of enumeration this set is for |
||
| 66 | * @return string |
||
| 67 | * @deprecated Please use getEnumeration() instead |
||
| 68 | */ |
||
| 69 | public function getEnumClass() |
||
| 73 | |||
| 74 | /** |
||
| 75 | * Get the classname of the enumeration |
||
| 76 | * @return string |
||
| 77 | */ |
||
| 78 | 2 | public function getEnumeration() |
|
| 82 | |||
| 83 | /** |
||
| 84 | * Attach a new enumerator or overwrite an existing one |
||
| 85 | * @param Enum|null|boolean|int|float|string $enumerator |
||
| 86 | * @return void |
||
| 87 | * @throws InvalidArgumentException On an invalid given enumerator |
||
| 88 | */ |
||
| 89 | 12 | public function attach($enumerator) |
|
| 94 | |||
| 95 | /** |
||
| 96 | * Detach the given enumerator |
||
| 97 | * @param Enum|null|boolean|int|float|string $enumerator |
||
| 98 | * @return void |
||
| 99 | * @throws InvalidArgumentException On an invalid given enumerator |
||
| 100 | */ |
||
| 101 | 6 | public function detach($enumerator) |
|
| 106 | |||
| 107 | /** |
||
| 108 | * Test if the given enumerator was attached |
||
| 109 | * @param Enum|null|boolean|int|float|string $enumerator |
||
| 110 | * @return boolean |
||
| 111 | */ |
||
| 112 | 9 | public function contains($enumerator) |
|
| 117 | |||
| 118 | /* Iterator */ |
||
| 119 | |||
| 120 | /** |
||
| 121 | * Get the current enumerator |
||
| 122 | * @return Enum|null Returns the current enumerator or NULL on an invalid iterator position |
||
| 123 | */ |
||
| 124 | 5 | public function current() |
|
| 133 | |||
| 134 | /** |
||
| 135 | * Get the ordinal number of the current iterator position |
||
| 136 | * @return int |
||
| 137 | */ |
||
| 138 | 6 | public function key() |
|
| 142 | |||
| 143 | /** |
||
| 144 | * Go to the next valid iterator position. |
||
| 145 | * If no valid iterator position is found the iterator position will be the last possible + 1. |
||
| 146 | * @return void |
||
| 147 | */ |
||
| 148 | 11 | public function next() |
|
| 157 | |||
| 158 | /** |
||
| 159 | * Go to the first valid iterator position. |
||
| 160 | * If no valid iterator position in found the iterator position will be 0. |
||
| 161 | * @return void |
||
| 162 | */ |
||
| 163 | 9 | public function rewind() |
|
| 172 | |||
| 173 | /** |
||
| 174 | * Test if the iterator in a valid state |
||
| 175 | * @return boolean |
||
| 176 | */ |
||
| 177 | 6 | public function valid() |
|
| 181 | |||
| 182 | /* Countable */ |
||
| 183 | |||
| 184 | /** |
||
| 185 | * Count the number of elements |
||
| 186 | * @return int |
||
| 187 | */ |
||
| 188 | 8 | public function count() |
|
| 200 | |||
| 201 | /** |
||
| 202 | * Get binary bitset in little-endian order |
||
| 203 | * |
||
| 204 | * @return string |
||
| 205 | */ |
||
| 206 | public function getBinaryBitsetLe() |
||
| 210 | |||
| 211 | /** |
||
| 212 | * Set binary bitset in little-endian order |
||
| 213 | * |
||
| 214 | * NOTE: It resets the current position of the iterator |
||
| 215 | * |
||
| 216 | * @param string $bitset |
||
| 217 | * @return void |
||
| 218 | * @throws InvalidArgumentException On a non string is given as Parameter |
||
| 219 | */ |
||
| 220 | 4 | public function setBinaryBitsetLe($bitset) |
|
| 240 | |||
| 241 | /** |
||
| 242 | * Get binary bitset in big-endian order |
||
| 243 | * |
||
| 244 | * @return string |
||
| 245 | */ |
||
| 246 | 4 | public function getBinaryBitsetBe() |
|
| 250 | |||
| 251 | /** |
||
| 252 | * Set binary bitset in big-endian order |
||
| 253 | * |
||
| 254 | * NOTE: It resets the current position of the iterator |
||
| 255 | * |
||
| 256 | * @param string $bitset |
||
| 257 | * @return void |
||
| 258 | * @throws InvalidArgumentException On a non string is given as Parameter |
||
| 259 | */ |
||
| 260 | 5 | public function setBinaryBitsetBe($bitset) |
|
| 268 | |||
| 269 | /** |
||
| 270 | * Get the binary bitset |
||
| 271 | * |
||
| 272 | * @return string Returns the binary bitset in big-endian order |
||
| 273 | * @deprecated Please use getBinaryBitsetBE() instead |
||
| 274 | */ |
||
| 275 | public function getBitset() |
||
| 279 | |||
| 280 | /** |
||
| 281 | * Set the bitset. |
||
| 282 | * NOTE: It resets the current position of the iterator |
||
| 283 | * |
||
| 284 | * @param string $bitset The binary bitset in big-endian order |
||
| 285 | * @return void |
||
| 286 | * @throws InvalidArgumentException On a non string is given as Parameter |
||
| 287 | * @deprecated Please use setBinaryBitsetBE() instead |
||
| 288 | */ |
||
| 289 | public function setBitset($bitset) |
||
| 293 | |||
| 294 | /** |
||
| 295 | * Get a bit at the given ordinal number |
||
| 296 | * |
||
| 297 | * @param $ordinal int Ordinal number of bit to get |
||
| 298 | * @return boolean |
||
| 299 | */ |
||
| 300 | 16 | private function getBit($ordinal) |
|
| 304 | |||
| 305 | /** |
||
| 306 | * Set a bit at the given ordinal number |
||
| 307 | * |
||
| 308 | * @param $ordinal int Ordnal number of bit to set |
||
| 309 | * @return void |
||
| 310 | */ |
||
| 311 | 12 | private function setBit($ordinal) |
|
| 316 | |||
| 317 | /** |
||
| 318 | * Unset a bit at the given ordinal number |
||
| 319 | * |
||
| 320 | * @param $ordinal int Ordinal number of bit to unset |
||
| 321 | * @return void |
||
| 322 | */ |
||
| 323 | 6 | private function unsetBit($ordinal) |
|
| 328 | } |
||
| 329 |