Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Enum often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Enum, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 16 | abstract class Enum |
||
| 17 | { |
||
| 18 | /** |
||
| 19 | * The selected enumerator value |
||
| 20 | * |
||
| 21 | * @var null|bool|int|float|string |
||
| 22 | */ |
||
| 23 | private $value; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * The ordinal number of the enumerator |
||
| 27 | * |
||
| 28 | * @var null|int |
||
| 29 | */ |
||
| 30 | private $ordinal; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * An array of available constants by class |
||
| 34 | * |
||
| 35 | * @var array ["$class" => ["$name" => $value, ...], ...] |
||
| 36 | */ |
||
| 37 | private static $constants = array(); |
||
| 38 | |||
| 39 | /** |
||
| 40 | * Already instantiated enumerators |
||
| 41 | * |
||
| 42 | * @var array ["$class" => ["$name" => $instance, ...], ...] |
||
| 43 | */ |
||
| 44 | private static $instances = array(); |
||
| 45 | |||
| 46 | /** |
||
| 47 | * Constructor |
||
| 48 | * |
||
| 49 | * @param null|bool|int|float|string $value The value of the enumerator |
||
| 50 | * @param int|null $ordinal The ordinal number of the enumerator |
||
| 51 | */ |
||
| 52 | 32 | final private function __construct($value, $ordinal = null) |
|
| 57 | |||
| 58 | /** |
||
| 59 | * Get the name of the enumerator |
||
| 60 | * |
||
| 61 | * @return string |
||
| 62 | * @see getName() |
||
| 63 | */ |
||
| 64 | 1 | public function __toString() |
|
| 68 | |||
| 69 | /** |
||
| 70 | * @throws LogicException Enums are not cloneable |
||
| 71 | * because instances are implemented as singletons |
||
| 72 | */ |
||
| 73 | 1 | final private function __clone() |
|
| 77 | |||
| 78 | /** |
||
| 79 | * @throws LogicException Enums are not serializable |
||
| 80 | * because instances are implemented as singletons |
||
| 81 | */ |
||
| 82 | 1 | final public function __sleep() |
|
| 86 | |||
| 87 | /** |
||
| 88 | * @throws LogicException Enums are not serializable |
||
| 89 | * because instances are implemented as singletons |
||
| 90 | */ |
||
| 91 | 1 | final public function __wakeup() |
|
| 95 | |||
| 96 | /** |
||
| 97 | * Get the value of the enumerator |
||
| 98 | * |
||
| 99 | * @return null|bool|int|float|string |
||
| 100 | */ |
||
| 101 | 21 | final public function getValue() |
|
| 105 | |||
| 106 | /** |
||
| 107 | * Get the name of the enumerator |
||
| 108 | * |
||
| 109 | * @return string |
||
| 110 | */ |
||
| 111 | 8 | final public function getName() |
|
| 115 | |||
| 116 | /** |
||
| 117 | * Get the ordinal number of the enumerator |
||
| 118 | * |
||
| 119 | * @return int |
||
| 120 | */ |
||
| 121 | 44 | final public function getOrdinal() |
|
| 140 | |||
| 141 | /** |
||
| 142 | * Compare this enumerator against another and check if it's the same. |
||
| 143 | * |
||
| 144 | * @param mixed $enumerator |
||
| 145 | * @return bool |
||
| 146 | */ |
||
| 147 | 1 | final public function is($enumerator) |
|
| 151 | |||
| 152 | /** |
||
| 153 | * Get an enumerator instance of the given value or instance |
||
| 154 | * |
||
| 155 | * @param static|null|bool|int|float|string $value |
||
| 156 | * @return static |
||
| 157 | * @throws InvalidArgumentException On an unknwon or invalid value |
||
| 158 | * @throws LogicException On ambiguous constant values |
||
| 159 | */ |
||
| 160 | 67 | final public static function get($value) |
|
| 168 | |||
| 169 | /** |
||
| 170 | * Get an enumerator instance by the given value |
||
| 171 | * |
||
| 172 | * @param mixed $value |
||
| 173 | * @return static |
||
| 174 | * @throws InvalidArgumentException On an unknwon or invalid value |
||
| 175 | * @throws LogicException On ambiguous constant values |
||
| 176 | */ |
||
| 177 | 48 | final public static function byValue($value) |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Get an enumerator instance by the given name |
||
| 198 | * |
||
| 199 | * @param string $name The name of the enumerator |
||
| 200 | * @return static |
||
| 201 | * @throws InvalidArgumentException On an invalid or unknown name |
||
| 202 | * @throws LogicException On ambiguous values |
||
| 203 | */ |
||
| 204 | 36 | final public static function byName($name) |
|
| 219 | |||
| 220 | /** |
||
| 221 | * Get an enumeration instance by the given ordinal number |
||
| 222 | * |
||
| 223 | * @param int $ordinal The ordinal number or the enumerator |
||
| 224 | * @return static |
||
| 225 | * @throws InvalidArgumentException On an invalid ordinal number |
||
| 226 | * @throws LogicException On ambiguous values |
||
| 227 | */ |
||
| 228 | 19 | final public static function byOrdinal($ordinal) |
|
| 248 | |||
| 249 | /** |
||
| 250 | * Get an enumerator instance by the given name |
||
| 251 | * |
||
| 252 | * @param string $name The name of the enumerator |
||
| 253 | * @return static |
||
| 254 | * @throws InvalidArgumentException On an invalid or unknown name |
||
| 255 | * @throws LogicException On ambiguous values |
||
| 256 | * @deprecated |
||
| 257 | */ |
||
| 258 | final public static function getByName($name) |
||
| 262 | |||
| 263 | /** |
||
| 264 | * Get an enumeration instance by the given ordinal number |
||
| 265 | * |
||
| 266 | * @param int $ordinal The ordinal number or the enumerator |
||
| 267 | * @return static |
||
| 268 | * @throws InvalidArgumentException On an invalid ordinal number |
||
| 269 | * @throws LogicException On ambiguous values |
||
| 270 | * @deprecated |
||
| 271 | */ |
||
| 272 | final public static function getByOrdinal($ordinal) |
||
| 276 | |||
| 277 | /** |
||
| 278 | * Clear all instantiated enumerators of the called class |
||
| 279 | * |
||
| 280 | * NOTE: This can break singleton behavior ... use it with caution! |
||
| 281 | * |
||
| 282 | * @return void |
||
| 283 | */ |
||
| 284 | 31 | final public static function clear() |
|
| 289 | |||
| 290 | /** |
||
| 291 | * Get a list of enumerator instances ordered by ordinal number |
||
| 292 | * |
||
| 293 | * @return static[] |
||
| 294 | */ |
||
| 295 | 13 | final public static function getEnumerators() |
|
| 299 | |||
| 300 | /** |
||
| 301 | * Get all available constants of the called class |
||
| 302 | * |
||
| 303 | * @return array |
||
| 304 | * @throws LogicException On ambiguous constant values |
||
| 305 | */ |
||
| 306 | 58 | final public static function getConstants() |
|
| 310 | |||
| 311 | /** |
||
| 312 | * Is the given enumerator part of this enumeration |
||
| 313 | * |
||
| 314 | * @param static|null|bool|int|float|string $value |
||
| 315 | * @return bool |
||
| 316 | */ |
||
| 317 | 1 | final public static function has($value) |
|
| 328 | |||
| 329 | /** |
||
| 330 | * Detect all available constants by the given class |
||
| 331 | * |
||
| 332 | * @param string $class |
||
| 333 | * @return array |
||
| 334 | * @throws LogicException On ambiguous constant values |
||
| 335 | */ |
||
| 336 | 78 | private static function detectConstants($class) |
|
| 382 | |||
| 383 | /** |
||
| 384 | * Get an enumerator instance by the given name. |
||
| 385 | * |
||
| 386 | * This will be called automatically on calling a method |
||
| 387 | * with the same name of a defined enumerator. |
||
| 388 | * |
||
| 389 | * @param string $method The name of the enumeraotr (called as method) |
||
| 390 | * @param array $args There should be no arguments |
||
| 391 | * @return static |
||
| 392 | * @throws InvalidArgumentException On an invalid or unknown name |
||
| 393 | * @throws LogicException On ambiguous constant values |
||
| 394 | */ |
||
| 395 | 21 | final public static function __callStatic($method, array $args) |
|
| 399 | } |
||
| 400 |