Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like EnumSet often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use EnumSet, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
16 | class EnumSet implements Iterator, Countable |
||
17 | { |
||
18 | /** |
||
19 | * The classname of the Enumeration |
||
20 | * @var string |
||
21 | */ |
||
22 | private $enumeration; |
||
23 | |||
24 | /** |
||
25 | * BitSet of all attached enumerations in little endian |
||
26 | * @var string |
||
27 | */ |
||
28 | private $bitset; |
||
29 | |||
30 | /** |
||
31 | * Ordinal number of current iterator position |
||
32 | * @var int |
||
33 | */ |
||
34 | private $ordinal = 0; |
||
35 | |||
36 | /** |
||
37 | * Highest possible ordinal number |
||
38 | * @var int |
||
39 | */ |
||
40 | private $ordinalMax; |
||
41 | |||
42 | /** |
||
43 | * Constructor |
||
44 | * |
||
45 | * @param string $enumeration The classname of the enumeration |
||
46 | * @throws InvalidArgumentException |
||
47 | */ |
||
48 | 42 | public function __construct($enumeration) |
|
49 | { |
||
50 | 42 | View Code Duplication | if (!is_subclass_of($enumeration, __NAMESPACE__ . '\Enum')) { |
51 | 1 | throw new InvalidArgumentException(sprintf( |
|
52 | 1 | "This EnumSet can handle subclasses of '%s' only", |
|
53 | __NAMESPACE__ . '\Enum' |
||
54 | 1 | )); |
|
55 | } |
||
56 | |||
57 | 41 | $this->enumeration = $enumeration; |
|
58 | 41 | $this->ordinalMax = count($enumeration::getConstants()); |
|
59 | |||
60 | // init the bitset with zeros |
||
61 | 41 | $this->bitset = str_repeat("\0", ceil($this->ordinalMax / 8)); |
|
62 | 41 | } |
|
63 | |||
64 | /** |
||
65 | * Get the classname of enumeration this set is for |
||
66 | * @return string |
||
67 | * @deprecated Please use getEnumeration() instead |
||
68 | */ |
||
69 | public function getEnumClass() |
||
70 | { |
||
71 | return $this->getEnumeration(); |
||
72 | } |
||
73 | |||
74 | /** |
||
75 | * Get the classname of the enumeration |
||
76 | * @return string |
||
77 | */ |
||
78 | 12 | public function getEnumeration() |
|
82 | |||
83 | /** |
||
84 | * Attach a new enumerator or overwrite an existing one |
||
85 | * @param Enum|null|boolean|int|float|string $enumerator |
||
86 | * @return void |
||
87 | * @throws InvalidArgumentException On an invalid given enumerator |
||
88 | */ |
||
89 | 31 | public function attach($enumerator) |
|
94 | |||
95 | /** |
||
96 | * Detach the given enumerator |
||
97 | * @param Enum|null|boolean|int|float|string $enumerator |
||
98 | * @return void |
||
99 | * @throws InvalidArgumentException On an invalid given enumerator |
||
100 | */ |
||
101 | 7 | public function detach($enumerator) |
|
106 | |||
107 | /** |
||
108 | * Test if the given enumerator was attached |
||
109 | * @param Enum|null|boolean|int|float|string $enumerator |
||
110 | * @return boolean |
||
111 | */ |
||
112 | 11 | public function contains($enumerator) |
|
117 | |||
118 | /* Iterator */ |
||
119 | |||
120 | /** |
||
121 | * Get the current enumerator |
||
122 | * @return Enum|null Returns the current enumerator or NULL on an invalid iterator position |
||
123 | */ |
||
124 | 9 | public function current() |
|
133 | |||
134 | /** |
||
135 | * Get the ordinal number of the current iterator position |
||
136 | * @return int |
||
137 | */ |
||
138 | 6 | public function key() |
|
142 | |||
143 | /** |
||
144 | * Go to the next valid iterator position. |
||
145 | * If no valid iterator position is found the iterator position will be the last possible + 1. |
||
146 | * @return void |
||
147 | */ |
||
148 | 16 | public function next() |
|
157 | |||
158 | /** |
||
159 | * Go to the first valid iterator position. |
||
160 | * If no valid iterator position in found the iterator position will be 0. |
||
161 | * @return void |
||
162 | */ |
||
163 | 10 | public function rewind() |
|
172 | |||
173 | /** |
||
174 | * Test if the iterator in a valid state |
||
175 | * @return boolean |
||
176 | */ |
||
177 | 10 | public function valid() |
|
181 | |||
182 | /* Countable */ |
||
183 | |||
184 | /** |
||
185 | * Count the number of elements |
||
186 | * @return int |
||
187 | */ |
||
188 | 11 | public function count() |
|
206 | |||
207 | /** |
||
208 | * Check if this EnumSet is the same as other |
||
209 | * @param EnumSet $other |
||
210 | * @return bool |
||
211 | */ |
||
212 | 2 | public function isEqual(EnumSet $other) |
|
217 | |||
218 | /** |
||
219 | * Check if this EnumSet is a subset of other |
||
220 | * @param EnumSet $other |
||
221 | * @return bool |
||
222 | */ |
||
223 | 4 | View Code Duplication | public function isSubset(EnumSet $other) |
232 | |||
233 | /** |
||
234 | * Check if this EnumSet is a superset of other |
||
235 | * @param EnumSet $other |
||
236 | * @return bool |
||
237 | */ |
||
238 | 4 | View Code Duplication | public function isSuperset(EnumSet $other) |
247 | |||
248 | /** |
||
249 | * Get ordinal numbers of the defined enumerators as array |
||
250 | * @return int[] |
||
251 | */ |
||
252 | 8 | public function getOrdinals() |
|
271 | |||
272 | /** |
||
273 | * Get values of the defined enumerators as array |
||
274 | * @return null[]|bool[]|int[]|float[]|string[] |
||
275 | */ |
||
276 | 2 | public function getValues() |
|
284 | |||
285 | /** |
||
286 | * Get names of the defined enumerators as array |
||
287 | * @return string[] |
||
288 | */ |
||
289 | 2 | public function getNames() |
|
297 | |||
298 | /** |
||
299 | * Get the defined enumerators as array |
||
300 | * @return Enum[] |
||
301 | */ |
||
302 | 6 | public function getEnumerators() |
|
311 | |||
312 | /** |
||
313 | * Get binary bitset in little-endian order |
||
314 | * |
||
315 | * @return string |
||
316 | */ |
||
317 | 10 | public function getBinaryBitsetLe() |
|
321 | |||
322 | /** |
||
323 | * Set binary bitset in little-endian order |
||
324 | * |
||
325 | * NOTE: It resets the current position of the iterator |
||
326 | * |
||
327 | * @param string $bitset |
||
328 | * @return void |
||
329 | * @throws InvalidArgumentException On a non string is given as Parameter |
||
330 | */ |
||
331 | 6 | public function setBinaryBitsetLe($bitset) |
|
351 | |||
352 | /** |
||
353 | * Get binary bitset in big-endian order |
||
354 | * |
||
355 | * @return string |
||
356 | */ |
||
357 | 2 | public function getBinaryBitsetBe() |
|
361 | |||
362 | /** |
||
363 | * Set binary bitset in big-endian order |
||
364 | * |
||
365 | * NOTE: It resets the current position of the iterator |
||
366 | * |
||
367 | * @param string $bitset |
||
368 | * @return void |
||
369 | * @throws InvalidArgumentException On a non string is given as Parameter |
||
370 | */ |
||
371 | 3 | public function setBinaryBitsetBe($bitset) |
|
379 | |||
380 | /** |
||
381 | * Get the binary bitset |
||
382 | * |
||
383 | * @return string Returns the binary bitset in big-endian order |
||
384 | * @deprecated Please use getBinaryBitsetBe() instead |
||
385 | */ |
||
386 | public function getBitset() |
||
390 | |||
391 | /** |
||
392 | * Set the bitset. |
||
393 | * NOTE: It resets the current position of the iterator |
||
394 | * |
||
395 | * @param string $bitset The binary bitset in big-endian order |
||
396 | * @return void |
||
397 | * @throws InvalidArgumentException On a non string is given as Parameter |
||
398 | * @deprecated Please use setBinaryBitsetBe() instead |
||
399 | */ |
||
400 | public function setBitset($bitset) |
||
404 | |||
405 | /** |
||
406 | * Get a bit at the given ordinal number |
||
407 | * |
||
408 | * @param $ordinal int Ordinal number of bit to get |
||
409 | * @return boolean |
||
410 | */ |
||
411 | 21 | private function getBit($ordinal) |
|
415 | |||
416 | /** |
||
417 | * Set a bit at the given ordinal number |
||
418 | * |
||
419 | * @param $ordinal int Ordnal number of bit to set |
||
420 | * @return void |
||
421 | */ |
||
422 | 31 | private function setBit($ordinal) |
|
427 | |||
428 | /** |
||
429 | * Unset a bit at the given ordinal number |
||
430 | * |
||
431 | * @param $ordinal int Ordinal number of bit to unset |
||
432 | * @return void |
||
433 | */ |
||
434 | 7 | private function unsetBit($ordinal) |
|
439 | } |
||
440 |