| Conditions | 1 |
| Paths | 1 |
| Total Lines | 81 |
| Code Lines | 53 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 123 | public function testArrayAccessWithObjects() |
||
| 124 | { |
||
| 125 | $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic'); |
||
| 126 | |||
| 127 | $enumMap[EnumBasic::ONE()] = 'first'; |
||
| 128 | $enumMap[EnumBasic::TWO()] = 'second'; |
||
| 129 | |||
| 130 | $this->assertTrue(isset($enumMap[EnumBasic::ONE()])); |
||
| 131 | $this->assertTrue(isset($enumMap[EnumBasic::TWO()])); |
||
| 132 | |||
| 133 | $this->assertSame('first', $enumMap[EnumBasic::ONE()]); |
||
| 134 | $this->assertSame('second', $enumMap[EnumBasic::TWO()]); |
||
| 135 | |||
| 136 | unset($enumMap[EnumBasic::ONE()], $enumMap[EnumBasic::TWO()]); |
||
| 137 | |||
| 138 | $this->assertFalse(isset($enumMap[EnumBasic::ONE()])); |
||
| 139 | $this->assertFalse(isset($enumMap[EnumBasic::TWO()])); |
||
| 140 | } |
||
| 141 | |||
| 142 | public function testArrayAccessWithValues() |
||
| 143 | { |
||
| 144 | $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic'); |
||
| 145 | |||
| 146 | $enumMap[EnumBasic::ONE] = 'first'; |
||
| 147 | $enumMap[EnumBasic::TWO] = 'second'; |
||
| 148 | |||
| 149 | $this->assertTrue(isset($enumMap[EnumBasic::ONE])); |
||
| 150 | $this->assertTrue(isset($enumMap[EnumBasic::TWO])); |
||
| 151 | |||
| 152 | $this->assertSame('first', $enumMap[EnumBasic::ONE]); |
||
| 153 | $this->assertSame('second', $enumMap[EnumBasic::TWO]); |
||
| 154 | |||
| 155 | unset($enumMap[EnumBasic::ONE], $enumMap[EnumBasic::TWO]); |
||
| 156 | |||
| 157 | $this->assertFalse(isset($enumMap[EnumBasic::ONE])); |
||
| 158 | $this->assertFalse(isset($enumMap[EnumBasic::TWO])); |
||
| 159 | } |
||
| 160 | |||
| 161 | public function testConstructThrowsInvalidArgumentExceptionIfEnumClassDoesNotExtendBaseEnum() |
||
| 162 | { |
||
| 163 | $this->setExpectedException('InvalidArgumentException'); |
||
| 164 | new EnumMap('stdClass'); |
||
| 165 | } |
||
| 166 | |||
| 167 | public function testInitEnumThrowsInvalidArgumentExceptionOnInvalidEnumGiven() |
||
| 168 | { |
||
| 169 | $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic'); |
||
| 170 | |||
| 171 | $this->setExpectedException('InvalidArgumentException'); |
||
| 172 | $enumMap->offsetSet(EnumInheritance::INHERITANCE(), 'test'); |
||
| 173 | } |
||
| 174 | |||
| 175 | public function testContainsAndOffsetExistsReturnsFalseOnInvalidEnum() |
||
| 176 | { |
||
| 177 | $enumMap = new EnumMap('MabeEnumTest\TestAsset\EnumBasic'); |
||
| 178 | |||
| 179 | $this->assertFalse($enumMap->contains(EnumInheritance::INHERITANCE())); |
||
| 180 | $this->assertFalse($enumMap->contains(EnumInheritance::INHERITANCE)); |
||
| 181 | |||
| 182 | $this->assertFalse(isset($enumMap[EnumInheritance::INHERITANCE()])); |
||
| 183 | $this->assertFalse(isset($enumMap[EnumInheritance::INHERITANCE])); |
||
| 184 | } |
||
| 185 | } |
||
| 186 |