Issues in TracksAbstract.php (master) - Issues in master - maqe/laravel-qwatcher - Measure and Improve Code Quality continuously with Scrutinizer

Issues (32)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Tracks/TracksAbstract.php (1 issue)

Labels

Documentation 1

Severity

Informational 1

Atthaphon Urairat 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php namespace Maqe\Qwatcher\Tracks;

use Illuminate\Queue\Queue;
use Carbon\Carbon;
use Maqe\Qwatcher\Tracks\Enums\StatusType;

abstract class TracksAbstract extends Queue
{
    /**
     * Push job to tracks table
     *
     * @param  $id          The queue id
     * @param  $job         The queue job object
     * @param  array  $meta The meta data array
     * @return mixed
     */
    abstract public function pushToTracks($id, $job = null, array $meta = []);

    /**
     * Create tracks record from job
     *
     * @param  mixed    $job        The queue job object
     * @param  array    $meta       The meta data array
     * @return integer  $id         The new tracks id
     */
    protected function create($id, $job = null, array $meta = [])
    {
        return Tracks::create($this->prepareRecord($id, $job, $meta))->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Update status tracks record by queue id and status type
     *
     * @param  integer  $id         The queue id to track queue record
     * @param  enum     $status     The status tracks type
     * @return boolean|mixed        The update result
     */
    protected function update($id, $job, $status)
    {
        return Tracks::where('queue_id', $id)->update(['attempts' => $job->attempts(), "{$status}_at" => Carbon::now()]);
    }

    /**
     * Prepare record before create new record
     *
     * @param  mixed $job           The queue job object
     * @return array                The array for input to database
     */
    protected function prepareRecord($id, $job, array $meta = [])
    {
        return [
            'driver' => config('queue.default'),
            'queue_id' => $id,
            'payload' => $this->createPayload($job),
            'attempts' => 0,
            'job_name' => get_class($job),
            'meta' => json_encode($this->setMetaData($job, $meta)),
            'queue_at' => Carbon::now(),
        ];
    }

    /**
     * Include default meta data job_name into meta column
     *
     * @param $job                  The queue job object
     * @param array  $meta          The meta array after add default
     */
    protected function setMetaData($job, array $meta = [])
    {
        return array_add($meta, 'job_name', get_class($job));
    }
}


1			<?php namespace Maqe\Qwatcher\Tracks;
2
3			use Illuminate\Queue\Queue;
4			use Carbon\Carbon;
5			use Maqe\Qwatcher\Tracks\Enums\StatusType;
6
7			abstract class TracksAbstract extends Queue
8			{
9			/**
10			* Push job to tracks table
11			*
12			* @param $id The queue id
13			* @param $job The queue job object
14			* @param array $meta The meta data array
15			* @return mixed
16			*/
17			abstract public function pushToTracks($id, $job = null, array $meta = []);
18
19			/**
20			* Create tracks record from job
21			*
22			* @param mixed $job The queue job object
23			* @param array $meta The meta data array
24			* @return integer $id The new tracks id
25			*/
26			protected function create($id, $job = null, array $meta = [])
27			{
28			return Tracks::create($this->prepareRecord($id, $job, $meta))->id;
			0 ignored issues – show Documentation introduced 2016-11-04 04:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `id` does not exist on `object<Maqe\Qwatcher\Tracks\Tracks>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29			}
30
31			/**
32			* Update status tracks record by queue id and status type
33			*
34			* @param integer $id The queue id to track queue record
35			* @param enum $status The status tracks type
36			* @return boolean\|mixed The update result
37			*/
38			protected function update($id, $job, $status)
39			{
40			return Tracks::where('queue_id', $id)->update(['attempts' => $job->attempts(), "{$status}_at" => Carbon::now()]);
41			}
42
43			/**
44			* Prepare record before create new record
45			*
46			* @param mixed $job The queue job object
47			* @return array The array for input to database
48			*/
49			protected function prepareRecord($id, $job, array $meta = [])
50			{
51			return [
52			'driver' => config('queue.default'),
53			'queue_id' => $id,
54			'payload' => $this->createPayload($job),
55			'attempts' => 0,
56			'job_name' => get_class($job),
57			'meta' => json_encode($this->setMetaData($job, $meta)),
58			'queue_at' => Carbon::now(),
59			];
60			}
61
62			/**
63			* Include default meta data job_name into meta column
64			*
65			* @param $job The queue job object
66			* @param array $meta The meta array after add default
67			*/
68			protected function setMetaData($job, array $meta = [])
69			{
70			return array_add($meta, 'job_name', get_class($job));
71			}
72			}
73

maqe / laravel-qwatcher

Issues (32)

Security Analysis not enabled

src/Tracks/TracksAbstract.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like